You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Thomas Munro f24af0e04c Fix O_CLOEXEC flag handling in Windows port. ... PostgreSQL's src/port/open.c has always set bInheritHandle = TRUE when opening files on Windows, making all file descriptors inheritable by child processes. This meant the O_CLOEXEC flag, added to many call sites by commit 1da569ca1f (v16), was silently ignored. The original commit included a comment suggesting that our open() replacement doesn't create inheritable handles, but it was a mis- understanding of the code path. In practice, the code was creating inheritable handles in all cases. This hasn't caused widespread problems because most child processes (archive_command, COPY PROGRAM, etc.) operate on file paths passed as arguments rather than inherited file descriptors. Even if a child wanted to use an inherited handle, it would need to learn the numeric handle value, which isn't passed through our IPC mechanisms. Nonetheless, the current behavior is wrong. It violates documented O_CLOEXEC semantics, contradicts our own code comments, and makes PostgreSQL behave differently on Windows than on Unix. It also creates potential issues with future code or security auditing tools. To fix, define O_CLOEXEC to _O_NOINHERIT in master, previously used by O_DSYNC. We use different values in the back branches to preserve existing values. In pgwin32_open_handle() we set bInheritHandle according to whether O_CLOEXEC is specified, for the same atomic semantics as POSIX in multi-threaded programs that create processes. Backpatch-through: 16 Author: Bryan Green <dbryan.green@gmail.com> Co-authored-by: Thomas Munro <thomas.munro@gmail.com> (minor adjustments) Discussion: https://postgr.es/m/e2b16375-7430-4053-bda3-5d2194ff1880%40gmail.com		1 week ago
..
backend	Fix LOCK_TIMEOUT handling in slotsync worker.	1 week ago
bin	Print new OldestXID value in pg_resetwal when it's being changed	4 weeks ago
common	With GB18030, prevent SIGSEGV from reading past end of allocation.	8 months ago
fe_utils	In fmtIdEnc(), handle failure of enlargePQExpBuffer().	10 months ago
include	Fix O_CLOEXEC flag handling in Windows port.	1 week ago
interfaces	libpq: Prevent some overflows of int/size_t	1 month ago
makefiles	Optimize pg_popcount() with AVX-512 instructions.	2 years ago
pl	Translation updates	1 month ago
port	Fix O_CLOEXEC flag handling in Windows port.	1 week ago
template	Remove AIX support	2 years ago
test	Fix O_CLOEXEC flag handling in Windows port.	1 week ago
timezone	Update time zone data files to tzdata release 2025b.	8 months ago
tools	ci: Per-repo configuration for manually trigger tasks	4 months ago
tutorial	Update copyright for 2024	2 years ago
.gitignore	…
DEVELOPERS	…
Makefile	Remove distprep	2 years ago
Makefile.global.in	Don't put library-supplied -L/-I switches before user-supplied ones.	5 months ago
Makefile.shlib	Remove AIX support	2 years ago
meson.build	Update copyright for 2024	2 years ago
nls-global.mk	Fix update-po for the PGXS case	2 months ago