You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane f3b3b8d5be Compute correct em_nullable_relids in get_eclass_for_sort_expr(). ... Bug #8591 from Claudio Freire demonstrates that get_eclass_for_sort_expr must be able to compute valid em_nullable_relids for any new equivalence class members it creates. I'd worried about this in the commit message for db9f0e1d9a, but claimed that it wasn't a problem because multi-member ECs should already exist when it runs. That is transparently wrong, though, because this function is also called by initialize_mergeclause_eclasses, which runs during deconstruct_jointree. The example given in the bug report (which the new regression test item is based upon) fails because the COALESCE() expression is first seen by initialize_mergeclause_eclasses rather than process_equivalence. Fixing this requires passing the appropriate nullable_relids set to get_eclass_for_sort_expr, and it requires new code to compute that set for top-level expressions such as ORDER BY, GROUP BY, etc. We store the top-level nullable_relids in a new field in PlannerInfo to avoid computing it many times. In the back branches, I've added the new field at the end of the struct to minimize ABI breakage for planner plugins. There doesn't seem to be a good alternative to changing get_eclass_for_sort_expr's API signature, though. There probably aren't any third-party extensions calling that function directly; moreover, if there are, they probably need to think about what to pass for nullable_relids anyway. Back-patch to 9.2, like the previous patch in this area.		12 years ago
..
backend	Compute correct em_nullable_relids in get_eclass_for_sort_expr().	12 years ago
bin	Fix incorrect column name in psql \d code.	12 years ago
common	Use improved vsnprintf calling logic in more places.	12 years ago
include	Compute correct em_nullable_relids in get_eclass_for_sort_expr().	12 years ago
interfaces	Fix whitespace issues found by git diff --check, add gitattributes	12 years ago
makefiles	Remove leftovers of IRIX port	12 years ago
pl	Prevent leakage of cached plans and execution trees in plpgsql DO blocks.	12 years ago
port	Get rid of use of asprintf() in favor of a more portable implementation.	12 years ago
template	Remove leftovers of IRIX port	12 years ago
test	Compute correct em_nullable_relids in get_eclass_for_sort_expr().	12 years ago
timezone	Fix whitespace issues found by git diff --check, add gitattributes	12 years ago
tools	Fix whitespace	12 years ago
tutorial	Modernize string literal syntax in tutorial example.	13 years ago
.gitignore	…
DEVELOPERS	…
Makefile	Create libpgcommon, and move pg_malloc et al to it	13 years ago
Makefile.global.in	Switch dependency order of libpgcommon and libpgport	12 years ago
Makefile.shlib	Remove IRIX port.	12 years ago
bcc32.mak	Autoconfiscate selection of 64-bit int type for 64-bit large object API.	13 years ago
nls-global.mk	Remove maintainer-check target, fold into normal build	12 years ago
win32.mak	Autoconfiscate selection of 64-bit int type for 64-bit large object API.	13 years ago