You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 6655d931c6 Handle default NULL insertion a little better. ... If a column is omitted in an INSERT, and there's no column default, the code in preptlist.c generates a NULL Const to be inserted. Furthermore, if the column is of a domain type, we wrap the Const in CoerceToDomain, so as to throw a run-time error if the domain has a NOT NULL constraint. That's fine as far as it goes, but there are two problems: 1. We're being sloppy about the type/typmod that the Const is labeled with. It really should have the domain's base type/typmod, since it's the input to CoerceToDomain not the output. This can result in coerce_to_domain inserting a useless length-coercion function (useless because it's being applied to a null). The coercion would typically get const-folded away later, but it'd be better not to create it in the first place. 2. We're not applying expression preprocessing (specifically, eval_const_expressions) to the resulting expression tree. The planner's primary expression-preprocessing pass already happened, so that means the length coercion step and CoerceToDomain node miss preprocessing altogether. This is at the least inefficient, since it means the length coercion and CoerceToDomain will actually be executed for each inserted row, though they could be const-folded away in most cases. Worse, it seems possible that missing preprocessing for the length coercion could result in an invalid plan (for example, due to failing to perform default-function-argument insertion). I'm not aware of any live bug of that sort with core datatypes, and it might be unreachable for extension types as well because of restrictions of CREATE CAST, but I'm not entirely convinced that it's unreachable. Hence, it seems worth back-patching the fix (although I only went back to v14, as the patch doesn't apply cleanly at all in v13). There are several places in the rewriter that are building null domain constants the same way as preptlist.c. While those are before the planner and hence don't have any reachable bug, they're still applying a length coercion that will be const-folded away later, uselessly wasting cycles. Hence, make a utility routine that all of these places can call to do it right. Making this code more careful about the typmod assigned to the generated NULL constant has visible but cosmetic effects on some of the plans shown in contrib/postgres_fdw's regression tests. Discussion: https://postgr.es/m/1865579.1738113656@sss.pgh.pa.us Backpatch-through: 14		8 months ago
..
expected	Handle default NULL insertion a little better.	8 months ago
sql	Restrict accesses to non-system views and foreign tables during pg_dump.	1 year ago
.gitignore	…
Makefile	…
connection.c	Make postgres_fdw request remote time zone 'GMT' not 'UTC'.	1 year ago
deparse.c	Fix deparsing of Consts in postgres_fdw ORDER BY	2 years ago
meson.build	…
option.c	Fix Y2038 issues with MyStartTime.	11 months ago
postgres_fdw--1.0--1.1.sql	…
postgres_fdw--1.0.sql	…
postgres_fdw.c	postgres_fdw: Avoid "cursor can only scan forward" error.	1 year ago
postgres_fdw.control	…
postgres_fdw.h	Check relkind before using TABLESAMPLE in postgres_fdw	3 years ago
shippable.c	Pre-beta mechanical code beautification.	2 years ago