You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Fujii Masao 5fedf7417b Improve HINT message that FDW reports when there are no valid options. ... The foreign data wrapper's validator function provides a HINT message with list of valid options for the object specified in CREATE or ALTER command, when the option given in the command is invalid. Previously postgresql_fdw_validator() and the validator functions for postgres_fdw and dblink_fdw worked in that way even there were no valid options in the object, which could lead to the HINT message with empty list (because there were no valid options). For example, ALTER FOREIGN DATA WRAPPER postgres_fdw OPTIONS (format 'csv') reported the following ERROR and HINT messages. This behavior was confusing. ERROR: invalid option "format" HINT: Valid options in this context are: There is no such issue in file_fdw. The validator function for file_fdw reports the HINT message "There are no valid options in this context." instead in that case. This commit improves postgresql_fdw_validator() and the validator functions for postgres_fdw and dblink_fdw so that they do likewise. For example, this change causes the above ALTER FOREIGN DATA WRAPPER command to report the following messages. ERROR: invalid option "nonexistent" HINT: There are no valid options in this context. Author: Kosei Masumura Reviewed-by: Bharath Rupireddy, Fujii Masao Discussion: https://postgr.es/m/557d06cebe19081bfcc83ee2affc98d3@oss.nttdata.com		4 years ago
..
expected	Improve HINT message that FDW reports when there are no valid options.	4 years ago
input	Use setenv() in preference to putenv().	5 years ago
output	Use setenv() in preference to putenv().	5 years ago
sql	Improve HINT message that FDW reports when there are no valid options.	4 years ago
.gitignore	Support "make check" in contrib	15 years ago
Makefile	Remove support for upgrading extensions from "unpackaged" state.	6 years ago
dblink--1.0--1.1.sql	Fix typo in update scripts for some contrib modules.	12 years ago
dblink--1.1--1.2.sql	Fix parallel-safety markings for contrib/dblink.	9 years ago
dblink--1.2.sql	Fix parallel-safety markings for contrib/dblink.	9 years ago
dblink.c	Improve HINT message that FDW reports when there are no valid options.	4 years ago
dblink.control	Update dblink extension for parallel query.	9 years ago
pg_service.conf	Diagnose incompatible OpenLDAP versions during build and test.	11 years ago