postgres

History

Etsuro Fujita f862d57057 Further fix for EvalPlanQual with mix of local and foreign partitions. We assume that direct-modify ForeignScan nodes cannot be re-evaluated during EvalPlanQual processing, but the rework for inherited UPDATE/DELETE in commit `86dc90056` changed things, without considering that, so that such ForeignScan nodes get called as part of the EvalPlanQual subtree during EvalPlanQual processing in the case of an inherited UPDATE/DELETE where the inheritance set contains foreign target relations. To avoid re-evaluating such ForeignScan nodes during EvalPlanQual processing, commit `c3928b467` modified nodeForeignscan.c, but the assumption made there that ExecForeignScan() should never be called for such ForeignScan nodes during EvalPlanQual processing turned out to be wrong in some cases, leading to a segmentation fault or a "cannot re-evaluate a Foreign Update or Delete during EvalPlanQual" error. Fix by modifying nodeForeignscan.c further to avoid re-evaluating such ForeignScan nodes even in ExecForeignScan()/ExecReScanForeignScan() during EvalPlanQual processing. Since this makes non-reachable the test-and-elog added to ForeignNext() by commit `c3928b467` that produced the aforesaid error, convert the test-and-elog to an Assert. Per bug #17355 from Alexander Lakhin. Back-patch to v14 where both commits came in. Patch by me, reviewed and tested by Alexander Lakhin and Amit Langote. Discussion: https://postgr.es/m/17355-de8e362eb7001a96@postgresql.org		4 years ago
..
backend	Further fix for EvalPlanQual with mix of local and foreign partitions.	4 years ago
bin	Remove configure's check for rl_completion_append_character.	4 years ago
common	Improve code clarity in epilogue of UTF-8 verification fast path	4 years ago
fe_utils	Avoid calling gettext() in signal handlers.	4 years ago
include	Remove configure's check for rl_completion_append_character.	4 years ago
interfaces	Fix race condition in gettext() initialization in libpq and ecpglib.	4 years ago
makefiles	Add NO_INSTALL option to pgxs	5 years ago
pl	plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure.	4 years ago
port	Simplify coding around path_contains_parent_reference().	4 years ago
template	…
test	Fix recovery conflict in 027_stream_regress.pl.	4 years ago
timezone	Update copyright for 2022	4 years ago
tools	Remove configure's check for rl_completion_append_character.	4 years ago
tutorial	Update copyright for 2022	4 years ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Add support for LZ4 compression in pg_receivewal	4 years ago
Makefile.shlib	AIX: Fix missing libpq symbols by respecting SHLIB_EXPORTS.	4 years ago
nls-global.mk	Add errhint_plural() function and make use of it	5 years ago