You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Etsuro Fujita 6f80a8d9c1 Disallow replacing joins with scans in problematic cases. ... Commit e7cb7ee14, which introduced the infrastructure for FDWs and custom scan providers to replace joins with scans, failed to add support handling of pseudoconstant quals assigned to replaced joins in createplan.c, leading to an incorrect plan without a gating Result node when postgres_fdw replaced a join with such a qual. To fix, we could add the support by 1) modifying the ForeignPath and CustomPath structs to store the list of RestrictInfo nodes to apply to the join, as in JoinPaths, if they represent foreign and custom scans replacing a join with a scan, and by 2) modifying create_scan_plan() in createplan.c to use that list in that case, instead of the baserestrictinfo list, to get pseudoconstant quals assigned to the join; but #1 would cause an ABI break. So fix by modifying the infrastructure to just disallow replacing joins with such quals. Back-patch to all supported branches. Reported by Nishant Sharma. Patch by me, reviewed by Nishant Sharma and Richard Guo. Discussion: https://postgr.es/m/CADrsxdbcN1vejBaf8a%2BQhrZY5PXL-04mCd4GDu6qm6FigDZd6Q%40mail.gmail.com		2 years ago
..
expected	Disallow replacing joins with scans in problematic cases.	2 years ago
sql	Disallow replacing joins with scans in problematic cases.	2 years ago
.gitignore	Add postgres_fdw contrib module.	13 years ago
Makefile	postgres_fdw: Add function to list cached connections to foreign servers.	5 years ago
connection.c	Refactor some code related to wait events "BufferPin" and "Extension"	2 years ago
deparse.c	Fix various typos in code and tests	2 years ago
meson.build	Update copyright for 2023	3 years ago
option.c	Expand some more uses of "deleg" to "delegation" or "delegated".	2 years ago
postgres_fdw--1.0--1.1.sql	postgres_fdw: Add functions to discard cached connections.	4 years ago
postgres_fdw--1.0.sql	Add postgres_fdw contrib module.	13 years ago
postgres_fdw.c	Fix filtering of "cloned" outer-join quals some more.	2 years ago
postgres_fdw.control	postgres_fdw: Add function to list cached connections to foreign servers.	5 years ago
postgres_fdw.h	Check relkind before using TABLESAMPLE in postgres_fdw	3 years ago
shippable.c	Pre-beta mechanical code beautification.	2 years ago