postgres

History

Tom Lane b55b4dad99 Teach libpq to handle arbitrary-length lines in .pgpass files. Historically there's been a hard-wired assumption here that no line of a .pgpass file could be as long as NAMEDATALEN*5 bytes. That's a bit shaky to start off with, because (a) there's no reason to suppose that host names fit in NAMEDATALEN, and (b) this figure fails to allow for backslash escape characters. However, it fails completely if someone wants to use a very long password, and we're now hearing reports of people wanting to use "security tokens" that can run up to several hundred bytes. Another angle is that the file is specified to allow comment lines, but there's no reason to assume that long comment lines aren't possible. Rather than guessing at what might be a more suitable limit, let's replace the fixed-size buffer with an expansible PQExpBuffer. That adds one malloc/free cycle to the typical use-case, but that's surely pretty cheap relative to the I/O this code has to do. Also, add TAP test cases to exercise this code, because there was no test coverage before. This reverts most of commit `2eb3bc588`, as there's no longer a need for a warning message about overlength .pgpass lines. (I kept the explicit check for comment lines, though.) In HEAD and v13, this also fixes an oversight in 74a308cf5: there's not much point in explicit_bzero'ing the line buffer if we only do so in two of the three exit paths. Back-patch to all supported branches, except that the test case only goes back to v10 where src/test/authentication/ was added. Discussion: https://postgr.es/m/4187382.1598909041@sss.pgh.pa.us		5 years ago
..
po	Translation updates	6 years ago
test	Use perl warnings pragma consistently	6 years ago
.gitignore	Move wchar.c and encnames.c to src/common/.	6 years ago
Makefile	Allow ecpg to be built stand-alone, allow parallel libpq make	6 years ago
README	…
exports.txt	Fix bugs in OpenSSL hook renaming.	6 years ago
fe-auth-scram.c	Initial pgindent and pgperltidy run for v13.	6 years ago
fe-auth.c	Fix capitalization of messages, per style guide	6 years ago
fe-auth.h	Update copyrights for 2020	6 years ago
fe-connect.c	Teach libpq to handle arbitrary-length lines in .pgpass files.	5 years ago
fe-exec.c	Update copyrights for 2020	6 years ago
fe-gssapi-common.c	Update copyrights for 2020	6 years ago
fe-gssapi-common.h	Update copyrights for 2020	6 years ago
fe-lobj.c	Update copyrights for 2020	6 years ago
fe-misc.c	Mop up some no-longer-necessary hacks around printf %.*s format.	6 years ago
fe-print.c	Update copyrights for 2020	6 years ago
fe-protocol2.c	Clean up newlines following left parentheses	6 years ago
fe-protocol3.c	Clean up newlines following left parentheses	6 years ago
fe-secure-common.c	Update copyrights for 2020	6 years ago
fe-secure-common.h	Update copyrights for 2020	6 years ago
fe-secure-gssapi.c	Fix severe memory leaks in GSSAPI encryption support.	6 years ago
fe-secure-openssl.c	Fix list of SSL error codes for older OpenSSL versions.	6 years ago
fe-secure.c	Rename PQsetSSLKeyPassHook and friends	6 years ago
legacy-pqsignal.c	Update copyrights for 2020	6 years ago
libpq-events.c	Update copyrights for 2020	6 years ago
libpq-events.h	Update copyrights for 2020	6 years ago
libpq-fe.h	Fix bugs in OpenSSL hook renaming.	6 years ago
libpq-int.h	Rename connection parameters to control min/max SSL protocol version in libpq	6 years ago
nls.mk	Translation updates	6 years ago
pg_service.conf.sample	…
pqexpbuffer.c	Update copyrights for 2020	6 years ago
pqexpbuffer.h	Update copyrights for 2020	6 years ago
pthread-win32.c	Update copyrights for 2020	6 years ago
win32.c	Clean up newlines following left parentheses	6 years ago
win32.h	…

README

src/interfaces/libpq/README

This directory contains the C version of Libpq, the POSTGRES frontend library.