You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane ff0b18cc49 Fix PARAM_EXEC assignment mechanism to be safe in the presence of WITH. ... The planner previously assumed that parameter Vars having the same absolute query level, varno, and varattno could safely be assigned the same runtime PARAM_EXEC slot, even though they might be different Vars appearing in different subqueries. This was (probably) safe before the introduction of CTEs, but the lazy-evalution mechanism used for CTEs means that a CTE can be executed during execution of some other subquery, causing the lifespan of Params at the same syntactic nesting level as the CTE to overlap with use of the same slots inside the CTE. In 9.1 we created additional hazards by using the same parameter-assignment technology for nestloop inner scan parameters, but it was broken before that, as illustrated by the added regression test. To fix, restructure the planner's management of PlannerParamItems so that items having different semantic lifespans are kept rigorously separated. This will probably result in complex queries using more runtime PARAM_EXEC slots than before, but the slots are cheap enough that this hardly matters. Also, stop generating PlannerParamItems containing Params for subquery outputs: all we really need to do is reserve the PARAM_EXEC slot number, and that now only takes incrementing a counter. The planning code is simpler and probably faster than before, as well as being more correct. Per report from Vik Reykja. Back-patch of commit 46c508fbcf into all branches that support WITH.		14 years ago
..
bitmapset.h	Stamp copyrights for year 2011.	15 years ago
execnodes.h	Fix whole-row Var evaluation to cope with resjunk columns (again).	14 years ago
makefuncs.h	Ensure that whole-row junk Vars are always of composite type.	14 years ago
memnodes.h	Pull up isReset flag from AllocSetContext to MemoryContext struct. This	15 years ago
nodeFuncs.h	Revise collation derivation method and expression-tree representation.	15 years ago
nodes.h	Fix whole-row Var evaluation to cope with resjunk columns (again).	14 years ago
params.h	pgindent run before PG 9.1 beta 1.	15 years ago
parsenodes.h	Rework parsing of ConstraintAttributeSpec to improve NOT VALID handling.	15 years ago
pg_list.h	pgindent run before PG 9.1 beta 1.	15 years ago
plannodes.h	Fix handling of PlaceHolderVars in nestloop parameter management.	14 years ago
primnodes.h	pgindent run before PG 9.1 beta 1.	15 years ago
print.h	Stamp copyrights for year 2011.	15 years ago
readfuncs.h	Stamp copyrights for year 2011.	15 years ago
relation.h	Fix PARAM_EXEC assignment mechanism to be safe in the presence of WITH.	14 years ago
replnodes.h	Clean up ill-advised attempt to invent a private set of Node tags.	15 years ago
tidbitmap.h	Stamp copyrights for year 2011.	15 years ago
value.h	Stamp copyrights for year 2011.	15 years ago