You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Etsuro Fujita ffbb7e65a8 Fix handling of pending inserts in nodeModifyTable.c. ... Commit b663a4136, which allowed FDWs to INSERT rows in bulk, added to nodeModifyTable.c code to flush pending inserts to the foreign-table result relation(s) before completing processing of the ModifyTable node, but the code failed to take into account the case where the INSERT query has modifying CTEs, leading to incorrect results. Also, that commit failed to flush pending inserts before firing BEFORE ROW triggers so that rows are visible to such triggers. In that commit we scanned through EState's es_tuple_routing_result_relations or es_opened_result_relations list to find the foreign-table result relations to which pending inserts are flushed, but that would be inefficient in some cases. So to fix, 1) add a List member to EState to record the insert-pending result relations, and 2) modify nodeModifyTable.c so that it adds the foreign-table result relation to the list in ExecInsert() if appropriate, and flushes pending inserts properly using the list where needed. While here, fix a copy-and-pasteo in a comment in ExecBatchInsert(), which was added by that commit. Back-patch to v14 where that commit appeared. Discussion: https://postgr.es/m/CAPmGK16qutyCmyJJzgQOhfBq%3DNoGDqTB6O0QBZTihrbqre%2BoxA%40mail.gmail.com		3 years ago
..
expected	Fix handling of pending inserts in nodeModifyTable.c.	3 years ago
sql	Fix handling of pending inserts in nodeModifyTable.c.	3 years ago
.gitignore	…
Makefile	postgres_fdw: Add function to list cached connections to foreign servers.	5 years ago
connection.c	Rename SetSingleFuncCall() to InitMaterializedSRF()	3 years ago
deparse.c	Fix final warnings produced by -Wshadow=compatible-local	3 years ago
meson.build	meson: Add windows resource files	3 years ago
option.c	Adjust assorted hint messages that list all valid options.	3 years ago
postgres_fdw--1.0--1.1.sql	postgres_fdw: Add functions to discard cached connections.	5 years ago
postgres_fdw--1.0.sql	…
postgres_fdw.c	Fix confusion about havingQual vs hasHavingQual in planner.	3 years ago
postgres_fdw.control	postgres_fdw: Add function to list cached connections to foreign servers.	5 years ago
postgres_fdw.h	Harmonize parameter names in contrib code.	3 years ago
shippable.c	Update copyright for 2022	4 years ago