Actually use the picture_claim as configured in OIDC config. (#14751)

Previously it was only using the default value ("picture") when fetching the picture from the user info.
2 years ago · 044fa1a1de
parent eb9ae47799
commit 044fa1a1de
2 changed files with 2 additions and 1 deletions
--- a/changelog.d/14751.bugfix
+++ b/changelog.d/14751.bugfix
@ -0,0 +1 @@
+Fix a bug introduced in Synapse 1.73.0 where the `picture_claim` configured under `oidc_providers` was unused (the default value of `"picture"` was used instead).
--- a/synapse/handlers/oidc.py
+++ b/synapse/handlers/oidc.py
@ -1615,7 +1615,7 @@ class JinjaOidcMappingProvider(OidcMappingProvider[JinjaOidcMappingConfig]):
        if email:
            emails.append(email)

-        picture = userinfo.get("picture")
+        picture = userinfo.get(self._config.picture_claim)

        return UserAttributeDict(
            localpart=localpart,
				`@ -0,0 +1 @@`
				Fix a bug introduced in Synapse 1.73.0 where the `picture_claim` configured under `oidc_providers` was unused (the default value of `"picture"` was used instead).