From 2c7f5e74e5ae5eb7e5d0b99001610a829b0b35da Mon Sep 17 00:00:00 2001 From: reivilibre Date: Wed, 29 Dec 2021 15:12:30 +0000 Subject: [PATCH] Fix a type annotation in `test_account_data.py` and remove it from the Mypy exclusion list. (#11657) Co-authored-by: Patrick Cloke --- changelog.d/11657.misc | 1 + mypy.ini | 1 - tests/storage/test_account_data.py | 4 ++-- 3 files changed, 3 insertions(+), 3 deletions(-) create mode 100644 changelog.d/11657.misc diff --git a/changelog.d/11657.misc b/changelog.d/11657.misc new file mode 100644 index 000000000..8e405b922 --- /dev/null +++ b/changelog.d/11657.misc @@ -0,0 +1 @@ +Add missing type hints to storage classes. \ No newline at end of file diff --git a/mypy.ini b/mypy.ini index 724c7e2ae..e0204a3c0 100644 --- a/mypy.ini +++ b/mypy.ini @@ -100,7 +100,6 @@ exclude = (?x) |tests/server.py |tests/server_notices/test_resource_limits_server_notices.py |tests/state/test_v2.py - |tests/storage/test_account_data.py |tests/storage/test_background_update.py |tests/storage/test_base.py |tests/storage/test_client_ips.py diff --git a/tests/storage/test_account_data.py b/tests/storage/test_account_data.py index 01af49a16..d697d2bc1 100644 --- a/tests/storage/test_account_data.py +++ b/tests/storage/test_account_data.py @@ -12,7 +12,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -from typing import Iterable, Set +from typing import Iterable, Optional, Set from synapse.api.constants import AccountDataTypes @@ -25,7 +25,7 @@ class IgnoredUsersTestCase(unittest.HomeserverTestCase): self.user = "@user:test" def _update_ignore_list( - self, *ignored_user_ids: Iterable[str], ignorer_user_id: str = None + self, *ignored_user_ids: Iterable[str], ignorer_user_id: Optional[str] = None ) -> None: """Update the account data to block the given users.""" if ignorer_user_id is None: