Fix `get_pdu` asking every remote destination even after it finds an event (#13346)

2 years ago · 4f3082d6bf
parent bf3115584c
commit 4f3082d6bf
2 changed files with 4 additions and 3 deletions
--- a/changelog.d/13346.misc
+++ b/changelog.d/13346.misc
@ -0,0 +1 @@
+Fix long-standing bugged logic which was never hit in `get_pdu` asking every remote destination even after it finds an event.
--- a/synapse/federation/federation_client.py
+++ b/synapse/federation/federation_client.py
@ -403,9 +403,9 @@ class FederationClient(FederationBase):
                        # Prime the cache
                        self._get_pdu_cache[event.event_id] = event

-                        # FIXME: We should add a `break` here to avoid calling every
-                        # destination after we already found a PDU (will follow-up
-                        # in a separate PR)
+                        # Now that we have an event, we can break out of this
+                        # loop and stop asking other destinations.
+                        break

                except SynapseError as e:
                    logger.info(
				`@ -0,0 +1 @@`
				Fix long-standing bugged logic which was never hit in `get_pdu` asking every remote destination even after it finds an event.