Remember to yield: not much point testing is a deferred is not None

9 years ago · a0dea6eaed
parent 883aabe423
commit a0dea6eaed
1 changed files with 2 additions and 1 deletions
--- a/synapse/rest/client/v2_alpha/register.py
+++ b/synapse/rest/client/v2_alpha/register.py
@ -224,9 +224,10 @@ class RegisterRestServlet(RestServlet):
            if k not in body:
                absent.append(k)

-        existingUid = self.hs.get_datastore().get_user_id_by_threepid(
+        existingUid = yield self.hs.get_datastore().get_user_id_by_threepid(
            'email', body['email']
        )
+
        if existingUid is not None:
            raise SynapseError(400, "Email is already in use", Codes.THREEPID_IN_USE)