Add `Server` to Access-Control-Expose-Headers header (#15908)

2 years ago · b516d91999
parent 2328e90fbb
commit b516d91999
3 changed files with 3 additions and 2 deletions
--- a/changelog.d/15908.misc
+++ b/changelog.d/15908.misc
@ -0,0 +1 @@
+Add `Server` to Access-Control-Expose-Headers header.
--- a/synapse/http/server.py
+++ b/synapse/http/server.py
@ -910,7 +910,7 @@ def set_cors_headers(request: SynapseRequest) -> None:
        )
        request.setHeader(
            b"Access-Control-Expose-Headers",
-            b"Synapse-Trace-Id",
+            b"Synapse-Trace-Id, Server",
        )


--- a/tests/test_server.py
+++ b/tests/test_server.py
@ -268,7 +268,7 @@ class OptionsResourceTests(unittest.TestCase):
        )
        self.assertEqual(
            channel.headers.getRawHeaders(b"Access-Control-Expose-Headers"),
-            [b"Synapse-Trace-Id"],
+            [b"Synapse-Trace-Id, Server"],
        )

    def _check_cors_msc3886_headers(self, channel: FakeChannel) -> None:
				`@ -0,0 +1 @@`
				Add `Server` to Access-Control-Expose-Headers header.