Fix fixme in preserve_fn

`preserve_fn` is no longer used as a decorator anywhere, so we can safely fix a
fixme therein.
pull/4/merge
Richard van der Hoff 8 years ago
parent 773e1c6d68
commit e2eebf1696
  1. 6
      synapse/util/logcontext.py

@ -334,12 +334,8 @@ def preserve_fn(f):
LoggingContext.set_current_context(LoggingContext.sentinel)
return result
# XXX: why is this here rather than inside g? surely we want to preserve
# the context from the time the function was called, not when it was
# wrapped?
current = LoggingContext.current_context()
def g(*args, **kwargs):
current = LoggingContext.current_context()
res = f(*args, **kwargs)
if isinstance(res, defer.Deferred) and not res.called:
# The function will have reset the context before returning, so

Loading…
Cancel
Save