watcha-synapse

Commit Graph

Author	SHA1	Message	Date
Quentin Gliech	4af33015af	Fix joining remote rooms when a `on_new_event` callback is registered (#16973 ) Since Synapse 1.76.0, any module which registers a `on_new_event` callback would brick the ability to join remote rooms. This is because this callback tried to get the full state of the room, which would end up in a deadlock. Related: https://github.com/matrix-org/synapse-auto-accept-invite/issues/18 The following module would brick the ability to join remote rooms: ```python from typing import Any, Dict, Literal, Union import logging from synapse.module_api import ModuleApi, EventBase logger = logging.getLogger(__name__) class MyModule: def __init__(self, config: None, api: ModuleApi): self._api = api self._config = config self._api.register_third_party_rules_callbacks( on_new_event=self.on_new_event, ) async def on_new_event(self, event: EventBase, _state_map: Any) -> None: logger.info(f"Received new event: {event}") @staticmethod def parse_config(_config: Dict[str, Any]) -> None: return None ``` This is technically a breaking change, as we are now passing partial state on the `on_new_event` callback. However, this callback was broken for federated rooms since 1.76.0, and local rooms have full state anyway, so it's unlikely that it would change anything.	2 years ago
Erik Johnston	930dc9e2d3	Fix typo	2 years ago
Erik Johnston	0455c40085	Update book location	2 years ago
Erik Johnston	8613f7693e	More renaming	2 years ago
Andrew Yasinishyn	63d96bfc61	ModuleAPI SSO auth callbacks (#15207 ) Signed-off-by: Andrii Yasynyshyn yasinishyn.a.n@gmail.com	2 years ago
Erik Johnston	c02406ac71	Add new module API for adding custom fields to events `unsigned` section (#16549 )	2 years ago
Patrick Cloke	d2eab22de7	Clarify presence router docs. (#16529 )	2 years ago
Erik Johnston	25c55a9d22	Add login spam checker API (#15838 )	3 years ago
Patrick Cloke	7c9b91790c	Consolidate logic to check for deactivated users. (#15634 ) This moves the deactivated user check to the method which all login types call. Additionally updates the application service tests to be more realistic by removing invalid tests and fixing server names.	3 years ago
Mathieu Velten	dabbb94faf	Delete pushers after calling on_logged_out module hook on device delete (#15410 )	3 years ago
Patrick Cloke	69553052cc	Update spam checker documentation for moved media modules. (#15175 )	3 years ago
Brendan Abolivier	521026897c	Add documentation for caching in a module (#14026 ) * Add documentation for caching in a module * Changelog * Formatting * Wrap lines at a length that mdbook is happier with * Typo fix Co-authored-by: Erik Johnston <erik@matrix.org> * Link to recent version of the API In the longer term I'd like to see us generate markdown with Sphinx. * Refer to public `cached` decorator * Mark caching as being added in 1.74 Some of the underlying infrastructure was added in 1.69, but the public-facing `cached` decorator was only added in 1.74. It is the latter that I think we should be advertising. * Update docs/modules/writing_a_module.md Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> --------- Co-authored-by: David Robertson <davidr@element.io> Co-authored-by: Erik Johnston <erik@matrix.org> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	3 years ago
Andrew Morgan	b40657314e	Add module API callbacks for adding and deleting local 3PID associations (#15044	3 years ago
Andrew Morgan	91f8de7b56	Clarify the workers that the ThirdPartyRules' `on_new_event` callback will run on (#15071 )	3 years ago
reivilibre	4eb2f4e02b	Fix broken links in the Synapse documentation. (#14744 ) * Fix stale external links * Fix some internal links * Fix URLs without trailing / where needed * Fix more links * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> * Reapply docs/openid.md fix after conflict Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>	3 years ago
Dirk Klimpel	afbdbe0634	Fix return value in example on `password_auth_provider_callbacks.md` (#13450 ) Fixes: #12534 Signed-off-by: Dirk Klimpel <dirk@klimpel.org>	3 years ago
Brendan Abolivier	bdb6628dcf	Fix version number in spam checker callbacks doc (#13047 )	4 years ago
David Teller	a164a46038	Uniformize spam-checker API, part 4: port other spam-checker callbacks to return `Union[Allow, Codes]`. (#12857 ) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	4 years ago
Brendan Abolivier	8fd87739bf	Fix import in module_api module and docs on the new check_event_for_spam signature (#12918 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	4 years ago
David Teller	28199e9357	Uniformize spam-checker API, part 2: check_event_for_spam (#12808 ) Signed-off-by: David Teller <davidt@element.io>	4 years ago
Jess Porter	a608ac847b	add SpamChecker callback for silently dropping inbound federated events (#12744 ) Signed-off-by: jesopo <github@lolnerd.net>	4 years ago
Brendan Abolivier	e4409301ba	Add a module callback to react to account data changes (#12327 ) Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	4 years ago
Brendan Abolivier	5e88143dff	Add a callback to react to 3PID associations (#12302 )	4 years ago
David Robertson	872dbb0181	Correct `check_username_for_spam` annotations and docs (#12246 ) * Formally type the UserProfile in user searches * export UserProfile in synapse.module_api * Update docs Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	4 years ago
Will Hunt	15382b1afa	Add third_party module callbacks to check if a user can delete a room and deactivate a user (#12028 ) * Add check_can_deactivate_user * Add check_can_shutdown_rooms * Documentation * callbacks, not functions * Various suggested tweaks * Add tests for test_check_can_shutdown_room and test_check_can_deactivate_user * Update check_can_deactivate_user to not take a Requester * Fix check_can_shutdown_room docs * Renegade and use `by_admin` instead of `admin_user_id` * fix lint * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	4 years ago
Brendan Abolivier	300ed0b8a6	Add module callbacks called for reacting to deactivation status change and profile update (#12062 )	4 years ago
Brendan Abolivier	707049c6ff	Allow modules to set a display name on registration (#12009 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	4 years ago
David Robertson	73fc488783	Explain the meaning of spam checker callbacks' return values (#12003 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	4 years ago
Brendan Abolivier	0640f8ebaa	Add a callback to allow modules to deny 3PID (#11854 ) Part of the Tchap Synapse mainlining. This allows modules to implement extra logic to figure out whether a given 3PID can be added to the local homeserver. In the Tchap use case, this will allow a Synapse module to interface with the custom endpoint /internal_info.	4 years ago
Jonathan de Jong	02632b3504	Stabilise MSC3231 (Token Based Registration) (#11867 )	4 years ago
Brendan Abolivier	2d3bd9aa67	Add a module callback to set username at registration (#11790 ) This is in the context of mainlining the Tchap fork of Synapse. Currently in Tchap usernames are derived from the user's email address (extracted from the UIA results, more specifically the m.login.email.identity step). This change also exports the check_username method from the registration handler as part of the module API, so that a module can check if the username it's trying to generate is correct and doesn't conflict with an existing one, and fallback gracefully if not. Co-authored-by: David Robertson <davidr@element.io>	4 years ago
Olivier Wilkinson (reivilibre)	4dd9ea8f4f	Revert "Revert accidental fast-forward merge from v1.49.0rc1" This reverts commit `158d73ebdd`.	4 years ago
Sean Quah	158d73ebdd	Revert accidental fast-forward merge from v1.49.0rc1 Revert "Sort internal changes in changelog" Revert "Update CHANGES.md" Revert "1.49.0rc1" Revert "Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505) (#11527)" Revert "Refactors in `_generate_sync_entry_for_rooms` (#11515)" Revert "Correctly register shutdown handler for presence workers (#11518)" Revert "Fix `ModuleApi.looping_background_call` for non-async functions (#11524)" Revert "Fix 'delete room' admin api to work on incomplete rooms (#11523)" Revert "Correctly ignore invites from ignored users (#11511)" Revert "Fix the test breakage introduced by #11435 as a result of concurrent PRs (#11522)" Revert "Stabilise support for MSC2918 refresh tokens as they have now been merged into the Matrix specification. (#11435)" Revert "Save the OIDC session ID (sid) with the device on login (#11482)" Revert "Add admin API to get some information about federation status (#11407)" Revert "Include bundled aggregations in /sync and related fixes (#11478)" Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505)" Revert "Update backward extremity docs to make it clear that it does not indicate whether we have fetched an events' `prev_events` (#11469)" Revert "Support configuring the lifetime of non-refreshable access tokens separately to refreshable access tokens. (#11445)" Revert "Add type hints to `synapse/tests/rest/admin` (#11501)" Revert "Revert accidental commits to develop." Revert "Newsfile" Revert "Give `tests.server.setup_test_homeserver` (nominally!) the same behaviour" Revert "Move `tests.utils.setup_test_homeserver` to `tests.server`" Revert "Convert one of the `setup_test_homeserver`s to `make_test_homeserver_synchronous`" Revert "Disambiguate queries on `state_key` (#11497)" Revert "Comments on the /sync tentacles (#11494)" Revert "Clean up tests.storage.test_appservice (#11492)" Revert "Clean up `tests.storage.test_main` to remove use of legacy code. (#11493)" Revert "Clean up `tests.test_visibility` to remove legacy code. (#11495)" Revert "Minor cleanup on recently ported doc pages (#11466)" Revert "Add most of the missing type hints to `synapse.federation`. (#11483)" Revert "Avoid waiting for zombie processes in `synctl stop` (#11490)" Revert "Fix media repository failing when media store path contains symlinks (#11446)" Revert "Add type annotations to `tests.storage.test_appservice`. (#11488)" Revert "`scripts-dev/sign_json`: support for signing events (#11486)" Revert "Add MSC3030 experimental client and federation API endpoints to get the closest event to a given timestamp (#9445)" Revert "Port wiki pages to documentation website (#11402)" Revert "Add a license header and comment. (#11479)" Revert "Clean-up get_version_string (#11468)" Revert "Link background update controller docs to summary (#11475)" Revert "Additional type hints for config module. (#11465)" Revert "Register the login redirect endpoint for v3. (#11451)" Revert "Update openid.md" Revert "Remove mention of OIDC certification from Dex (#11470)" Revert "Add a note about huge pages to our Postgres doc (#11467)" Revert "Don't start Synapse master process if `worker_app` is set (#11416)" Revert "Expose worker & homeserver as entrypoints in `setup.py` (#11449)" Revert "Bundle relations of relations into the `/relations` result. (#11284)" Revert "Fix `LruCache` corruption bug with a `size_callback` that can return 0 (#11454)" Revert "Eliminate a few `Any`s in `LruCache` type hints (#11453)" Revert "Remove unnecessary `json.dumps` from `tests.rest.admin` (#11461)" Revert "Merge branch 'master' into develop" This reverts commit `26b5d2320f`. This reverts commit `bce4220f38`. This reverts commit `966b5d0fa0`. This reverts commit `088d748f2c`. This reverts commit `14d593f72d`. This reverts commit `2a3ec6facf`. This reverts commit `eccc49d755`. This reverts commit `b1ecd19c5d`. This reverts commit `9c55dedc8c`. This reverts commit `2d42e586a8`. This reverts commit `2f053f3f82`. This reverts commit `a15a893df8`. This reverts commit `8b4b153c9e`. This reverts commit `494ebd7347`. This reverts commit `a77c369897`. This reverts commit `4eb77965cd`. This reverts commit `637df95de6`. This reverts commit `e5f426cd54`. This reverts commit `8cd68b8102`. This reverts commit `6cae125e20`. This reverts commit `7be88fbf48`. This reverts commit `b3fd99b74a`. This reverts commit `f7ec6e7d9e`. This reverts commit `5640992d17`. This reverts commit `d26808dd85`. This reverts commit `f91624a595`. This reverts commit `16d39a5490`. This reverts commit `8a4c296987`. This reverts commit `49e1356ee3`. This reverts commit `d2279f471b`. This reverts commit `b50e39df57`. This reverts commit `858d80bf0f`. This reverts commit `435f044807`. This reverts commit `f61462e1be`. This reverts commit `a6f1a3abec`. This reverts commit `84dc50e160`. This reverts commit `ed635d3285`. This reverts commit `7b62791e00`. This reverts commit `153194c771`. This reverts commit `f44d729d4c`. This reverts commit `a265fbd397`. This reverts commit `b9fef1a7cd`. This reverts commit `b0eb64ff7b`. This reverts commit `f1795463bf`. This reverts commit `70cbb1a5e3`. This reverts commit `42bf020463`. This reverts commit `379f2650cf`. This reverts commit `7ff22d6da4`. This reverts commit `5a0b652d36`. This reverts commit `432a174bc1`. This reverts commit `b14f8a1baf`, reversing changes made to `e713855dca`.	4 years ago
Erik Johnston	d08ef6f155	Make background updates controllable via a plugin (#11306 ) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	4 years ago
reivilibre	499c44d696	Make minor correction to type of auth_checkers callbacks (#11253 )	4 years ago
reivilibre	69ab3dddbc	Make `check_event_allowed` module API callback not fail open (accept events) when an exception is raised (#11033 )	4 years ago
Sumner Evans	ece84f2c45	Improve code formatting and fix a few typos in docs (#11221 ) * Labeled a lot more code blocks with the appropriate type * Fixed a couple of minor typos (missing/extraneous commas) Signed-off-by: Sumner Evans <me@sumnerevans.com>	4 years ago
Brendan Abolivier	e320f5dba3	Deprecate user_may_create_room_with_invites (#11206 )	4 years ago
Brendan Abolivier	c7a5e49664	Implement an `on_new_event` callback (#11126 ) Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	4 years ago
Brendan Abolivier	78d5896d19	Document the version of Synapse each module callback was introduced in (#11132 ) * Mention callbacks introduced in v1.37.0 According to the documentation introduced in https://github.com/matrix-org/synapse/pull/10062 * Mention callbacks introduced in v1.39.0 According to https://github.com/matrix-org/synapse/pull/10386 and https://github.com/matrix-org/synapse/pull/9884 * Mention callbacks introduced in v1.42.0 According to https://github.com/matrix-org/synapse/pull/10524 * Mention callbacks introduced in v1.44.0 and v1.45.0 As per https://github.com/matrix-org/synapse/pull/10898, https://github.com/matrix-org/synapse/pull/10910 and https://github.com/matrix-org/synapse/pull/10894 * Mention callbacks introduced in v1.46.0 According to https://github.com/matrix-org/synapse/pull/10548	4 years ago
Brendan Abolivier	73743b8ad1	Document Synapse's behaviour when dealing with multiple modules (#11096 ) Document Synapse's behaviour when multiple modules register the same callback/web resource/etc. Co-authored-by: reivilibre <oliverw@matrix.org>	4 years ago
Azrenbeth	cdd308845b	Port the Password Auth Providers module interface to the new generic interface (#10548 ) Co-authored-by: Azrenbeth <7782548+Azrenbeth@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	4 years ago
Brendan Abolivier	4e51621064	Add a spamchecker method to allow or deny 3pid invites (#10894 ) This is in the context of creating new module callbacks that modules in https://github.com/matrix-org/synapse-dinsic can use, in an effort to reconcile the spam checker API in synapse-dinsic with the one in mainline. Note that a module callback already exists for 3pid invites (https://matrix-org.github.io/synapse/develop/modules/third_party_rules_callbacks.html#check_threepid_can_be_invited) but it doesn't check whether the sender of the invite is allowed to send it.	4 years ago
Brendan Abolivier	829f2a82b0	Add a spamchecker callback to allow or deny room joins (#10910 ) Co-authored-by: Erik Johnston <erik@matrix.org>	4 years ago
Brendan Abolivier	b10257e879	Add a spamchecker callback to allow or deny room creation based on invites (#10898 ) This is in the context of creating new module callbacks that modules in https://github.com/matrix-org/synapse-dinsic can use, in an effort to reconcile the spam checker API in synapse-dinsic with the one in mainline. This adds a callback that's fairly similar to user_may_create_room except it also allows processing based on the invites sent at room creation.	4 years ago
Charles Wright	6b6bb81b23	Fix #10837 by adding JSON encoding/decoding to the Module API example… (#10845 )	4 years ago
Brendan Abolivier	03caba6577	Improve the modules doc (#10758 ) * Split up the documentation in several files rather than one huge one * Add examples for each callback category * Other niceties like fixing https://github.com/matrix-org/synapse/issues/10632 * Add titles to callbacks so they're easier to find in the navigation panels and link to	4 years ago

45 Commits (watcha-develop)