238 Commits (watcha-develop)

Author	SHA1	Message	Date
Patrick Cloke	cc4fe68adf	Support reactor timing metric on more reactors. (#16532) ... Previously only Twisted's EPollReactor was compatible with the reactor timing metric, notably not working when asyncio was used. After this change, the following configurations support the reactor timing metric: * poll, epoll, or select reactors * asyncio reactor with a poll, epoll, select, /dev/poll, or kqueue event loop.	1 year ago
Patrick Cloke	ab9c1e8f39	Add type hints to synmark. (#16421)	1 year ago
Patrick Cloke	ba48c563c9	Bump mypy from 1.4.1 to 1.5.1. (#16300)	1 year ago
Patrick Cloke	ed6de4b2d4	service-identity, incremental, and setuptools-rust now have type hints. (#16186)	1 year ago
David Robertson	47c629bb27	Attempt to fix twisted trunk (#16115)	1 year ago
Patrick Cloke	6f18812bb0	Add stubs package for lxml. (#15697) ... The stubs have some issues so this has some generous cast and ignores in it, but it is better than not having stubs. Note that confusing that Element is a function which creates _Element instances (and similarly for Comment).	2 years ago
Patrick Cloke	c01343de43	Add stricter mypy options (#15694) ... Enable warn_unused_configs, strict_concatenate, disallow_subclassing_any, and disallow_incomplete_defs.	2 years ago
Patrick Cloke	ca5c4be921	Add type hints to test_descriptors. (#15659) ... Require type hints in test_descriptors and add missing ones.	2 years ago
Eric Eastwood	7148c2a0d6	Run mypy type checking with the minimum supported Python version (#15602) ... We use the oldest Python version because later Python versions can include some overloads which don't work in the older versions which we still support. We're using Python 3.8 instead of 3.7 which is our actual minimum support version because it's EOL is in a matter of weeks so can avoid the extra effort. And in any case, minimum Python 3.8 support is better than winging it on Python 3.11.	2 years ago
Patrick Cloke	6efa674004	Add type hints to schema deltas (#15497) ... Cleans-up the schema delta files: * Removes no-op functions. * Adds missing type hints to function parameters. * Fixes any issues with type hints. This also renames one (very old) schema delta to avoid a conflict that mypy complains about.	2 years ago
Patrick Cloke	a346b43837	Check databases/__init__ and main/cache with mypy. (#15496)	2 years ago
Patrick Cloke	ea5c3ede4f	Finish type hints for federation client HTTP code. (#15465)	2 years ago
Patrick Cloke	3d060eae6c	Add missing type hints to `synapse.storage.database`. (#15230)	2 years ago
Patrick Cloke	e7c3832ba6	Pull in netaddr type hints. (#15231) ... And fix any issues from having those type hints.	2 years ago
Patrick Cloke	c369d82df0	Add missing type hints to InsecureInterceptableContextFactory. (#15164)	2 years ago
Patrick Cloke	c9b9143655	Fix-up type hints in tests/server.py. (#15084) ... This file was being ignored by mypy, we remove that and add the missing type hints & deal with any fallout.	2 years ago
Patrick Cloke	42aea0d8af	Add final type hint to tests.unittest. (#15072) ... Adds a return type to HomeServerTestCase.make_homeserver and deal with any variables which are no longer Any.	2 years ago
Patrick Cloke	733531ee3e	Add final type hint to synapse.server. (#15035)	2 years ago
David Robertson	7081bb56e2	Proper types for `tests.module_api` (#15031) ... * -> None for test methods * A first batch of type fixes * Introduce common parent test case * Fixup that big test method * tests.module_api passes mypy * Changelog	2 years ago
Patrick Cloke	30509a1010	Add more missing type hints to tests. (#15028)	2 years ago
Patrick Cloke	4eed7b2ede	Add missing type hints to tests. (#15027)	2 years ago
Patrick Cloke	975f7ba904	Explicit disabling of disallowed_untyped_defs. (#15026) ... To make it easier to see which files still need to be fixed.	2 years ago
David Robertson	2dff93099b	Typecheck tests.rest.media.v1.test_media_storage (#15008) ... * Fix MediaStorage type hint * Typecheck tests.rest.media.v1.test_media_storage * Changelog * Remove assert and make the comment succinct * Fix syntax for olddeps	2 years ago
David Robertson	4dd2b6165c	Proper types for tests.test_terms_auth (#15007) ... * Proper types for tests.test_terms_auth * Changelog	2 years ago
David Robertson	d0fed7a37b	Properly typecheck types.http (#14988) ... * Tweak http types in Synapse AFACIS these are correct, and they make mypy happier on tests.http. * Type hints for test_proxyagent * type hints for test_srv_resolver * test_matrix_federation_agent * tests.http.server._base * tests.http.__init__ * tests.http.test_additional_resource * tests.http.test_client * tests.http.test_endpoint * tests.http.test_matrixfederationclient * tests.http.test_servlet * tests.http.test_simple_client * tests.http.test_site * One fixup in tests.server * Untyped defs * Changelog * Fixup syntax for Python 3.7 * Fix olddeps syntax * Use a twisted IPv4 addr for dummy_address * Fix typo, thanks Sean Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com> * Remove redundant `Optional` --------- Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2 years ago
Patrick Cloke	d0fa217cd9	Add missing types to test_state. (#14985)	2 years ago
David Robertson	0f34abed7c	Type hints for tests.federation (#14991) ... * Make tests.federation pass mypy * Untyped defs in tests.federation.transport * test methods return None * Remaining type hints in tests.federation * Changelog * Avoid an uncessary type-ignore	2 years ago
Patrick Cloke	156cd88eef	Add missing type hints to tests.replication. (#14987)	2 years ago
David Robertson	b275763c65	Expect type stubs from canonicaljson (#14992) ... * canonicaljson has stubs now since https://github.com/matrix-org/python-canonicaljson/pull/52 which is included in the lockfile version we use for type checking. * Changelog	2 years ago
David Robertson	e8269ed391	Type hints for tests.appservice (#14990) ... * Accept a Sequence of events in synapse.appservice This avoids some casts/ignores in the tests I'm about to fixup. It seems that `List[Mock]` is not a subtype of `List[EventBase]`, but `Sequence[Mock]` is a subtype of `Sequence[EventBase]`. So presumably `Mock` is considered a subtype of anything, much like `Any`. * make tests.appservice.test_scheduler pass mypy * Extra hints in tests.appservice.test_scheduler * Extra hints in tests.appservice.test_api * Extra hints in tests.appservice.test_appservice * Disallow untyped defs * Changelog	2 years ago
David Robertson	6e6edea6c1	Properly typecheck tests.api (#14983)	2 years ago
David Robertson	e301ee6189	Properly typecheck tests.app (#14984	2 years ago
Patrick Cloke	fc35e0673f	Add missing type hints in tests (#14879) ... * FIx-up type hints in tests.logging. * Add missing type hints to test_transactions.	2 years ago
Andrew Morgan	871ff05add	Fix type hints in typing edu unit tests (#14886)	2 years ago
Patrick Cloke	3c3ba31507	Add missing type hints for tests.events. (#14904)	2 years ago
Andrew Morgan	836c592f15	Fix type hints in knocking tests. (#14887)	2 years ago
Andrew Morgan	f075f6ae2b	Fix type hints for Monthly Active Users tests (#14889)	2 years ago
Andrew Morgan	8d90e5f200	Add type hints to `TestRatelimiter` (#14885)	2 years ago
Patrick Cloke	7f2cabf271	Fix-up type hints for tests.push module. (#14816)	2 years ago
Patrick Cloke	a4ca770655	Add missing type hints to tests. (#14687) ... Adds type hints to tests.metrics and tests.crypto.	2 years ago
Patrick Cloke	3aeca2588b	Add missing type hints to tests.config. (#14681)	2 years ago
Patrick Cloke	652d1669c5	Add missing type hints to tests.handlers. (#14680) ... And do not allow untyped defs in tests.handlers.	2 years ago
David Robertson	e2a1adbf5d	Allow selecting "prejoin" events by state keys (#14642) ... * Declare new config * Parse new config * Read new config * Don't use trial/our TestCase where it's not needed Before: ``` $ time trial tests/events/test_utils.py > /dev/null real 0m2.277s user 0m2.186s sys 0m0.083s ``` After: ``` $ time trial tests/events/test_utils.py > /dev/null real 0m0.566s user 0m0.508s sys 0m0.056s ``` * Helper to upsert to event fields without exceeding size limits. * Use helper when adding invite/knock state Now that we allow admins to include events in prejoin room state with arbitrary state keys, be a good Matrix citizen and ensure they don't accidentally create an oversized event. * Changelog * Move StateFilter tests should have done this in #14668 * Add extra methods to StateFilter * Use StateFilter * Ensure test file enforces typed defs; alphabetise * Workaround surprising get_current_state_ids * Whoops, fix mypy	2 years ago
David Robertson	3d87847ecc	Enable `--warn-redundant-casts` option in mypy (#14671) ... * Enable `--warn-redundant-casts` option in mypy Doesn't do much but helps me sleep better at night. * Changelog * Fix name of the ignore * Fix one more missed cast Not sure why I didn't see this one locally, maybe I needed a poetry update * Remove old comment Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2 years ago
Patrick Cloke	3ac412b4e2	Require types in tests.storage. (#14646) ... Adds missing type hints to `tests.storage` package and does not allow untyped definitions.	2 years ago
Patrick Cloke	acea4d7a2f	Add missing types to tests.util. (#14597) ... Removes files under tests.util from the ignored by list, then fully types all tests/util/*.py files.	2 years ago
Ashish Kumar	09de2aecb0	Add support for handling avatar with SSO login (#13917) ... This commit adds support for handling a provided avatar picture URL when logging in via SSO. Signed-off-by: Ashish Kumar <ashfame@users.noreply.github.com> Fixes #9357.	2 years ago
Patrick Cloke	4ae967cf63	Add missing type hints to test.util.caches (#14529)	2 years ago
Andrew Morgan	ae22e6e94f	Enable 'strict_equality' checking for mypy (#14452)	2 years ago
David Robertson	115f0eb233	Reintroduce #14376, with bugfix for monoliths (#14468) ... * Add tests for StreamIdGenerator * Drive-by: annotate all defs * Revert "Revert "Remove slaved id tracker (#14376)" (#14463)" This reverts commit d63814fd73, which in turn reverted 36097e88c4. This restores the latter. * Fix StreamIdGenerator not handling unpersisted IDs Spotted by @erikjohnston. Closes #14456. * Changelog Co-authored-by: Nick Mills-Barrett <nick@fizzadar.com> Co-authored-by: Erik Johnston <erik@matrix.org>	2 years ago