13 Commits (watcha-develop)

Author	SHA1	Message	Date
Patrick Cloke	da77720752	Check the stream position before checking if the cache is empty. (#14639) ... An empty cache does not mean the entity has no changed, if it is earlier than the earliest known stream position return that the entity *has* changed since the cache cannot accurately answer that query.	3 years ago
Erik Johnston	cee9445884	Better return type for `get_all_entities_changed` (#14604) ... Help callers from using the return value incorrectly by ensuring that callers explicitly check if there was a cache hit or not.	3 years ago
Patrick Cloke	6a8310f3df	Compare to the earliest known stream pos in the stream change cache. (#14435) ... The internal methods of the StreamChangeCache were inconsistently treating the earliest known stream position as valid. It is now treated as invalid, meaning the cache cannot determine if an entity at the earliest known stream position has changed or not.	3 years ago
Patrick Cloke	acea4d7a2f	Add missing types to tests.util. (#14597) ... Removes files under tests.util from the ignored by list, then fully types all tests/util/*.py files.	3 years ago
Eric Eastwood	0a00b7ff14	Update black, and run auto formatting over the codebase (#9381) ... - Update black version to the latest - Run black auto formatting over the codebase - Run autoformatting according to [`docs/code_style.md `](80d6dc9783/docs/code_style.md) - Update `code_style.md` docs around installing black to use the correct version	5 years ago
Amber Brown	7cb8b4bc67	Allow configuration of Synapse's cache without using synctl or environment variables (#6391)	6 years ago
Richard van der Hoff	13683a3a22	Extend StreamChangeCache to support multiple entities per stream ID (#7303) ... First some background: StreamChangeCache is used to keep track of what "entities" have changed since a given stream ID. So for example, we might use it to keep track of when the last to-device message for a given user was received [1], and hence whether we need to pull any to-device messages from the database on a sync [2]. Now, it turns out that StreamChangeCache didn't support more than one thing being changed at a given stream_id (this was part of the problem with #7206). However, it's entirely valid to send to-device messages to more than one user at a time. As it turns out, this did in fact work, because *some* methods of StreamChangeCache coped ok with having multiple things changing on the same stream ID, and it seems we never actually use the methods which don't work on the stream change caches where we allow multiple changes at the same stream ID. But that feels horribly fragile, hence: let's update StreamChangeCache to properly support this, and add some typing and some more tests while we're at it. [1]: https://github.com/matrix-org/synapse/blob/release-v1.12.3/synapse/storage/data_stores/main/deviceinbox.py#L301 [2]: https://github.com/matrix-org/synapse/blob/release-v1.12.3/synapse/storage/data_stores/main/deviceinbox.py#L47-L51	6 years ago
Patrick Cloke	509e381afa	Clarify list/set/dict/tuple comprehensions and enforce via flake8 (#6957) ... Ensure good comprehension hygiene using flake8-comprehensions.	6 years ago
black	8b3d9b6b19	Run black.	8 years ago
Erik Johnston	850238b4ef	Add unit test	8 years ago
Erik Johnston	bc832f822f	Fixup unit test	8 years ago
Amber Brown	49af402019	run isort	8 years ago
Amber Brown	f7869f8f8b	Port to sortedcontainers (with tests!) (#3332)	8 years ago