115 Commits (07a3b5dabad98678bae52275b327c302adbf67af)

Author	SHA1	Message	Date
Sean Quah	ecfcd9bbbe	Add type hints to `synapse/storage/databases/main/e2e_room_keys.py` (#11549)	3 years ago
David Robertson	4c96ce396e	Misc typing fixes for `tests`, part 1 of N (#11323) ... * Annotate HomeserverTestCase.servlets * Correct annotation of federation_auth_origin * Use AnyStr custom_headers instead of a Union This allows (str, str) and (bytes, bytes). This disallows (str, bytes) and (bytes, str) * DomainSpecificString.SIGIL is a ClassVar	3 years ago
Patrick Cloke	5cace20bf1	Add missing type hints to `synapse.app`. (#11287)	3 years ago
Andrew Morgan	aa2c027792	Remove unnecessary parentheses around tuples returned from methods (#10889)	3 years ago
Sean Quah	9391de3f37	Fix /initialSync error due to unhashable `RoomStreamToken` (#10827) ... The deprecated /initialSync endpoint maintains a cache of responses, using parameter values as part of the cache key. When a `from` or `to` parameter is specified, it gets converted into a `StreamToken`, which contains a `RoomStreamToken` and forms part of the cache key. `RoomStreamToken`s need to be made hashable for this to work.	3 years ago
David Robertson	319b8b6bef	Name the type of token in "Invalid token" messages (#10815) ... I had one of these error messages yesterday and assumed it was an invalid auth token (because that was an HTTP query parameter in the test) I was working on. In fact, it was an invalid next batch token for syncing.	3 years ago
reivilibre	524b8ead77	Add types to synapse.util. (#10601)	3 years ago
Jason Robinson	c2000ab35b	Add `get_userinfo_by_id` method to `ModuleApi` (#9581) ... Makes it easier to fetch user details in for example spam checker modules, without needing to use api._store or figure out database interactions. Signed-off-by: Jason Robinson <jasonr@matrix.org>	3 years ago
Jonathan de Jong	95e47b2e78	[pyupgrade] `synapse/` (#10348) ... This PR is tantamount to running ``` pyupgrade --py36-plus --keep-percent-format `find synapse/ -type f -name "*.py"` ``` Part of #9744	3 years ago
Jonathan de Jong	bf72d10dbf	Use inline type hints in various other places (in `synapse/`) (#10380)	3 years ago
Patrick Cloke	30b56f6925	Add type hints to get_domain_from_id and get_localpart_from_id. (#10385)	3 years ago
Richard van der Hoff	fcf3c7032b	Ensure that we do not cache empty sync responses after a timeout (#10158) ... Fixes #8518 by telling the ResponseCache not to cache the /sync response if the next_batch param is the same as the since token.	3 years ago
Marcus	8070b893db	update black to 21.6b0 (#10197) ... Reformat all files with the new version. Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu>	3 years ago
Erik Johnston	a15c003e5b	Make DomainSpecificString an attrs class (#9875)	4 years ago
Richard van der Hoff	294c675033	Remove `synapse.types.Collection` (#9856) ... This is no longer required, since we have dropped support for Python 3.5.	4 years ago
Jonathan de Jong	4b965c862d	Remove redundant "coding: utf-8" lines (#9786) ... Part of #9744 Removes all redundant `# -*- coding: utf-8 -*-` lines from files, as python 3 automatically reads source code as utf-8 now. `Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>`	4 years ago
Richard van der Hoff	a7a3790066	Convert Requester to attrs (#9586) ... ... because namedtuples suck Fix up a couple of other annotations to keep mypy happy.	4 years ago
Patrick Cloke	58114f8a17	Create a SynapseReactor type which incorporates the necessary reactor interfaces. (#9528) ... This helps fix some type hints when running with Twisted 21.2.0.	4 years ago
Eric Eastwood	0a00b7ff14	Update black, and run auto formatting over the codebase (#9381) ... - Update black version to the latest - Run black auto formatting over the codebase - Run autoformatting according to [`docs/code_style.md `](80d6dc9783/docs/code_style.md) - Update `code_style.md` docs around installing black to use the correct version	4 years ago
Patrick Cloke	7950aa8a27	Fix some typos.	4 years ago
Richard van der Hoff	0cd2938bc8	Support icons for Identity Providers (#9154)	4 years ago
Patrick Cloke	98a64b7f7f	Add basic domain validation for `DomainSpecificString.is_valid`. (#9071) ... This checks that the domain given to `DomainSpecificString.is_valid` (e.g. `UserID`, `RoomAlias`, etc.) is of a valid form. Previously some validation was done on the localpart (e.g. the sigil), but not the domain portion.	4 years ago
Richard van der Hoff	28877fade9	Implement a username picker for synapse (#8942) ... The final part (for now) of my work to implement a username picker in synapse itself. The idea is that we allow `UsernameMappingProvider`s to return `localpart=None`, in which case, rather than redirecting the browser back to the client, we redirect to a username-picker resource, which allows the user to enter a username. We *then* complete the SSO flow (including doing the client permission checks). The static resources for the username picker itself (in https://github.com/matrix-org/synapse/tree/rav/username_picker/synapse/res/username_picker) are essentially lifted wholesale from https://github.com/matrix-org/matrix-synapse-saml-mozilla/tree/master/matrix_synapse_saml_mozilla/res. As the comment says, we might want to think about making them customisable, but that can be a follow-up. Fixes #8876.	4 years ago
Patrick Cloke	79bfe966e0	Improve error checking for OIDC/SAML mapping providers (#8774) ... Checks that the localpart returned by mapping providers for SAML and OIDC are valid before registering new users. Extends the OIDC tests for existing users and invalid data.	4 years ago
Erik Johnston	f21e24ffc2	Add ability for access tokens to belong to one user but grant access to another user. (#8616) ... We do it this way round so that only the "owner" can delete the access token (i.e. `/logout/all` by the "owner" also deletes that token, but `/logout/all` by the "target user" doesn't). A future PR will add an API for creating such a token. When the target user and authenticated entity are different the `Processed request` log line will be logged with a: `{@admin:server as @bob:server} ...`. I'm not convinced by that format (especially since it adds spaces in there, making it harder to use `cut -d ' '` to chop off the start of log lines). Suggestions welcome.	4 years ago
Erik Johnston	52a50e8686	Use vector clocks for room stream tokens. (#8439) ... Currently when using multiple event persisters we (in the worst case) don't tell clients about events until all event persisters have persisted new events after the original event. This is a suboptimal, especially if one of the event persisters goes down. To handle this, we encode the position of each event persister in the room tokens so that we can send events to clients immediately. To reduce the size of the token we do two things: 1. We create a unique immutable persistent mapping between instance names and a generated small integer ID, which we can encode in the tokens instead of the instance name; and 2. We encode the "persisted upto position" of the room token and then only explicitly include instances that have positions strictly greater than that. The new tokens look something like: `m3478~1.3488~2.3489`, where the first number is the min position, and the subsequent `-` separated pairs are the instance ID to positions map. (We use `.` and `~` as separators as they're URL safe and not already used by `StreamToken`).	4 years ago
Erik Johnston	7941372ec8	Make token serializing/deserializing async (#8427) ... The idea is that in future tokens will encode a mapping of instance to position. However, we don't want to include the full instance name in the string representation, so instead we'll have a mapping between instance name and an immutable integer ID in the DB that we can use instead. We'll then do the lookup when we serialize/deserialize the token (we could alternatively pass around an `Instance` type that includes both the name and ID, but that turns out to be a lot more invasive).	4 years ago
Erik Johnston	ea70f1c362	Various clean ups to room stream tokens. (#8423)	4 years ago
Erik Johnston	ac11fcbbb8	Add EventStreamPosition type (#8388) ... The idea is to remove some of the places we pass around `int`, where it can represent one of two things: 1. the position of an event in the stream; or 2. a token that partitions the stream, used as part of the stream tokens. The valid operations are then: 1. did a position happen before or after a token; 2. get all events that happened before or after a token; and 3. get all events between two tokens. (Note that we don't want to allow other operations as we want to change the tokens to be vector clocks rather than simple ints)	4 years ago
Jonathan de Jong	a3f124b821	Switch metaclass initialization to python 3-compatible syntax (#8326)	4 years ago
Erik Johnston	fe8ed1b46f	Make `StreamToken.room_key` be a `RoomStreamToken` instance. (#8281)	4 years ago
Erik Johnston	63c0e9e195	Add types to StreamToken and RoomStreamToken (#8279) ... The intention here is to change `StreamToken.room_key` to be a `RoomStreamToken` in a future PR, but that is a big enough change without this refactoring too.	4 years ago
Patrick Cloke	c619253db8	Stop sub-classing object (#8249)	4 years ago
Patrick Cloke	d5e73cb6aa	Define StateMap as immutable and add a MutableStateMap type. (#8183)	4 years ago
Patrick Cloke	ac77cdb64e	Add a shadow-banned flag to users. (#8092)	4 years ago
Erik Johnston	9d1e4942ab	Fix typing for notifier (#8064)	4 years ago
Will Hunt	62b1ce8539	isort 5 compatibility (#7786) ... The CI appears to use the latest version of isort, which is a problem when isort gets a major version bump. Rather than try to pin the version, I've done the necessary to make isort5 happy with synapse.	4 years ago
Patrick Cloke	7dcbc33a1b	Validate the alt_aliases property of canonical alias events (#6971)	5 years ago
Richard van der Hoff	5a246611e3	Type defintions for use in refactoring for redaction changes (#6803) ... * Bump signedjson to 1.1 ... so that we can use the type definitions * Fix breakage caused by upgrade to signedjson 1.1 Thanks, @illicitonion...	5 years ago
Erik Johnston	d386f2f339	Add StateMap type alias (#6715)	5 years ago
Richard van der Hoff	66ca914dc0	Remove unused hashes and depths from create_new_client_event params	5 years ago
Amber Brown	864f144543	Fix up some typechecking (#6150) ... * type checking fixes * changelog	5 years ago
Hubert Chathi	fac1cdc562	make changes from PR review	5 years ago
Hubert Chathi	c659b9f94f	allow uploading keys for cross-signing	5 years ago
Amber Brown	32e7c9e7f2	Run Black. (#5482)	6 years ago
Richard van der Hoff	eed7271b3b	declare a ReadReceipt class ... I'm going to use this in queues and things, so it'll be useful to give it more of a structure.	6 years ago
Richard van der Hoff	c588b9b9e4	Factor SSO success handling out of CAS login (#4264) ... This is mostly factoring out the post-CAS-login code to somewhere we can reuse it for other SSO flows, but it also fixes the userid mapping while we're at it.	6 years ago
Amber Brown	da7785147d	Python 3: Convert some unicode/bytes uses (#3569)	6 years ago
Amber Brown	49af402019	run isort	6 years ago
Vincent Breitmoser	f4284d943a	In DomainSpecificString, override __repr__ in addition to __str__ ... For some reason, string interpolation on a DomainSpecificString object like "%r" % (domainSpecificStringObj) fails under PyPy, because the default __repr__ implementation wants to iterate over the object. I'm not sure why that happens, but overriding __repr__ instead of __str__ fixes this problem, and is arguably the more appropriate thing to do anyways.	7 years ago