watcha-synapse

Commit Graph

Author	SHA1	Message	Date
Amber Brown	4806651744	Replace returnValue with return (#5736 )	5 years ago
Richard van der Hoff	c7095be913	Refactor Keyring._start_key_lookups There's an awful lot of deferreds and dictionaries flying around here. The whole thing can be made much simpler and achieve the same effect.	5 years ago
Amber Brown	463b072b12	Move logging utilities out of the side drawer of util/ and into logging/ (#5606 )	5 years ago
Erik Johnston	43badd2cd4	Fix key verification when key stored with null valid_until_ms Some keys are stored in the synapse database with a null valid_until_ms which caused an exception to be thrown when using that key. We fix this by treating nulls as zeroes, i.e. they keys will match verification requests with a minimum_valid_until_ms of zero (i.e. don't validate ts) but will not match requests with a non-zero minimum_valid_until_ms. Fixes #5391.	6 years ago
Richard van der Hoff	9fbb20a531	Stop hardcoding trust of old matrix.org key (#5374 ) There are a few changes going on here: * We make checking the signature on a key server response optional: if no verify_keys are specified, we trust to TLS to validate the connection. * We change the default config so that it does not require responses to be signed by the old key. * We replace the old 'perspectives' config with 'trusted_key_servers', which is also formatted slightly differently. * We emit a warning to the logs every time we trust a key server response signed by the old key.	6 years ago
Richard van der Hoff	cea9750d11	Associate a request_name with each verify request, for logging Also: * rename VerifyKeyRequest->VerifyJsonRequest * calculate key_ids on VerifyJsonRequest construction * refactor things to pass around VerifyJsonRequests instead of 4-tuples	6 years ago
Richard van der Hoff	def5ea4062	Don't bomb out on direct key fetches as soon as one fails	6 years ago
Richard van der Hoff	fec2dcb1a5	Enforce validity period on server_keys for fed requests. (#5321 ) When handling incoming federation requests, make sure that we have an up-to-date copy of the signing key. We do not yet enforce the validity period for event signatures.	6 years ago
Richard van der Hoff	fa1b293da2	Simplification to Keyring.wait_for_previous_lookups. (#5250 ) The list of server names was redundant, since it was equivalent to the keys on the server_to_deferred map. This reduces the number of large lists being passed around, and has the benefit of deduplicating the entries in `wait_on`.	6 years ago
Richard van der Hoff	753b1270da	Require sig from origin server on perspectives responses	6 years ago
Richard van der Hoff	895b79ac2e	Factor out KeyFetchers from KeyRing Rather than have three methods which have to have the same interface, factor out a separate interface which is provided by three implementations. I find it easier to grok the code this way.	6 years ago
Richard van der Hoff	b75537beaf	Store key validity time in the storage layer This is a first step to checking that the key is valid at the required moment. The idea here is that, rather than passing VerifyKey objects in and out of the storage layer, we instead pass FetchKeyResult objects, which simply wrap the VerifyKey and add a valid_until_ts field.	6 years ago
Richard van der Hoff	2e052110ee	Rewrite store_server_verify_key to store several keys at once (#5234 ) Storing server keys hammered the database a bit. This replaces the implementation which stored a single key, with one which can do many updates at once.	6 years ago
Amber Brown	b36c82576e	Run Black on the tests again (#5170 )	6 years ago
Andrew Morgan	caa76e6021	Remove periods from copyright headers (#5046 )	6 years ago
Richard van der Hoff	7d2a0c848e	Fix from_server buglet in get_keys_from_perspectives make sure we store the name of the server the keys came from, rather than the origin server, after doing a fetch-from-perspectives.	6 years ago
Richard van der Hoff	b2d574f126	test for get_keys_from_perspectives	6 years ago
Richard van der Hoff	30805237fa	add a test for get_keys_from_server	6 years ago
Richard van der Hoff	e4d473d855	Rewrite KeyringTestCase as a HomeServerTestCase (#4986 ) This is a bit fiddly due to the keyring doing weird things with logcontexts.	6 years ago
Richard van der Hoff	a44c0a096f	Check logcontexts before and after each test (#4190 ) * Add better diagnostics to flakey keyring test * fix interpolation fail * Check logcontexts before and after each test * update changelog * update changelog	6 years ago
Amber Brown	99dd975dae	Run tests under PostgreSQL (#3423 )	6 years ago
Amber Brown	807449d8f2	fix up a forced long line	6 years ago
black	8b3d9b6b19	Run black.	6 years ago
Amber Brown	49af402019	run isort	6 years ago
Amber Brown	77ac14b960	Pass around the reactor explicitly (#3385 )	7 years ago
Adrian Tschira	a1a3c9660f	Make tests py3 compatible This is a mixed commit that fixes various small issues * print parentheses * 01 is invalid syntax (it was octal in py2) * [x for i in 1, 2] is invalid syntax * six moves Signed-off-by: Adrian Tschira <nota@notafile.com>	7 years ago
Richard van der Hoff	d7eacc4f87	Create dbpool as normal in tests ... instead of creating our own special SQLiteMemoryDbPool, whose purpose was a bit of a mystery. For some reason this makes one of the tests run slightly slower, so bump the sleep(). Sorry.	7 years ago
Richard van der Hoff	44a498418c	Optimise LoggingContext creation and copying It turns out that the only thing we use the __dict__ of LoggingContext for is `request`, and given we create lots of LoggingContexts and then copy them every time we do a db transaction or log line, using the __dict__ seems a bit redundant. Let's try to optimise things by making the request attribute explicit.	7 years ago
Richard van der Hoff	72472456d8	Add some more tests for Keyring	7 years ago
Richard van der Hoff	9864efa532	Fix concurrent server_key requests (#2458 ) Fix a bug where we could end up firing off multiple requests for server_keys for the same server at the same time.	7 years ago
Richard van der Hoff	290777b3d9	Clean up and document handling of logcontexts in Keyring (#2452 ) I'm still unclear on what the intended behaviour for `verify_json_objects_for_server` is, but at least I now understand the behaviour of most of the things it calls...	7 years ago

32 Commits (08352d44f81a76ba53fc96753cc5038589defaa7)