8841 Commits (1ccafb0c5e3e6c9c64ce231163e7c73f05b910fa)

Author	SHA1	Message	Date
Neil Johnson	1ccafb0c5e	no need to join room if creator	6 years ago
Neil Johnson	a2bfb778c8	improve auto room join logic, comments and tests	6 years ago
Neil Johnson	2dadc092b8	move logic into register, fix room alias localpart bug, tests	6 years ago
Amber Brown	dd59dfc51f	full version	6 years ago
Richard van der Hoff	a59d899668	Pin to prometheus_client<0.4 to avoid renaming all of our metrics	6 years ago
Erik Johnston	52e6e815be	Sanitise error messages when user doesn't have permission to invite	6 years ago
Erik Johnston	69e857853f	Fix handling of rejected threepid invites	6 years ago
Erik Johnston	495a9d06bb	Fix exception handling in fetching remote profiles	6 years ago
Erik Johnston	7c570bff74	Fix exception in background metrics collection ... We attempted to iterate through a list on a separate thread without doing the necessary copying.	6 years ago
Richard van der Hoff	9693625e55	actually exclude outliers	6 years ago
Richard van der Hoff	3e39783d5d	remove debugging	6 years ago
Richard van der Hoff	ae61ade891	Fix bug in forward_extremity update logic ... An event does not stop being a forward_extremity just because an outlier or rejected event refers to it.	6 years ago
Amber Brown	da8f82008d	version	6 years ago
Erik Johnston	7258d081a5	Fix bug when invalidating destination retry timings	6 years ago
Amber Brown	7232917f12	Disable frozen dicts by default (#3987)	6 years ago
Erik Johnston	334e075dd8	Fix error when logging incomplete requests ... If a connection is lost before a request is read from Request, Twisted sets `method` (and `uri`) attributes to dummy values. These dummy values have incorrect types (i.e. they're not bytes), and so things like `__repr__` would raise an exception. To fix this we had a helper method to return the method with a consistent type.	6 years ago
Richard van der Hoff	8174c6725b	Avoid reraise, to improve stacktraces	6 years ago
Amber Brown	6e05fd032c	Fix userconsent on Python 3 (#3938)	6 years ago
Erik Johnston	82f922b4af	Fix lazy loaded sync with rejected state events ... In particular, we assume that the name and canonical alias events in the state have not been rejected. In practice this may not be the case (though we should probably think about fixing that) so lets ensure that we gracefully handle that case, rather than 404'ing the sync request like we do now.	6 years ago
Erik Johnston	4f3e3ac192	Correctly match 'dict.pop' api	6 years ago
Erik Johnston	8ea887856c	Don't update eviction metrics on explicit removal	6 years ago
Matthew Hodgson	23b6a0537f	emit room aliases event	6 years ago
Matthew Hodgson	5b68f29f48	fix thinkos	6 years ago
Matthew Hodgson	8f646f2d04	fix UTs	6 years ago
Richard van der Hoff	965154d60a	Fix complete fail to do the right thing	6 years ago
Richard van der Hoff	19475cf337	Remove redundant call to start_get_pdu_cache ... I think this got forgotten in #3932. We were getting away with it because it was the last call in this function.	6 years ago
Matthew Hodgson	07340cdaca	untested stab at autocreating autojoin rooms	6 years ago
Amber Brown	b3064532d0	Run our oldest supported configuration in CI (#3952)	6 years ago
Schnuffle	dc5db01ff2	Replaced all occurences of e.message with str(e) ... Signed-off-by: Schnuffle <schnuffle@github.com>	6 years ago
Richard van der Hoff	333bee27f5	Include event when resolving state for missing prevs ... If we have a forward extremity for a room as `E`, and you receive `A`, `B`, s.t. `A -> B -> E`, and `B` also points to an unknown event `X`, then we need to do state res between `X` and `E`. When that happens, we need to make sure we include `X` in the state that goes into the state res alg. Fixes #3934.	6 years ago
Richard van der Hoff	bd61c82bdf	Include state from remote servers in pdu handling ... If we've fetched state events from remote servers in order to resolve the state for a new event, we need to actually pass those events into resolve_events_with_factory (so that it can do the state res) and then persist the ones we need - otherwise other bits of the codebase get confused about why we have state groups pointing to non-existent events.	6 years ago
Richard van der Hoff	a215b698c4	Fix "unhashable type: 'list'" exception in federation handling ... get_state_groups returns a map from state_group_id to a list of FrozenEvents, so was very much the wrong thing to be putting as one of the entries in the list passed to resolve_events_with_factory (which expects maps from (event_type, state_key) to event id). We actually want get_state_groups_ids().values() rather than get_state_groups(). This fixes the main problem in #3923, but there are other problems with this bit of code which get discovered once you do so.	6 years ago
Richard van der Hoff	28223841e0	more comments	6 years ago
Richard van der Hoff	e3c159863d	Clarifications in FederationHandler ... * add some comments on things that look a bit bogus * rename this `state` variable to avoid confusion with the `state` used elsewhere in this function. (There was no actual conflict, but it was a confusing bit of spaghetti.)	6 years ago
Richard van der Hoff	4a15a3e4d5	Include eventid in log lines when processing incoming federation transactions (#3959) ... when processing incoming transactions, it can be hard to see what's going on, because we process a bunch of stuff in parallel, and because we may end up recursively working our way through a chain of three or four events. This commit creates a way to use logcontexts to add the relevant event ids to the log lines.	6 years ago
Richard van der Hoff	ae6ad4cf41	docstrings and unittests for storage.state (#3958) ... I spent ages trying to figure out how I was going mad...	6 years ago
Richard van der Hoff	e70b4ce069	Logging improvements ... Some logging tweaks to help with debugging incoming federation transactions	6 years ago
Richard van der Hoff	a87d419a85	Run notify_app_services as a bg process ... This ensures that its resource usage metrics get recorded somewhere rather than getting lost. (It also fixes an error when called from a nested logging context which completes before the bg process)	6 years ago
Richard van der Hoff	9453c65948	remove spurious federation checks on localhost ... There's really no point in checking for destinations called "localhost" because there is nothing stopping people creating other DNS entries which point to 127.0.0.1. The right fix for this is https://github.com/matrix-org/synapse/issues/3953. Blocking localhost, on the other hand, means that you get a surprise when trying to connect a test server on localhost to an existing server (with a 'normal' server_name).	6 years ago
Richard van der Hoff	607eec0456	fix docstring for FederationClient.get_state_for_room ... trivial fixes for docstring	6 years ago
Neil Johnson	28781b65e7	fix #3854	6 years ago
Richard van der Hoff	8afddf7afe	Fix error handling for missing auth_event ... When we were authorizing an event, if there was no `m.room.create` in its auth_events, we would raise a SynapseError with a cryptic message, which then meant that we would bail out of processing any incoming events, rather than storing a rejection for the faulty event and moving on. We should treat the absent event the same as any other auth failure, by raising an AuthError, so that the event is marked as rejected.	6 years ago
Erik Johnston	8834396b8a	Actuall set cache factors in workers	6 years ago
Richard van der Hoff	7ee94fc1ba	Log which cache is throwing exceptions	6 years ago
Erik Johnston	3baf6e1667	Fix ExpiringCache.__len__ to be accurate ... It used to try and produce an estimate, which was sometimes negative. This caused metrics to be sad, so lets always just calculate it from scratch. (This appears to have been a longstanding bug, but one which has been made more of a problem by #3932 and #3933). (This was originally done by Erik as part of #3933. I'm cherry-picking it because really it's a fix in its own right)	6 years ago
Jérémy Farnaud	6cf261930a	added "media-src: 'self'" to CSP for resources (#3578) ... Synapse doesn’t allow for media resources to be played directly from Chrome. It is a problem for users on other networks (e.g. IRC) communicating with Matrix users through a gateway. The gateway sends them the raw URL for the resource when a Matrix user uploads a video and the video cannot be played directly in Chrome using that URL. Chrome argues it is not authorized to play the video because of the Content Security Policy. Chrome checks for the "media-src" policy which is missing, and defauts to the "default-src" policy which is "none". As Synapse already sends "object-src: 'self'" I thought it wouldn’t be a problem to add "media-src: 'self'" to the CSP to fix this problem.	6 years ago
Richard van der Hoff	c53336986d	Move synctl into top dir to avoid a symlink ... symlinks apparently break setuptools on python3 and alpine (https://bugs.python.org/issue31940), so let's stop using a symlink and just use the file directly.	6 years ago
Richard van der Hoff	a9d84f4e44	We require attrs 16.0.0 ... Ref: https://github.com/matrix-org/synapse/issues/3945	6 years ago
Matthew Hodgson	787d22ed6c	Only lazy load self-members on initial sync ... Given we have disabled lazy loading for incr syncs in #3840, we can make self-LL more efficient by only doing it on initial sync. Also adds a bounds check for if/when we change our mind, so that we don't try to include LL members on sync responses with no timeline.	6 years ago
Amber Brown	6b6cb32297	bump version	6 years ago