watcha-synapse

Commit Graph

Author	SHA1	Message	Date
David Teller	a164a46038	Uniformize spam-checker API, part 4: port other spam-checker callbacks to return `Union[Allow, Codes]`. (#12857 ) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2 years ago
Erik Johnston	e3163e2e11	Reduce the amount of state we pull from the DB (#12811 )	3 years ago
Erik Johnston	888a29f412	Wait for lazy join to complete when getting current state (#12872 )	3 years ago
Patrick Cloke	a8db8c6eba	Remove user-visible groups/communities code (#12553 ) Makes it so that groups/communities no longer exist from a user-POV. E.g. we remove: * All API endpoints (including Client-Server, Server-Server, and admin). * Documented configuration options (and the experimental flag, which is now unused). * Special handling during room upgrades. * The `groups` section of the `/sync` response.	3 years ago
Shay	71e8afe34d	Update EventContext `get_current_event_ids` and `get_prev_event_ids` to accept state filters and update calls where possible (#12791 )	3 years ago
Sean Quah	800ba87cc8	Refactor and convert `Linearizer` to async (#12357 ) Refactor and convert `Linearizer` to async. This makes a `Linearizer` cancellation bug easier to fix. Also refactor to use an async context manager, which eliminates an unlikely footgun where code that doesn't immediately use the context manager could forget to release the lock. Signed-off-by: Sean Quah <seanq@element.io>	3 years ago
Eric Eastwood	6f2943714b	Remove unused `auth_event_ids` argument plumbing (#12304 ) Follow-up to https://github.com/matrix-org/synapse/pull/12083 Since we are now using the new `state_event_ids` parameter to do all of the heavy lifting. We can remove any spots where we plumbed `auth_event_ids` just for MSC2716 things in https://github.com/matrix-org/synapse/pull/9247/files. Removing `auth_event_ids` from following functions: - `create_and_send_nonmember_event` - `_local_membership_update` - `update_membership` - `update_membership_locked`	3 years ago
Eric Eastwood	14662d3c18	Refactor `create_new_client_event` to use a new parameter, `state_event_ids`, which accurately describes the usage with MSC2716 instead of abusing `auth_event_ids` (#12083 ) Spawned from https://github.com/matrix-org/synapse/pull/10975#discussion_r813183430 Part of [MSC2716](https://github.com/matrix-org/matrix-spec-proposals/pull/2716)	3 years ago
Richard van der Hoff	8533c8b03d	Avoid generating state groups for local out-of-band leaves (#12154 ) If we locally generate a rejection for an invite received over federation, it is stored as an outlier (because we probably don't have the state for the room). However, currently we still generate a state group for it (even though the state in that state group will be nonsense). By setting the `outlier` param on `create_event`, we avoid the nonsensical state.	3 years ago
Richard van der Hoff	e24ff8ebe3	Remove `HomeServer.get_datastore()` (#12031 ) The presence of this method was confusing, and mostly present for backwards compatibility. Let's get rid of it. Part of #11733	3 years ago
Brendan Abolivier	130fd45393	Limit concurrent AS joins (#11996 ) Initially introduced in matrix-org-hotfixes by e5537cf (and tweaked by later commits). Fixes #11995 See also #4826	3 years ago
Eric Eastwood	fef2e792be	Fix historical messages backfilling in random order on remote homeservers (MSC2716) (#11114 ) Fix https://github.com/matrix-org/synapse/issues/11091 Fix https://github.com/matrix-org/synapse/issues/10764 (side-stepping the issue because we no longer have to deal with `fake_prev_event_id`) 1. Made the `/backfill` response return messages in `(depth, stream_ordering)` order (previously only sorted by `depth`) - Technically, it shouldn't really matter how `/backfill` returns things but I'm just trying to make the `stream_ordering` a little more consistent from the origin to the remote homeservers in order to get the order of messages from `/messages` consistent ([sorted by `(topological_ordering, stream_ordering)`](https://github.com/matrix-org/synapse/blob/develop/docs/development/room-dag-concepts.md#depth-and-stream-ordering)). - Even now that we return backfilled messages in order, it still doesn't guarantee the same `stream_ordering` (and more importantly the [`/messages` order](https://github.com/matrix-org/synapse/blob/develop/docs/development/room-dag-concepts.md#depth-and-stream-ordering)) on the other server. For example, if a room has a bunch of history imported and someone visits a permalink to a historical message back in time, their homeserver will skip over the historical messages in between and insert the permalink as the next message in the `stream_order` and totally throw off the sort. - This will be even more the case when we add the [MSC3030 jump to date API endpoint](https://github.com/matrix-org/matrix-doc/pull/3030) so the static archives can navigate and jump to a certain date. - We're solving this in the future by switching to [online topological ordering](https://github.com/matrix-org/gomatrixserverlib/issues/187) and [chunking](https://github.com/matrix-org/synapse/issues/3785) which by its nature will apply retroactively to fix any inconsistencies introduced by people permalinking 2. As we're navigating `prev_events` to return in `/backfill`, we order by `depth` first (newest -> oldest) and now also tie-break based on the `stream_ordering` (newest -> oldest). This is technically important because MSC2716 inserts a bunch of historical messages at the same `depth` so it's best to be prescriptive about which ones we should process first. In reality, I think the code already looped over the historical messages as expected because the database is already in order. 3. Making the historical state chain and historical event chain float on their own by having no `prev_events` instead of a fake `prev_event` which caused backfill to get clogged with an unresolvable event. Fixes https://github.com/matrix-org/synapse/issues/11091 and https://github.com/matrix-org/synapse/issues/10764 4. We no longer find connected insertion events by finding a potential `prev_event` connection to the current event we're iterating over. We now solely rely on marker events which when processed, add the insertion event as an extremity and the federating homeserver can ask about it when time calls. - Related discussion, https://github.com/matrix-org/synapse/pull/11114#discussion_r741514793 Before \| After --- \| --- ![](https://user-images.githubusercontent.com/558581/139218681-b465c862-5c49-4702-a59e-466733b0cf45.png) \| ![](https://user-images.githubusercontent.com/558581/146453159-a1609e0a-8324-439d-ae44-e4bce43ac6d1.png) #### Why aren't we sorting topologically when receiving backfill events? > The main reason we're going to opt to not sort topologically when receiving backfill events is because it's probably best to do whatever is easiest to make it just work. People will probably have opinions once they look at [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) which could change whatever implementation anyway. > > As mentioned, ideally we would do this but code necessary to make the fake edges but it gets confusing and gives an impression of “just whyyyy” (feels icky). This problem also dissolves with online topological ordering. > > -- https://github.com/matrix-org/synapse/pull/11114#discussion_r741517138 See https://github.com/matrix-org/synapse/pull/11114#discussion_r739610091 for the technical difficulties	3 years ago
Brendan Abolivier	d80d39b035	Add a ratelimiter for 3pid invite (#11892 )	3 years ago
Brendan Abolivier	bf60da1a60	Configurable limits on avatars (#11846 ) Only allow files which file size and content types match configured limits to be set as avatar. Most of the inspiration from the non-test code comes from matrix-org/synapse-dinsic#19	3 years ago
Sean Quah	c7fe32edb4	Add type hints to `synapse/storage/databases/main/room.py` (#11575 )	3 years ago
Eric Eastwood	aa8708ebed	Allow events to be created with no `prev_events` (MSC2716) (#11243 ) The event still needs to have `auth_events` defined to be valid. Split out from https://github.com/matrix-org/synapse/pull/11114	3 years ago
Eric Eastwood	7ffddd819c	Prevent historical state from being pushed to an application service via `/transactions` (MSC2716) (#11265 ) Mark historical state from the MSC2716 `/batch_send` endpoint as `historical` which makes it `backfilled` and have a negative `stream_ordering` so it doesn't get queried by `/transactions`. Fix https://github.com/matrix-org/synapse/issues/11241 Complement tests: https://github.com/matrix-org/complement/pull/221	3 years ago
Patrick Cloke	c01bc5f43d	Add remaining type hints to `synapse.events`. (#11098 )	3 years ago
Patrick Cloke	eb9ddc8c2e	Remove the deprecated BaseHandler. (#11005 ) The shared ratelimit function was replaced with a dedicated RequestRatelimiter class (accessible from the HomeServer object). Other properties were copied to each sub-class that inherited from BaseHandler.	3 years ago
Brendan Abolivier	4e51621064	Add a spamchecker method to allow or deny 3pid invites (#10894 ) This is in the context of creating new module callbacks that modules in https://github.com/matrix-org/synapse-dinsic can use, in an effort to reconcile the spam checker API in synapse-dinsic with the one in mainline. Note that a module callback already exists for 3pid invites (https://matrix-org.github.io/synapse/develop/modules/third_party_rules_callbacks.html#check_threepid_can_be_invited) but it doesn't check whether the sender of the invite is allowed to send it.	3 years ago
Patrick Cloke	f4b1a9a527	Require direct references to configuration variables. (#10985 ) This removes the magic allowing accessing configurable variables directly from the config object. It is now required that a specific configuration class is used (e.g. `config.foo` must be replaced with `config.server.foo`).	3 years ago
Brendan Abolivier	829f2a82b0	Add a spamchecker callback to allow or deny room joins (#10910 ) Co-authored-by: Erik Johnston <erik@matrix.org>	3 years ago
Patrick Cloke	a0f48ee89d	Use direct references for configuration variables (part 7). (#10959 )	3 years ago
Patrick Cloke	32072dcdac	Strip "join_authorised_via_users_server" from join events which do not need it. (#10933 ) This fixes a "Event not signed by authorising server" error when transition room member from join -> join, e.g. when updating a display name or avatar URL for restricted rooms.	3 years ago
Patrick Cloke	d1bf5f7c9d	Strip "join_authorised_via_users_server" from join events which do not need it. (#10933 ) This fixes a "Event not signed by authorising server" error when transition room member from join -> join, e.g. when updating a display name or avatar URL for restricted rooms.	3 years ago
Patrick Cloke	94b620a5ed	Use direct references for configuration variables (part 6). (#10916 )	3 years ago
Patrick Cloke	bb7fdd821b	Use direct references for configuration variables (part 5). (#10897 )	3 years ago
Aaron Raimist	6a751ff5e0	Allow sending a membership event to unban a user (#10807 ) * Allow membership event to unban user Signed-off-by: Aaron Raimist <aaron@raim.ist>	3 years ago
Patrick Cloke	b3590614da	Require type hints in the handlers module. (#10831 ) Adds missing type hints to methods in the synapse.handlers module and requires all methods to have type hints there. This also removes the unused construct_auth_difference method from the FederationHandler.	3 years ago
Richard van der Hoff	56e2a30634	Move `maybe_kick_guest_users` out of `BaseHandler` (#10744 ) This is part of my ongoing war against BaseHandler. I've moved kick_guest_users into RoomMemberHandler (since it calls out to that handler anyway), and split maybe_kick_guest_users into the two places it is called.	3 years ago
Azrenbeth	0c1d6f65d7	Enforce the max length for per-room display names / avatar URLs. (#10654 ) To match the maximum lengths allowed for profile data.	3 years ago
Michael Telatynski	9db24cc50d	Send unstable-prefixed room_type in store-invite IS API requests (#10435 ) The room type is per MSC3288 to allow the identity-server to change invitation wording based on whether the invitation is to a room or a space. The prefixed key will be replaced once MSC3288 is accepted into the spec.	3 years ago
Patrick Cloke	228decfce1	Update the MSC3083 support to verify if joins are from an authorized server. (#10254 )	3 years ago
Eric Eastwood	96f6293de5	Add endpoints for backfilling history (MSC2716) (#9247 ) Work on https://github.com/matrix-org/matrix-doc/pull/2716	3 years ago
Patrick Cloke	9e5ab6dd58	Remove the experimental flag for knocking and use stable prefixes / endpoints. (#10167 ) * Room version 7 for knocking. * Stable prefixes and endpoints (both client and federation) for knocking. * Removes the experimental configuration flag.	3 years ago
Sorunome	d936371b69	Implement knock feature (#6739 ) This PR aims to implement the knock feature as proposed in https://github.com/matrix-org/matrix-doc/pull/2403 Signed-off-by: Sorunome mail@sorunome.de Signed-off-by: Andrew Morgan andrewm@element.io	4 years ago
Patrick Cloke	ac6bfcd52f	Refactor checking restricted join rules (#10007 ) To be more consistent with similar code. The check now automatically raises an AuthError instead of passing back a boolean. It also absorbs some shared logic between callers.	4 years ago
Brendan Abolivier	a683028d81	Correctly ratelimit invites when creating a room (#9968 ) * Correctly ratelimit invites when creating a room Also allow ratelimiting for more than one action at a time.	4 years ago
Patrick Cloke	bb4b11846f	Add missing type hints to handlers and fix a Spam Checker type hint. (#9896 ) The user_may_create_room_alias method on spam checkers declared the room_alias parameter as a str when in reality it is passed a RoomAlias object.	4 years ago
Patrick Cloke	d924827da1	Check for space membership during a remote join of a restricted room (#9814 ) When receiving a /send_join request for a room with join rules set to 'restricted', check if the user is a member of the spaces defined in the 'allow' key of the join rules. This only applies to an experimental room version, as defined in MSC3083.	4 years ago
Patrick Cloke	e8816c6ace	Revert "Check for space membership during a remote join of a restricted room. (#9763 )" This reverts commit `cc51aaaa7a`. The PR was prematurely merged and not yet approved.	4 years ago
Patrick Cloke	cc51aaaa7a	Check for space membership during a remote join of a restricted room. (#9763 ) When receiving a /send_join request for a room with join rules set to 'restricted', check if the user is a member of the spaces defined in the 'allow' key of the join rules. This only applies to an experimental room version, as defined in MSC3083.	4 years ago
Jonathan de Jong	4b965c862d	Remove redundant "coding: utf-8" lines (#9786 ) Part of #9744 Removes all redundant `# -- coding: utf-8 --` lines from files, as python 3 automatically reads source code as utf-8 now. `Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>`	4 years ago
Patrick Cloke	452991527a	MSC3083: Check for space membership during a local join of restricted rooms. (#9735 ) When joining a room with join rules set to 'restricted', check if the user is a member of the spaces defined in the 'allow' key of the join rules. This only applies to an experimental room version, as defined in MSC3083.	4 years ago
Erik Johnston	963f4309fe	Make RateLimiter class check for ratelimit overrides (#9711 ) This should fix a class of bug where we forget to check if e.g. the appservice shouldn't be ratelimited. We also check the `ratelimit_override` table to check if the user has ratelimiting disabled. That table is really only meant to override the event sender ratelimiting, so we don't use any values from it (as they might not make sense for different rate limits), but we do infer that if ratelimiting is disabled for the user we should disabled all ratelimits. Fixes #9663	4 years ago
Patrick Cloke	b449af0379	Add type hints to the room member handler. (#9631 )	4 years ago
Eric Eastwood	0a00b7ff14	Update black, and run auto formatting over the codebase (#9381 ) - Update black version to the latest - Run black auto formatting over the codebase - Run autoformatting according to [`docs/code_style.md `](`80d6dc9783/docs/code_style.md`) - Update `code_style.md` docs around installing black to use the correct version	4 years ago
Erik Johnston	ff55300b91	Honour ratelimit flag for application services for invite ratelimiting (#9302 )	4 years ago
Erik Johnston	f2c1560eca	Ratelimit invites by room and target user (#9258 )	4 years ago
Erik Johnston	6633a4015a	Allow moving account data and receipts streams off master (#9104 )	4 years ago

1 2 3 4 5

243 Commits (1e0044e8f9f20ee0e8be9ad40c48be3a67e0f54e)