211 Commits (1ec2961b3b214c7af4b541396adc94948b626c47)

Author	SHA1	Message	Date
Patrick Cloke	38e1fac886	Fix some spelling mistakes / typos. (#7811)	4 years ago
Erik Johnston	5cdca53aa0	Merge different Resource implementation classes (#7732)	4 years ago
Dagfinn Ilmari Mannsåker	a3f11567d9	Replace all remaining six usage with native Python 3 equivalents (#7704)	5 years ago
Andrew Morgan	2e8955f4a6	Further improvements to requesting the public rooms list on a homeserver which has it set to private (#7368)	5 years ago
Andrew Morgan	f89ad3b6df	Query missing cross-signing keys on local sig upload (#7289)	5 years ago
Richard van der Hoff	d41c8f6d4d	Revert "Query missing cross-signing keys on local sig upload" ... This was incorrectly merged to the release branch before it was ready. This reverts commit 72fe2affb6.	5 years ago
Andrew Morgan	72fe2affb6	Query missing cross-signing keys on local sig upload ... Add changelog Save retrieved keys to the db lint Fix and de-brittle remote result dict processing Use query_user_devices instead, assume only master, self_signing key types Make changelog more useful Remove very specific exception handling Wrap get_verify_key_from_cross_signing_key in a try/except Note that _get_e2e_cross_signing_verify_key can raise a SynapseError lint Add comment explaining why this is useful Only fetch master and self_signing key types Fix log statements, docstrings Remove extraneous items from remote query try/except lint Factor key retrieval out into a separate function Send device updates, modeled after SigningKeyEduUpdater._handle_signing_key_updates Update method docstring	5 years ago
Patrick Cloke	7581d30e9f	Remove unused federation endpoint (`query_auth`) (#7026)	5 years ago
Erik Johnston	ed630ea17c	Reduce amount of logging at INFO level. (#6862) ... A lot of the things we log at INFO are now a bit superfluous, so lets make them DEBUG logs to reduce the amount we log by default. Co-Authored-By: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Brendan Abolivier <github@brendanabolivier.com>	5 years ago
Richard van der Hoff	b0d112e78b	Fix `room_version` in `on_invite_request` flow (#6827) ... I messed this up a bit in #6805, but fortunately we weren't actually doing anything with the room_version so it didn't matter that it was a str not a RoomVersion.	5 years ago
Erik Johnston	c3d4ad8afd	Fix sending server up commands from workers (#6811) ... Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	5 years ago
Erik Johnston	a8a50f5b57	Wake up transaction queue when remote server comes back online (#6706) ... This will be used to retry outbound transactions to a remote server if we think it might have come back up.	5 years ago
Richard van der Hoff	e519489fc4	Remove fallback for missing /federation/v1/state_ids API (#6488) ... This API was added way back in 0.17.0; the code here is annoying to maintain and entirely redundant.	5 years ago
Amber Brown	0f87b912ab	Implementation of MSC2314 (#6176)	5 years ago
Andrew Morgan	bc29a19731	Replace instance variations of homeserver with correct case/spacing	5 years ago
Brendan Abolivier	5e18dc7955	Fix prefix for v2/send_leave	5 years ago
Brendan Abolivier	74897de01f	Add server-side support to the v2 API	5 years ago
Brendan Abolivier	1e202a90f1	Implement v2 API for send_leave	5 years ago
Brendan Abolivier	4c131b2c78	Implement v2 API for send_join	5 years ago
Andrew Morgan	54fef094b3	Remove usage of deprecated logger.warn method from codebase (#6271) ... Replace every instance of `logger.warn` with `logger.warning` as the former is deprecated.	5 years ago
Michael Kaye	9eebc1e73b	use %r to __repr__ objects ... This avoids calculating __repr__ unless we are going to log.	5 years ago
Richard van der Hoff	1ba359a11f	rip out some unreachable code ... The only possible rejection reason is AUTH_ERROR, so all of this is unreachable.	5 years ago
Erik Johnston	a5166e4d5f	Land improved room list based on room stats (#6019) ... Use room_stats and room_state for room directory search	5 years ago
Richard van der Hoff	9d94313209	Fix exception when resetting retry timings ... Fixes: > TypeError: set_destination_retry_timings() missing 1 required positional argument: 'retry_interval' Introduced in #6016.	5 years ago
Andrew Morgan	cd17a2085e	Remove origin parameter from add_display_name_to_third_party_invite and add params to docstring (#6010) ... Another small fixup noticed during work on a larger PR. The `origin` field of `add_display_name_to_third_party_invite` is not used and likely was just carried over from the `on_PUT` method of `FederationThirdPartyInviteExchangeServlet` which, like all other servlets, provides an `origin` argument. Since it's not used anywhere in the handler function though, we should remove it from the function arguments.	5 years ago
Jorik Schellekens	909827b422	Add opentracing to all client servlets (#5983)	5 years ago
Jorik Schellekens	812ed6b0d5	Opentracing across workers (#5771) ... Propagate opentracing contexts across workers Also includes some Convenience modifications to opentracing for servlets, notably: - Add boolean to skip the whitelisting check on inject extract methods. - useful when injecting into carriers locally. Otherwise we'd always have to include our own servername and whitelist our servername - start_active_span_from_request instead of header - Add boolean to decide whether to extract context from a request to a servlet	5 years ago
Olivier Wilkinson (reivilibre)	bb29bc2937	Use MSC2197 on stable prefix as it has almost finished FCP ... Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>	5 years ago
Jorik Schellekens	87fa26006b	Opentracing misc (#5856) ... Add authenticated_entity and servlet_names tags. Functionally: - Add a tag for authenticated_entity - Add a tag for servlet_names Stylistically: Moved to importing methods directly from opentracing.	5 years ago
Olivier Wilkinson (reivilibre)	2253b083d9	Add support for inbound MSC2197 requests on unstable Federation API ... Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>	5 years ago
Olivier Wilkinson (reivilibre)	6fadb560fc	Support MSC2197 outbound with unstable prefix ... Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>	5 years ago
Olivier Wilkinson (reivilibre)	1b63ccd848	Wrap `get_local_public_room_list` call in `maybeDeferred` because it ... is cached and so does not always return a `Deferred`. `await` does not silently pass-through non-Deferreds like `yield` used to. Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>	5 years ago
Amber Brown	865077f1d1	Room Complexity Client Implementation (#5783)	5 years ago
Jorik Schellekens	cf2972c818	Fix servlet metric names (#5734) ... * Fix servlet metric names Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Remove redundant check * Cover all return paths	5 years ago
Amber Brown	4806651744	Replace returnValue with return (#5736)	5 years ago
Richard van der Hoff	fa8271c5ac	Convert synapse.federation.transport.server to async (#5689) ... * Convert BaseFederationServlet._wrap to async Empirically, this fixes some lost stacktraces. It should be safe because the wrapped function is called from JsonResource._async_render, which is already async. * Convert the rest of synapse.federation.transport.server to async We may as well do the whole file while we're here. * changelog * flake8	5 years ago
Jorik Schellekens	38a6d3eea7	Add basic opentracing support (#5544) ... * Configure and initialise tracer Includes config options for the tracer and sets up JaegerClient. * Scope manager using LogContexts We piggy-back our tracer scopes by using log context. The current log context gives us the current scope. If new scope is created we create a stack of scopes in the context. * jaeger is a dependency now * Carrier inject and extraction for Twisted Headers * Trace federation requests on the way in and out. The span is created in _started_processing and closed in _finished_processing because we need a meaningful log context. * Create logcontext for new scope. Instead of having a stack of scopes in a logcontext we create a new context for a new scope if the current logcontext already has a scope. * Remove scope from logcontext if logcontext is top level * Disable tracer if not configured * typo * Remove dependence on jaeger internals * bools * Set service name * :Explicitely state that the tracer is disabled * Black is the new black * Newsfile * Code style * Use the new config setup. * Generate config. * Copyright * Rename config to opentracing * Remove user whitelisting * Empty whitelist by default * User ConfigError instead of RuntimeError * Use isinstance * Use tag constants for opentracing. * Remove debug comment and no need to explicitely record error * Two errors a "s(c)entry" * Docstrings! * Remove debugging brainslip * Homeserver Whitlisting * Better opentracing config comment * linting * Inclue worker name in service_name * Make opentracing an optional dependency * Neater config retreival * Clean up dummy tags * Instantiate tracing as object instead of global class * Inlcude opentracing as a homeserver member. * Thread opentracing to the request level * Reference opetnracing through hs * Instantiate dummy opentracin g for tests. * About to revert, just keeping the unfinished changes just in case * Revert back to global state, commit number: 9ce4a3d9067bf9889b86c360c05ac88618b85c4f * Use class level methods in tracerutils * Start and stop requests spans in a place where we have access to the authenticated entity * Seen it, isort it * Make sure to close the active span. * I'm getting black and blue from this. * Logger formatting Co-Authored-By: Erik Johnston <erik@matrix.org> * Outdated comment * Import opentracing at the top * Return a contextmanager * Start tracing client requests from the servlet * Return noop context manager if not tracing * Explicitely say that these are federation requests * Include servlet name in client requests * Use context manager * Move opentracing to logging/ * Seen it, isort it again! * Ignore twisted return exceptions on context exit * Escape the scope * Scopes should be entered to make them useful. * Nicer decorator names * Just one init, init? * Don't need to close something that isn't open * Docs make you smarter	5 years ago
Amber Brown	463b072b12	Move logging utilities out of the side drawer of util/ and into logging/ (#5606)	5 years ago
Brendan Abolivier	bfe84e051e	Split public rooms directory auth config in two	6 years ago
Amber Brown	32e7c9e7f2	Run Black. (#5482)	6 years ago
Richard van der Hoff	cea9750d11	Associate a request_name with each verify request, for logging ... Also: * rename VerifyKeyRequest->VerifyJsonRequest * calculate key_ids on VerifyJsonRequest construction * refactor things to pass around VerifyJsonRequests instead of 4-tuples	6 years ago
Richard van der Hoff	fec2dcb1a5	Enforce validity period on server_keys for fed requests. (#5321) ... When handling incoming federation requests, make sure that we have an up-to-date copy of the signing key. We do not yet enforce the validity period for event signatures.	6 years ago
Amber Brown	46c8f7a517	Implement the SHHS complexity API (#5216)	6 years ago
Amber Brown	f1e5b41388	Make all the rate limiting options more consistent (#5181)	6 years ago
Matthew Hodgson	c0e0740bef	add options to require an access_token to GET /profile and /publicRooms on CS API (#5083) ... This commit adds two config options: * `restrict_public_rooms_to_local_users` Requires auth to fetch the public rooms directory through the CS API and disables fetching it through the federation API. * `require_auth_for_profile_requests` When set to `true`, requires that requests to `/profile` over the CS API are authenticated, and only returns the user's profile if the requester shares a room with the profile's owner, as per MSC1301. MSC1301 also specifies a behaviour for federation (only returning the profile if the server asking for it shares a room with the profile's owner), but that's currently really non-trivial to do in a not too expensive way. Next step is writing down a MSC that allows a HS to specify which user sent the profile query. In this implementation, Synapse won't send a profile query over federation if it doesn't believe it already shares a room with the profile's owner, though. Groups have been intentionally omitted from this commit.	6 years ago
Richard van der Hoff	54a87a7b08	Collect room-version variations into one place (#4969) ... Collect all the things that make room-versions different to one another into one place, so that it's easier to define new room versions.	6 years ago
Andrew Morgan	4a125be138	Make federation endpoints more tolerant of trailing slashes v2 (#4935) ... Redo of https://github.com/matrix-org/synapse/pull/4840	6 years ago
Erik Johnston	271cb1998b	Revert "Make federation endpoints more tolerant of trailing slashes for some endpoints (#4793)" ... This reverts commit 290552fd83.	6 years ago
Andrew Morgan	09626bfd39	Switch to wrapper function around _send_request	6 years ago
Andrew Morgan	0ea8582f8b	Cleaner way of implementing trailing slashes	6 years ago