645 Commits (2df82ae451e03d76fae5381961dd6229d5796400)

Author	SHA1	Message	Date
Richard van der Hoff	f8407975e7	Update some docstrings and comments	5 years ago
Richard van der Hoff	772d414975	Simplify _update_auth_events_and_context_for_auth ... move event_key calculation into _update_context_for_auth_events, since it's only used there.	5 years ago
Richard van der Hoff	807ec3bd99	Fix bug which caused rejected events to be stored with the wrong room state (#6320) ... Fixes a bug where rejected events were persisted with the wrong state group. Also fixes an occasional internal-server-error when receiving events over federation which are rejected and (possibly because they are backwards-extremities) have no prev_group. Fixes #6289.	5 years ago
Richard van der Hoff	0e3ab8afdc	Add some checks that we aren't using state from rejected events (#6330) ... * Raise an exception if accessing state for rejected events Add some sanity checks on accessing state_group etc for rejected events. * Skip calculating push actions for rejected events It didn't actually cause any bugs, because rejected events get filtered out at various later points, but there's not point in trying to calculate the push actions for a rejected event.	5 years ago
Brendan Abolivier	09957ce0e4	Implement per-room message retention policies	5 years ago
Richard van der Hoff	c6516adbe0	Factor out an _AsyncEventContextImpl (#6298) ... The intention here is to make it clearer which fields we can expect to be populated when: notably, that the _event_type etc aren't used for the synchronous impl of EventContext.	5 years ago
Andrew Morgan	ace947e8da	Depublish a room from the public rooms list when it is upgraded (#6232)	5 years ago
Amber Brown	020add5099	Update black to 19.10b0 (#6304) ... * update version of black and also fix the mypy config being overridden	5 years ago
Andrew Morgan	54fef094b3	Remove usage of deprecated logger.warn method from codebase (#6271) ... Replace every instance of `logger.warn` with `logger.warning` as the former is deprecated.	5 years ago
Erik Johnston	69f0054ce6	Port to use state storage	5 years ago
Andrew Morgan	a2276d4d3c	Fix log line that was printing undefined value (#6278)	5 years ago
Richard van der Hoff	172f264ed3	Improve signature checking on some federation APIs (#6262) ... Make sure that we check that events sent over /send_join, /send_leave, and /invite, are correctly signed and come from the expected servers.	5 years ago
Erik Johnston	3ca4c7c516	Use new EventPersistenceStore	5 years ago
Richard van der Hoff	93eaeec75a	Remove Auth.check method (#6217) ... This method was somewhat redundant, and confusing.	5 years ago
Richard van der Hoff	1ba359a11f	rip out some unreachable code ... The only possible rejection reason is AUTH_ERROR, so all of this is unreachable.	5 years ago
Brendan Abolivier	21d51ab598	Typo	5 years ago
Brendan Abolivier	4676732ca0	Lint	5 years ago
Brendan Abolivier	81d51ce48b	Incorporate review	5 years ago
Brendan Abolivier	6527fa18c1	Add test case	5 years ago
Brendan Abolivier	972c9f65d7	Lint	5 years ago
Brendan Abolivier	5705ecaec6	Don't 500 code when trying to exchange a revoked 3PID invite ... While this is not documented in the spec (but should be), Riot (and other clients) revoke 3PID invites by sending a m.room.third_party_invite event with an empty ({}) content to the room's state. When the invited 3PID gets associated with a MXID, the identity server (which doesn't know about revocations) sends down to the MXID's homeserver all of the undelivered invites it has for this 3PID. The homeserver then tries to talk to the inviting homeserver in order to exchange these invite for m.room.member events. When one of the invite is revoked, the inviting homeserver responds with a 500 error because it tries to extract a 'display_name' property from the content, which is empty. This might cause the invited server to consider that the server is down and not try to exchange other, valid invites (or at least delay it). This fix handles the case of revoked invites by avoiding trying to fetch a 'display_name' from the original invite's content, and letting the m.room.member event fail the auth rules (because, since the original invite's content is empty, it doesn't have public keys), which results in sending a 403 with the correct error message to the invited server.	5 years ago
Andrew Morgan	cd17a2085e	Remove origin parameter from add_display_name_to_third_party_invite and add params to docstring (#6010) ... Another small fixup noticed during work on a larger PR. The `origin` field of `add_display_name_to_third_party_invite` is not used and likely was just carried over from the `on_PUT` method of `FederationThirdPartyInviteExchangeServlet` which, like all other servlets, provides an `origin` argument. Since it's not used anywhere in the handler function though, we should remove it from the function arguments.	5 years ago
Andrew Morgan	4548d1f87e	Remove unnecessary parentheses around return statements (#5931) ... Python will return a tuple whether there are parentheses around the returned values or not. I'm just sick of my editor complaining about this all over the place :)	5 years ago
Amber Brown	7dc398586c	Implement a structured logging output system. (#5680)	5 years ago
Erik Johnston	b4d5ff0af7	Don't log as exception when failing durig backfill	5 years ago
Amber Brown	865077f1d1	Room Complexity Client Implementation (#5783)	5 years ago
Richard van der Hoff	d1020653fc	Log when we receive a /make_* request from a different origin	5 years ago
Amber Brown	4806651744	Replace returnValue with return (#5736)	5 years ago
Amber Brown	463b072b12	Move logging utilities out of the side drawer of util/ and into logging/ (#5606)	5 years ago
Amber Brown	32e7c9e7f2	Run Black. (#5482)	6 years ago
David Baker	f2d2ae03da	Add some logging to 3pid invite sig verification (#5015) ... I had to add quite a lot of logging to diagnose a problem with 3pid invites - we only logged the one failure which isn't all that informative. NB. I'm not convinced the logic of this loop is right: I think it should just accept a single valid signature from a trusted source rather than fail if *any* signature is invalid. Also it should probably not skip the rest of middle loop if a check fails? However, I'm deliberately not changing the logic here.	6 years ago
Erik Johnston	2b20d0fb59	Fix logline	6 years ago
Brendan Abolivier	f874b16b2e	Add plugin APIs for implementations of custom event rules.	6 years ago
Erik Johnston	304a1376c2	Fix 3PID invite room state over federation. ... Fixes that when a user exchanges a 3PID invite for a proper invite over federation it does not include the `invite_room_state` key. This was due to synapse incorrectly sending out two invite requests.	6 years ago
Erik Johnston	bc3d6b918b	Add logging when request fails and clarify we ignore errors.	6 years ago
Erik Johnston	220a733d73	Fix handling of failures when calling /event_auth. ... When processing an incoming event over federation, we may try and resolve any unexpected differences in auth events. This is a non-essential process and so should not stop the processing of the event if it fails (e.g. due to the remote disappearing or not implementing the necessary endpoints). Fixes #3330	6 years ago
Richard van der Hoff	85d1e03b9d	Simplifications and comments in do_auth (#5227) ... I was staring at this function trying to figure out wtf it was actually doing. This is (hopefully) a non-functional refactor which makes it a bit clearer.	6 years ago
Richard van der Hoff	c4aef549ad	Exclude soft-failed events from fwd-extremity candidates. (#5146) ... When considering the candidates to be forward-extremities, we must exclude soft failures. Hopefully fixes #5090.	6 years ago
Erik Johnston	c132c8e505	Handle the case of `get_missing_events` failing ... Currently if a call to `/get_missing_events` fails we log an exception and stop processing the top level event we received over federation. Instead let's try and handle it sensibly given it is a somewhat expected failure mode.	6 years ago
Richard van der Hoff	54a87a7b08	Collect room-version variations into one place (#4969) ... Collect all the things that make room-versions different to one another into one place, so that it's easier to define new room versions.	6 years ago
Erik Johnston	0ff8163eae	Factor out soft fail checks	6 years ago
Erik Johnston	a9de04be72	Implement soft fail	6 years ago
Erik Johnston	aa06d26ae0	clarify comments	6 years ago
Erik Johnston	d1523aed6b	Only check history visibility when filtering ... When filtering events to send to server we check more than just history visibility. However when deciding whether to backfill or not we only care about the history visibility.	6 years ago
Erik Johnston	8b63fe4c26	s/get_forward_events/get_successor_events/	6 years ago
Erik Johnston	b183fef9ac	Update comments	6 years ago
Erik Johnston	9c598dddcb	Fix typo	6 years ago
Erik Johnston	d730c2c22b	More comments	6 years ago
Erik Johnston	890cb048fd	Assert rather than clobber the values	6 years ago
Erik Johnston	9342cc6ab1	Add comments and paranoia	6 years ago