watcha-synapse

Commit Graph

Author	SHA1	Message	Date
David Robertson	f7b034a24b	Consistently exclude from user_directory (#10960 ) * Introduce `should_include_local_users_in_dir` We exclude three kinds of local users from the user_directory tables. At present we don't consistently exclude all three in the same places. This commit introduces a new function to gather those exclusion conditions together. Because we have to handle local and remote users in different ways, I've made that function only consider the case of remote users. It's the caller's responsibility to make the local versus remote distinction clear and correct. A test fixup is required. The test now hits a path which makes db queries against the users table. The expected rows were missing, because we were using a dummy user that hadn't actually been registered. We also add new test cases to covert the exclusion logic. ---- By my reading this makes these changes: * When an app service user registers or changes their profile, they will _not_ be added to the user directory. (Previously only support and deactivated users were excluded). This is consistent with the logic that rebuilds the user directory. See also [the discussion here](https://github.com/matrix-org/synapse/pull/10914#discussion_r716859548). * When rebuilding the directory, exclude support and disabled users from room sharing tables. Previously only appservice users were excluded. * Exclude all three categories of local users when rebuilding the directory. Previously `_populate_user_directory_process_users` didn't do any exclusion. Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	3 years ago
David Robertson	3aefc7b66d	Refactor user directory tests (#10935 ) * Pull out GetUserDirectoryTables helper * Don't rebuild the dir in tests that don't need it In #10796 I changed registering a user to add directory entries under. This means we don't have to force a directory regbuild in to tests of the user directory search. * Move test_initial to tests/storage * Add type hints to both test_user_directory files Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	3 years ago
Patrick Cloke	bb7fdd821b	Use direct references for configuration variables (part 5). (#10897 )	3 years ago
David Robertson	7f3352743e	Improve typing in user_directory files (#10891 ) * Improve typing in user_directory files This makes the user_directory.py in storage pass most of mypy's checks (including `no-untyped-defs`). Unfortunately that file is in the tangled web of Store class inheritance so doesn't pass mypy at the moment. The handlers directory has already been mypyed. Co-authored-by: reivilibre <olivier@librepush.net>	3 years ago
David Robertson	dcfd864970	Fix reactivated users not being added to the user directory (#10782 ) Co-authored-by: Dirk Klimpel <5740567+dklimpel@users.noreply.github.com> Co-authored-by: reivilibre <olivier@librepush.net> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	3 years ago
David Robertson	318162f5de	Easy refactors of the user directory (#10789 ) No functional changes here. This came out as I was working to tackle #5677	3 years ago
David Robertson	5e9b382505	Pull out encrypted_by_default tests from user_directory tests (#10752 )	3 years ago
reivilibre	642a42edde	Flatten the synapse.rest.client package (#10600 )	3 years ago
Brendan Abolivier	1b3e398bea	Standardise the module interface (#10062 ) This PR adds a common configuration section for all modules (see docs). These modules are then loaded at startup by the homeserver. Modules register their hooks and web resources using the new `register_[...]_callbacks` and `register_web_resource` methods of the module API.	3 years ago
Jonathan de Jong	4b965c862d	Remove redundant "coding: utf-8" lines (#9786 ) Part of #9744 Removes all redundant `# -- coding: utf-8 --` lines from files, as python 3 automatically reads source code as utf-8 now. `Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>`	4 years ago
Patrick Cloke	0b3112123d	Use mock from the stdlib. (#9772 )	4 years ago
Patrick Cloke	c4a55ac4a4	Fix style checking due to updated black.	4 years ago
Andrew Morgan	13e9029f44	Add a config option to prioritise local users in user directory search results (#9383 ) This PR adds a homeserver config option, `user_directory.prefer_local_users`, that when enabled will show local users higher in user directory search results than remote users. This option is off by default. Note that turning this on doesn't necessarily mean that remote users will always be put below local users, but they should be assuming all other ranking factors (search query match, profile information present etc) are identical. This is useful for, say, University networks that are openly federating, but want to prioritise local students and staff in the user directory over other random users.	4 years ago
Eric Eastwood	0a00b7ff14	Update black, and run auto formatting over the codebase (#9381 ) - Update black version to the latest - Run black auto formatting over the codebase - Run autoformatting according to [`docs/code_style.md `](`80d6dc9783/docs/code_style.md`) - Update `code_style.md` docs around installing black to use the correct version	4 years ago
Dirk Klimpel	c07022303e	Fix a bug that deactivated users appear in the directory (#8933 ) Fixes a bug that deactivated users appear in the directory when their profile information was updated. To change profile information of deactivated users is neccesary for example you will remove displayname or avatar. But they should not appear in directory. They are deactivated. Co-authored-by: Erik Johnston <erikj@jki.re>	4 years ago
Richard van der Hoff	394516ad1b	Remove spurious "SynapseRequest" result from `make_request" This was never used, so let's get rid of it.	4 years ago
David Teller	f14428b25c	Allow spam-checker modules to be provide async methods. (#8890 ) Spam checker modules can now provide async methods. This is implemented in a backwards-compatible manner.	4 years ago
Richard van der Hoff	acfe3b3065	Remove redundant `HomeserverTestCase.render`	4 years ago
Patrick Cloke	3f91638da6	Allow denying or shadow banning registrations via the spam checker (#8034 )	4 years ago
Erik Johnston	a7bdf98d01	Rename database classes to make some sense (#8033 )	4 years ago
Andrew Morgan	fcd6961441	Add option to enable encryption by default for new rooms (#7639 ) Fixes https://github.com/matrix-org/synapse/issues/2431 Adds config option `encryption_enabled_by_default_for_room_type`, which determines whether encryption should be enabled with the default encryption algorithm in private or public rooms upon creation. Whether the room is private or public is decided based upon the room creation preset that is used. Part of this PR is also pulling out all of the individual instances of `m.megolm.v1.aes-sha2` into a constant variable to eliminate typos ala https://github.com/matrix-org/synapse/pull/7637 Based on #7637	5 years ago
Patrick Cloke	737b4a936e	Convert user directory handler and related classes to async/await. (#7640 )	5 years ago
Andrew Morgan	67feea8044	Extend spam checker to allow for multiple modules (#7435 )	5 years ago
Patrick Cloke	509e381afa	Clarify list/set/dict/tuple comprehensions and enforce via flake8 (#6957 ) Ensure good comprehension hygiene using flake8-comprehensions.	5 years ago
Patrick Cloke	49f877d32e	Filter the results of user directory searching via the spam checker (#6888 ) Add a method to the spam checker to filter the user directory results.	5 years ago
Erik Johnston	4a33a6dd19	Move background update handling out of store	5 years ago
Erik Johnston	756d4942f5	Move DB pool and helper functions into dedicated Database class	5 years ago
Erik Johnston	ee86abb2d6	Remove underscore from SQLBaseStore functions	5 years ago
Richard van der Hoff	953dbb7980	Remove access-token support from RegistrationStore.register (#5642 ) The 'token' param is no longer used anywhere except the tests, so let's kill that off too.	5 years ago
Amber Brown	32e7c9e7f2	Run Black. (#5482 )	6 years ago
Amber Brown	be452fc9ac	more fix	6 years ago
Amber Brown	7f81b967ca	fix schemas	6 years ago
Amber Brown	df2ebd75d3	Migrate all tests to use the dict-based config format instead of hanging items off HomeserverConfig (#5171 )	6 years ago
Amber Brown	b36c82576e	Run Black on the tests again (#5170 )	6 years ago
Richard van der Hoff	12f9d51e82	Add admin api for sending server_notices (#5121 )	6 years ago
Richard van der Hoff	40e576e29c	Move admin api impl to its own package It doesn't really belong under rest/client/v1 any more.	6 years ago
Erik Johnston	3660d24ebe	Add test	6 years ago
Amber Brown	282c97327f	Migrate the user directory initial population to a background task (#4864 )	6 years ago
Amber Brown	797b6a63fc	fixup	6 years ago
Amber Brown	10480c4348	fixup	6 years ago
Amber Brown	5ba8ceab4c	fixes	6 years ago
Amber Brown	4abc988c6a	initial	6 years ago
Amber Brown	f6135d06cf	Rewrite userdir to be faster (#4537 )	6 years ago
Neil Johnson	d2f7c4e6b1	create support user (#4141 ) Allow for the creation of a support user. A support user can access the server, join rooms, interact with other users, but does not appear in the user directory nor does it contribute to monthly active user limits.	6 years ago

42 Commits (38b7db58859d80f06b8dc94e6a6dd19600778caa)