43 Commits (408aef827691be3a1b92f38ebdf5aab7468ab5ef)

Author	SHA1	Message	Date
Erik Johnston	e29c44340b	Fix recursion error when fetching auth chain over federation (#7817) ... When fetching the state of a room over federation we receive the event IDs of the state and auth chain. We then fetch those events that we don't already have. However, we used a function that recursively fetched any missing auth events for the fetched events, which can lead to a lot of recursion if the server is missing most of the auth chain. This work is entirely pointless because would have queued up the missing events in the auth chain to be fetched already. Let's just diable the recursion, since it only gets called from one place anyway.	4 years ago
Patrick Cloke	5355421295	Add type hints to event_auth code. (#7505)	5 years ago
Patrick Cloke	fef3ff5cc4	Enforce MSC2209: auth rules for notifications in power level event (#7502) ... In a new room version, the "notifications" key of power level events are subject to restricted auth rules.	5 years ago
Patrick Cloke	06eb5cae08	Remove special auth and redaction rules for aliases events in experimental room ver. (#7037)	5 years ago
Richard van der Hoff	a1f307f7d1	fix bad variable ref	5 years ago
Richard van der Hoff	49d3bca37b	Implement updated auth rules from MSC2260	5 years ago
Richard van der Hoff	a8ce7aeb43	Pass room version object into event_auth.check and check_redaction (#6788) ... These are easier to work with than the strings and we normally have one around. This fixes `FederationHander._persist_auth_tree` which was passing a RoomVersion object into event_auth.check instead of a string.	5 years ago
Erik Johnston	0f6e525be3	Fixup synapse.api to pass mypy (#6733)	5 years ago
Erik Johnston	5029422530	Fix bug where we added duplicate event IDs as auth_events (#6560)	5 years ago
Richard van der Hoff	6577f2d887	Sanity-check room ids in event auth (#6530) ... When we do an event auth operation, check that all of the events involved are in the right room.	5 years ago
Richard van der Hoff	971a0702b5	Sanity-check room ids in event auth (#6530) ... When we do an event auth operation, check that all of the events involved are in the right room.	5 years ago
Richard van der Hoff	424fd58237	Remove redundant code from event authorisation implementation. (#6502)	5 years ago
Andrew Morgan	54fef094b3	Remove usage of deprecated logger.warn method from codebase (#6271) ... Replace every instance of `logger.warn` with `logger.warning` as the former is deprecated.	5 years ago
Andrew Morgan	92e88a71d3	Cleanup extra quotes from IDEs (#6236)	5 years ago
Andrew Morgan	b09d443632	Cleanup event auth type initialisation (#5975) ... Very small code cleanup.	5 years ago
Amber Brown	32e7c9e7f2	Run Black. (#5482)	6 years ago
Richard van der Hoff	54a87a7b08	Collect room-version variations into one place (#4969) ... Collect all the things that make room-versions different to one another into one place, so that it's easier to define new room versions.	6 years ago
Erik Johnston	655ce037fd	check event format version not room version	6 years ago
Erik Johnston	47e2dd1994	Drop vdh support	6 years ago
Erik Johnston	770b823445	Only check event IDs domain signed event for V1 and V2 ... Since newer versions of events don't have the same format for event ID.	6 years ago
Erik Johnston	7709d2bd16	Implement rechecking of redactions	6 years ago
Erik Johnston	ae2a957dba	Pass through room version to event auth	6 years ago
Erik Johnston	bc80b3f454	Add helpers for getting prev and auth events (#4139) ... * Add helpers for getting prev and auth events This is in preparation for allowing the event format to change between room versions.	6 years ago
Erik Johnston	6bd856caa2	User event.sender rather than alias event.user_id	6 years ago
Erik Johnston	52e6e815be	Sanitise error messages when user doesn't have permission to invite	6 years ago
Erik Johnston	69e857853f	Fix handling of rejected threepid invites	6 years ago
Richard van der Hoff	8afddf7afe	Fix error handling for missing auth_event ... When we were authorizing an event, if there was no `m.room.create` in its auth_events, we would raise a SynapseError with a cryptic message, which then meant that we would bail out of processing any incoming events, rather than storing a rejection for the faulty event and moving on. We should treat the absent event the same as any other auth failure, by raising an AuthError, so that the event is marked as rejected.	6 years ago
Richard van der Hoff	19a17068f1	Check m.room.create for sane room_versions	6 years ago
Amber Brown	49af402019	run isort	6 years ago
Erik Johnston	2c33b55738	Avoid relying on int vs None comparison ... Python 3 doesn't support comparing None to ints	6 years ago
Erik Johnston	cbf82dddf1	Ensure that we define sender_domain	6 years ago
Richard van der Hoff	5c9afd6f80	Make default state_default 50 ... Make it so that, before there is a power-levels event in the room, you need a power level of at least 50 to send state. Partially addresses https://github.com/matrix-org/matrix-doc/issues/1192	7 years ago
Richard van der Hoff	52423607bd	Clarify interface for event_auth ... stop pretending that it returns a boolean, which just almost gave me a heart attack.	7 years ago
Richard van der Hoff	557b686eac	Refactor get_send_level to take a power_levels event ... it makes it easier for me to reason about	7 years ago
Amber Brown	c936a52a9e	Consistently use six's iteritems and wrap lazy keys/values in list() if they're not meant to be lazy (#3307)	7 years ago
Travis Ralston	eccfc8e928	Fix templating error with unban permission message ... Fixes https://github.com/matrix-org/synapse/issues/2759 Signed-off-by: Travis Ralston <travpc@gmail.com>	7 years ago
Richard van der Hoff	eaaabc6c4f	replace 'except:' with 'except Exception:' ... what could possibly go wrong	7 years ago
Richard van der Hoff	c2bd177ea0	Fix 500 error when fields missing from power_levels event ... If the users or events keys were missing from a power_levels event, then we would throw 500s when trying to auth them.	7 years ago
Erik Johnston	e5d2df9c34	Use better variable name	8 years ago
Erik Johnston	5d6bad1b3c	Optimise state resolution	8 years ago
Erik Johnston	8b2fa38256	Split event auth code into seperate module	8 years ago