145 Commits (4953cd71dfbb1925dc4a477efd2ed48c2dfd70d6)

Author	SHA1	Message	Date
Richard van der Hoff	5febf88b6c	Update the error code for duplicate annotation (#15075)	3 years ago
Mathieu Velten	6cddf24e36	Faster joins: don't stall when a user joins during a fast join (#14606) ... Fixes #12801. Complement tests are at https://github.com/matrix-org/complement/pull/567. Avoid blocking on full state when handling a subsequent join into a partial state room. Also always perform a remote join into partial state rooms, since we do not know whether the joining user has been banned and want to avoid leaking history to banned users. Signed-off-by: Mathieu Velten <mathieuv@matrix.org> Co-authored-by: Sean Quah <seanq@matrix.org> Co-authored-by: David Robertson <davidr@element.io>	3 years ago
reivilibre	62ed877433	Improve validation of field size limits in events. (#14664)	3 years ago
Patrick Cloke	9d8a3234ba	Respond with proper error responses on unknown paths. (#14621) ... Returns a proper 404 with an errcode of M_RECOGNIZED for unknown endpoints per MSC3743.	3 years ago
Patrick Cloke	d8cc86eff4	Remove redundant types from comments. (#14412) ... Remove type hints from comments which have been added as Python type hints. This helps avoid drift between comments and reality, as well as removing redundant information. Also adds some missing type hints which were simple to fill in.	3 years ago
Eric Eastwood	70b3396506	Explain `SynapseError` and `FederationError` better (#14191) ... Explain `SynapseError` and `FederationError` better Spawning from https://github.com/matrix-org/synapse/pull/13816#discussion_r993262622	3 years ago
Eric Eastwood	40bb37eb27	Stop getting missing `prev_events` after we already know their signature is invalid (#13816) ... While https://github.com/matrix-org/synapse/pull/13635 stops us from doing the slow thing after we've already done it once, this PR stops us from doing one of the slow things in the first place. Related to - https://github.com/matrix-org/synapse/issues/13622 - https://github.com/matrix-org/synapse/pull/13635 - https://github.com/matrix-org/synapse/issues/13676 Part of https://github.com/matrix-org/synapse/issues/13356 Follow-up to https://github.com/matrix-org/synapse/pull/13815 which tracks event signature failures. With this PR, we avoid the call to the costly `_get_state_ids_after_missing_prev_event` because the signature failure will count as an attempt before and we filter events based on the backoff before calling `_get_state_ids_after_missing_prev_event` now. For example, this will save us 156s out of the 185s total that this `matrix.org` `/messages` request. If you want to see the full Jaeger trace of this, you can drag and drop this `trace.json` into your own Jaeger, https://gist.github.com/MadLittleMods/4b12d0d0afe88c2f65ffcc907306b761 To explain this exact scenario around `/messages` -> backfill, we call `/backfill` and first check the signatures of the 100 events. We see bad signature for `$luA4l7QHhf_jadH3mI-AyFqho0U2Q-IXXUbGSMq6h6M` and `$zuOn2Rd2vsC7SUia3Hp3r6JSkSFKcc5j3QTTqW_0jDw` (both member events). Then we process the 98 events remaining that have valid signatures but one of the events references `$luA4l7QHhf_jadH3mI-AyFqho0U2Q-IXXUbGSMq6h6M` as a `prev_event`. So we have to do the whole `_get_state_ids_after_missing_prev_event` rigmarole which pulls in those same events which fail again because the signatures are still invalid. - `backfill` - `outgoing-federation-request` `/backfill` - `_check_sigs_and_hash_and_fetch` - `_check_sigs_and_hash_and_fetch_one` for each event received over backfill - ❗ `$luA4l7QHhf_jadH3mI-AyFqho0U2Q-IXXUbGSMq6h6M` fails with `Signature on retrieved event was invalid.`: `unable to verify signature for sender domain xxx: 401: Failed to find any key to satisfy: _FetchKeyRequest(...)` - ❗ `$zuOn2Rd2vsC7SUia3Hp3r6JSkSFKcc5j3QTTqW_0jDw` fails with `Signature on retrieved event was invalid.`: `unable to verify signature for sender domain xxx: 401: Failed to find any key to satisfy: _FetchKeyRequest(...)` - `_process_pulled_events` - `_process_pulled_event` for each validated event - ❗ Event `$Q0iMdqtz3IJYfZQU2Xk2WjB5NDF8Gg8cFSYYyKQgKJ0` references `$luA4l7QHhf_jadH3mI-AyFqho0U2Q-IXXUbGSMq6h6M` as a `prev_event` which is missing so we try to get it - `_get_state_ids_after_missing_prev_event` - `outgoing-federation-request` `/state_ids` - ❗ `get_pdu` for `$luA4l7QHhf_jadH3mI-AyFqho0U2Q-IXXUbGSMq6h6M` which fails the signature check again - ❗ `get_pdu` for `$zuOn2Rd2vsC7SUia3Hp3r6JSkSFKcc5j3QTTqW_0jDw` which fails the signature check	3 years ago
Brendan Abolivier	be76cd8200	Allow admins to require a manual approval process before new accounts can be used (using MSC3866) (#13556)	3 years ago
reivilibre	c06b2b7142	Faster Remote Room Joins: tell remote homeservers that we are unable to authorise them if they query a room which has partial state on our server. (#13823)	3 years ago
Will Hunt	502f075e96	Implement MSC3848: Introduce errcodes for specific event sending failures (#13343) ... Implements MSC3848	4 years ago
David Teller	11f811470f	Uniformize spam-checker API, part 5: expand other spam-checker callbacks to return `Tuple[Codes, dict]` (#13044) ... Signed-off-by: David Teller <davidt@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	4 years ago
Travis Ralston	d0e40dfe29	Fix M_USER_ACCOUNT_SUSPENDED error code for spec compliance (#12923)	4 years ago
Travis Ralston	bcfdfeb65d	Revert "Fix M_USER_ACCOUNT_SUSPENDED error code for spec compliance (#12922)" ... This reverts commit e0fae823e9.	4 years ago
Travis Ralston	e0fae823e9	Fix M_USER_ACCOUNT_SUSPENDED error code for spec compliance (#12922) ... `M_` is a reserved namespace.	4 years ago
David Teller	af7db19e1e	Uniformize spam-checker API, part 3: Expand check_event_for_spam with the ability to return additional fields (#12846) ... Signed-off-by: David Teller <davidt@element.io>	4 years ago
David Teller	888eb736a1	Add code M_USER_ACCOUNT_SUSPENDED, as per MSC3823. (#12845) ... Signed-off-by: David Teller <davidt@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	4 years ago
David Teller	28199e9357	Uniformize spam-checker API, part 2: check_event_for_spam (#12808) ... Signed-off-by: David Teller <davidt@element.io>	4 years ago
David Teller	10280fc943	Uniformize spam-checker API, part 1: the `Code` enum. (#12703)	4 years ago
Tulir Asokan	4bc8cb4669	Implement MSC2815: allow room moderators to view redacted event content (#12427) ... Implements matrix-org/matrix-spec-proposals#2815 Signed-off-by: Tulir Asokan <tulir@maunium.net>	4 years ago
Michael Telatynski	54e74f8bde	Fix M_WRONG_ROOM_KEYS_VERSION error not including `current_version` field (#11988) ... Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>	4 years ago
reivilibre	69ab3dddbc	Make `check_event_allowed` module API callback not fail open (accept events) when an exception is raised (#11033)	4 years ago
Patrick Cloke	3ab55d43bd	Add missing type hints to synapse.api. (#11109) ... * Convert UserPresenceState to attrs. * Remove args/kwargs from error classes and explicitly pass msg/errorcode.	4 years ago
David Robertson	ee3b2ac59a	Validate device_keys for C-S /keys/query requests (#10593) ... * Validate device_keys for C-S /keys/query requests Closes #10354 A small, not particularly critical fix. I'm interested in seeing if we can find a more systematic approach though. #8445 is the place for any discussion.	4 years ago
Patrick Cloke	228decfce1	Update the MSC3083 support to verify if joins are from an authorized server. (#10254)	5 years ago
Jonathan de Jong	bf72d10dbf	Use inline type hints in various other places (in `synapse/`) (#10380)	5 years ago
Sorunome	d936371b69	Implement knock feature (#6739) ... This PR aims to implement the knock feature as proposed in https://github.com/matrix-org/matrix-doc/pull/2403 Signed-off-by: Sorunome mail@sorunome.de Signed-off-by: Andrew Morgan andrewm@element.io	5 years ago
Jonathan de Jong	4b965c862d	Remove redundant "coding: utf-8" lines (#9786) ... Part of #9744 Removes all redundant `# -*- coding: utf-8 -*-` lines from files, as python 3 automatically reads source code as utf-8 now. `Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>`	5 years ago
Eric Eastwood	0a00b7ff14	Update black, and run auto formatting over the codebase (#9381) ... - Update black version to the latest - Run black auto formatting over the codebase - Run autoformatting according to [`docs/code_style.md `](80d6dc9783/docs/code_style.md) - Update `code_style.md` docs around installing black to use the correct version	5 years ago
Patrick Cloke	8a4a4186de	Simplify super() calls to Python 3 syntax. (#8344) ... This converts calls like super(Foo, self) -> super(). Generated with: sed -i "" -Ee 's/super\([^\(]+\)/super()/g' **/*.py	5 years ago
Patrick Cloke	c619253db8	Stop sub-classing object (#8249)	5 years ago
Patrick Cloke	e259d63f73	Stop shadow-banned users from sending invites. (#8095)	6 years ago
Patrick Cloke	eebf52be06	Be stricter about JSON that is accepted by Synapse (#8106)	6 years ago
Patrick Cloke	66f24449dd	Improve performance of the register endpoint (#8009)	6 years ago
Patrick Cloke	35450519de	Ensure that calls to `json.dumps` are compatible with the standard library json. (#7836)	6 years ago
Patrick Cloke	4db1509516	Improve the type hints of synapse.api.errors. (#7820)	6 years ago
Patrick Cloke	66a4af8d96	Do not use canonicaljson to magically handle decoding bytes from JSON. (#7802)	6 years ago
Dagfinn Ilmari Mannsåker	a3f11567d9	Replace all remaining six usage with native Python 3 equivalents (#7704)	6 years ago
Patrick Cloke	bd6dc17221	Replace iteritems/itervalues/iterkeys with native versions. (#7692)	6 years ago
Andrew Morgan	07b88c546d	Convert http.HTTPStatus objects to their int equivalent (#7188)	6 years ago
Dirk Klimpel	e8e2ddb60a	Allow server admins to define and enforce a password policy (MSC2000). (#7118)	6 years ago
Patrick Cloke	7dcbc33a1b	Validate the alt_aliases property of canonical alias events (#6971)	6 years ago
Richard van der Hoff	08f41a6f05	Add `get_room_version` method ... So that we can start factoring out some of this boilerplatey boilerplate.	6 years ago
Richard van der Hoff	8f5d7302ac	Implement RedirectException (#6687) ... Allow REST endpoint implemnentations to raise a RedirectException, which will redirect the user's browser to a given location.	6 years ago
Richard van der Hoff	326c893d24	Kill off RegistrationError (#6691) ... This is pretty pointless. Let's just use SynapseError.	6 years ago
Andrew Morgan	bc29a19731	Replace instance variations of homeserver with correct case/spacing	6 years ago
Amber Brown	864f144543	Fix up some typechecking (#6150) ... * type checking fixes * changelog	6 years ago
Andrew Morgan	72167fb394	Change user deactivated errcode to USER_DEACTIVATED and use it (#5686) ... This is intended as an amendment to #5674 as using M_UNKNOWN as the errcode makes it hard for clients to differentiate between an invalid password and a deactivated user (the problem we were trying to solve in the first place). M_UNKNOWN was originally chosen as it was presumed than an MSC would have to be carried out to add a new code, but as Synapse often is the testing bed for new MSC implementations, it makes sense to try it out first in the wild and then add it into the spec if it is successful. Thus this PR return a new M_USER_DEACTIVATED code when a deactivated user attempts to login.	7 years ago
Hubert Chathi	c659b9f94f	allow uploading keys for cross-signing	7 years ago
Andrew Morgan	18c516698e	Return a different error from Invalid Password when a user is deactivated (#5674) ... Return `This account has been deactivated` instead of `Invalid password` when a user is deactivated.	7 years ago
Richard van der Hoff	5f158ec039	Implement access token expiry (#5660) ... Record how long an access token is valid for, and raise a soft-logout once it expires.	7 years ago