120 Commits (5126cb1253d89ba196fcc828319bf195c866588a)

Author	SHA1	Message	Date
Andrew Morgan	3916e1b97a	Clean up newline quote marks around the codebase (#6362)	5 years ago
Will Hunt	42e707c663	rstrip slashes from url on appservice (#6306)	5 years ago
Andrew Morgan	2a44782666	Remove double return statements (#5962) ... Remove all the "double return" statements which were a result of us removing all the instances of ``` defer.returnValue(...) return ``` statements when we switched to python3 fully.	5 years ago
Richard van der Hoff	baa3f4a80d	Avoid deep recursion in appservice recovery (#5885) ... Hopefully, this will fix a stack overflow when recovering an appservice. The recursion here leads to a huge chain of deferred callbacks, which then overflows the stack when the chain completes. `inlineCallbacks` makes a better job of this if we use iteration instead. Clean up the code a bit too, while we're there.	5 years ago
Richard van der Hoff	5019945828	Refactor the Appservice scheduler code ... Get rid of the labyrinthine `recoverer_fn` code, and clean up the startup code (it seemed to be previously inexplicably split between `ApplicationServiceScheduler.start` and `_Recoverer.start`). Add some docstrings too.	5 years ago
Amber Brown	4806651744	Replace returnValue with return (#5736)	5 years ago
Amber Brown	463b072b12	Move logging utilities out of the side drawer of util/ and into logging/ (#5606)	5 years ago
Amber Brown	32e7c9e7f2	Run Black. (#5482)	6 years ago
Richard van der Hoff	52e87fbfbe	Run the AS senders as background processes (#4189) ... This should fix some "Starting db connection from sentinel context" warnings, and will mean we get metrics for these processes.	6 years ago
Amber Brown	2d2828dcbc	Port http/ to Python 3 (#3771)	6 years ago
Amber Brown	49af402019	run isort	6 years ago
Matthew Hodgson	f4f1cda928	add ip_range_whitelist parameter to limit where ASes can connect from	7 years ago
Michael Telatynski	592c162516	also redact __str__ of ApplicationService used for logging	7 years ago
Will Hunt	d6e3c2c79b	Let's try labels instead of label, that might work	7 years ago
Will Hunt	604cff1a06	Add metrics to track appservice transactions	7 years ago
Richard van der Hoff	2a13af23bc	Use run_in_background in preference to preserve_fn ... While I was going through uses of preserve_fn for other PRs, I converted places which only use the wrapped function once to use run_in_background, to avoid creating the function object.	7 years ago
Richard van der Hoff	9255a6cb17	Improve exception handling for background processes ... There were a bunch of places where we fire off a process to happen in the background, but don't have any exception handling on it - instead relying on the unhandled error being logged when the relevent deferred gets garbage-collected. This is unsatisfactory for a number of reasons: - logging on garbage collection is best-effort and may happen some time after the error, if at all - it can be hard to figure out where the error actually happened. - it is logged as a scary CRITICAL error which (a) I always forget to grep for and (b) it's not really CRITICAL if a background process we don't care about fails. So this is an attempt to add exception handling to everything we fire off into the background.	7 years ago
Richard van der Hoff	b78395b7fe	Refactor ResponseCache usage ... Adds a `.wrap` method to ResponseCache which wraps up the boilerplate of a (get, set) pair, and then use it throughout the codebase. This will be largely non-functional, but does include the following functional changes: * federation_server.on_context_state_request: drops use of _server_linearizer which looked redundant and could cause incorrect cache misses by yielding between the get and the set. * RoomListHandler.get_remote_public_room_list(): fixes logcontext leaks * the wrap function includes some logging. I'm hoping this won't be too noisy on production.	7 years ago
Richard van der Hoff	b3384232a0	Add metrics for ResponseCache	7 years ago
Adrian Tschira	e54c202b81	Replace some type checks with six type checks ... Signed-off-by: Adrian Tschira <nota@notafile.com>	7 years ago
Luke Barnard	7fb0e98b03	Extract group_id from the dict for multiple use	7 years ago
Luke Barnard	d8391f0541	Remove unused GROUP_ID_REGEX	7 years ago
Luke Barnard	4e8374856d	Document get_groups_for_user	7 years ago
Luke Barnard	270f9cd23a	Flake8	7 years ago
Luke Barnard	9d83d52027	Use a generator instead of a list	7 years ago
Luke Barnard	b1edf26051	Check group_id belongs to this domain	7 years ago
Luke Barnard	97bd18af4e	Add automagical AS Publicised Group(s) ... via registration file "users" namespace: ```YAML ... namespaces: users: - exclusive: true regex: '.*luke.*' group_id: '+all_the_lukes:hsdomain' ... ``` This is part of giving App Services their own groups for matching users. With this, ghost users will be given the appeareance that they are in a group and that they have publicised the fact, but _only_ from the perspective of the `get_publicised_groups_for_user` API.	7 years ago
Erik Johnston	2a7e9faeec	Do logcontexts outside ResponseCache	7 years ago
Richard van der Hoff	eaaabc6c4f	replace 'except:' with 'except Exception:' ... what could possibly go wrong	7 years ago
Erik Johnston	760625acba	Make get_if_app_services_interested_in_user faster	8 years ago
Erik Johnston	69efd77749	Add comment	8 years ago
Erik Johnston	51b156d48a	Cache whether an AS is interested based on members	8 years ago
Erik Johnston	30f5ffdca2	Remove param and cast at call site	8 years ago
Erik Johnston	650f0e69f2	Compile the regex's used in ASes	8 years ago
Erik Johnston	2bf5a47b3e	Rename network_id to instance_id on client side	8 years ago
Erik Johnston	3727d66a0e	Don't include appservice id	8 years ago
Erik Johnston	f32fb65552	Add new API appservice specific public room list	8 years ago
Luke Barnard	5b54d51d1e	Allow Configurable Rate Limiting Per AS ... This adds a flag loaded from the registration file of an AS that will determine whether or not its users are rate limited (by ratelimit in _base.py). Needed for IRC bridge reasons - see https://github.com/matrix-org/matrix-appservice-irc/issues/240.	8 years ago
Paul "LeoNerd" Evans	776594f99d	Log if rejecting 3PE query metadata result due to type check	8 years ago
Paul "LeoNerd" Evans	ed44c475d8	Reject malformed 3PE query metadata results earlier in AS API handling code	8 years ago
Kegan Dougal	572acde483	Use None instead of the empty string ... Change how we validate the 'url' field as a result.	8 years ago
Kegan Dougal	16b652f0a3	Flake8	8 years ago
Kegan Dougal	e82247f990	Allow application services to have an optional 'url' ... If 'url' is not specified, they will not be pushed for events or queries. This is useful for bots who simply wish to reserve large chunks of user/alias namespace, and don't care about being pushed for events.	8 years ago
Paul "LeoNerd" Evans	9459137f1e	Just sprintf the 'kind' argument into uri directly	8 years ago
Paul "LeoNerd" Evans	1294d4a329	Move ThirdPartyEntityKind into api.constants so the expectation becomes that the value is significant	8 years ago
Paul "LeoNerd" Evans	e7af8be5ae	Root the 3PE lookup API within /_matrix/app/unstable instead of at toplevel	8 years ago
Paul "LeoNerd" Evans	adf53f04ce	appease pep8	8 years ago
Paul "LeoNerd" Evans	db7283cc6b	Implement a ResponseCache around 3PE lookup metadata lookups	8 years ago
Paul "LeoNerd" Evans	d0b8d49f71	Kill PROTOCOL_META since I'm not using it any more	8 years ago
Paul "LeoNerd" Evans	5474824975	Actually query over AS API for 3PE lookup metadata	8 years ago