229 Commits (66d7aa783a8ad1b3eb6d17ba086e2dda8a912ab6)

Author	SHA1	Message	Date
Olivier Wilkinson (reivilibre)	4dd9ea8f4f	Revert "Revert accidental fast-forward merge from v1.49.0rc1" ... This reverts commit 158d73ebdd.	3 years ago
Sean Quah	158d73ebdd	Revert accidental fast-forward merge from v1.49.0rc1 ... Revert "Sort internal changes in changelog" Revert "Update CHANGES.md" Revert "1.49.0rc1" Revert "Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505) (#11527)" Revert "Refactors in `_generate_sync_entry_for_rooms` (#11515)" Revert "Correctly register shutdown handler for presence workers (#11518)" Revert "Fix `ModuleApi.looping_background_call` for non-async functions (#11524)" Revert "Fix 'delete room' admin api to work on incomplete rooms (#11523)" Revert "Correctly ignore invites from ignored users (#11511)" Revert "Fix the test breakage introduced by #11435 as a result of concurrent PRs (#11522)" Revert "Stabilise support for MSC2918 refresh tokens as they have now been merged into the Matrix specification. (#11435)" Revert "Save the OIDC session ID (sid) with the device on login (#11482)" Revert "Add admin API to get some information about federation status (#11407)" Revert "Include bundled aggregations in /sync and related fixes (#11478)" Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505)" Revert "Update backward extremity docs to make it clear that it does not indicate whether we have fetched an events' `prev_events` (#11469)" Revert "Support configuring the lifetime of non-refreshable access tokens separately to refreshable access tokens. (#11445)" Revert "Add type hints to `synapse/tests/rest/admin` (#11501)" Revert "Revert accidental commits to develop." Revert "Newsfile" Revert "Give `tests.server.setup_test_homeserver` (nominally!) the same behaviour" Revert "Move `tests.utils.setup_test_homeserver` to `tests.server`" Revert "Convert one of the `setup_test_homeserver`s to `make_test_homeserver_synchronous`" Revert "Disambiguate queries on `state_key` (#11497)" Revert "Comments on the /sync tentacles (#11494)" Revert "Clean up tests.storage.test_appservice (#11492)" Revert "Clean up `tests.storage.test_main` to remove use of legacy code. (#11493)" Revert "Clean up `tests.test_visibility` to remove legacy code. (#11495)" Revert "Minor cleanup on recently ported doc pages (#11466)" Revert "Add most of the missing type hints to `synapse.federation`. (#11483)" Revert "Avoid waiting for zombie processes in `synctl stop` (#11490)" Revert "Fix media repository failing when media store path contains symlinks (#11446)" Revert "Add type annotations to `tests.storage.test_appservice`. (#11488)" Revert "`scripts-dev/sign_json`: support for signing events (#11486)" Revert "Add MSC3030 experimental client and federation API endpoints to get the closest event to a given timestamp (#9445)" Revert "Port wiki pages to documentation website (#11402)" Revert "Add a license header and comment. (#11479)" Revert "Clean-up get_version_string (#11468)" Revert "Link background update controller docs to summary (#11475)" Revert "Additional type hints for config module. (#11465)" Revert "Register the login redirect endpoint for v3. (#11451)" Revert "Update openid.md" Revert "Remove mention of OIDC certification from Dex (#11470)" Revert "Add a note about huge pages to our Postgres doc (#11467)" Revert "Don't start Synapse master process if `worker_app` is set (#11416)" Revert "Expose worker & homeserver as entrypoints in `setup.py` (#11449)" Revert "Bundle relations of relations into the `/relations` result. (#11284)" Revert "Fix `LruCache` corruption bug with a `size_callback` that can return 0 (#11454)" Revert "Eliminate a few `Any`s in `LruCache` type hints (#11453)" Revert "Remove unnecessary `json.dumps` from `tests.rest.admin` (#11461)" Revert "Merge branch 'master' into develop" This reverts commit 26b5d2320f. This reverts commit bce4220f38. This reverts commit 966b5d0fa0. This reverts commit 088d748f2c. This reverts commit 14d593f72d. This reverts commit 2a3ec6facf. This reverts commit eccc49d755. This reverts commit b1ecd19c5d. This reverts commit 9c55dedc8c. This reverts commit 2d42e586a8. This reverts commit 2f053f3f82. This reverts commit a15a893df8. This reverts commit 8b4b153c9e. This reverts commit 494ebd7347. This reverts commit a77c369897. This reverts commit 4eb77965cd. This reverts commit 637df95de6. This reverts commit e5f426cd54. This reverts commit 8cd68b8102. This reverts commit 6cae125e20. This reverts commit 7be88fbf48. This reverts commit b3fd99b74a. This reverts commit f7ec6e7d9e. This reverts commit 5640992d17. This reverts commit d26808dd85. This reverts commit f91624a595. This reverts commit 16d39a5490. This reverts commit 8a4c296987. This reverts commit 49e1356ee3. This reverts commit d2279f471b. This reverts commit b50e39df57. This reverts commit 858d80bf0f. This reverts commit 435f044807. This reverts commit f61462e1be. This reverts commit a6f1a3abec. This reverts commit 84dc50e160. This reverts commit ed635d3285. This reverts commit 7b62791e00. This reverts commit 153194c771. This reverts commit f44d729d4c. This reverts commit a265fbd397. This reverts commit b9fef1a7cd. This reverts commit b0eb64ff7b. This reverts commit f1795463bf. This reverts commit 70cbb1a5e3. This reverts commit 42bf020463. This reverts commit 379f2650cf. This reverts commit 7ff22d6da4. This reverts commit 5a0b652d36. This reverts commit 432a174bc1. This reverts commit b14f8a1baf, reversing changes made to e713855dca.	3 years ago
Patrick Cloke	d2279f471b	Add most of the missing type hints to `synapse.federation`. (#11483) ... This skips a few methods which are difficult to type.	3 years ago
Eric Eastwood	a6f1a3abec	Add MSC3030 experimental client and federation API endpoints to get the closest event to a given timestamp (#9445) ... MSC3030: https://github.com/matrix-org/matrix-doc/pull/3030 Client API endpoint. This will also go and fetch from the federation API endpoint if unable to find an event locally or we found an extremity with possibly a closer event we don't know about. ``` GET /_matrix/client/unstable/org.matrix.msc3030/rooms/<roomID>/timestamp_to_event?ts=<timestamp>&dir=<direction> { "event_id": ... "origin_server_ts": ... } ``` Federation API endpoint: ``` GET /_matrix/federation/unstable/org.matrix.msc3030/timestamp_to_event/<roomID>?ts=<timestamp>&dir=<direction> { "event_id": ... "origin_server_ts": ... } ``` Co-authored-by: Erik Johnston <erik@matrix.org>	3 years ago
Patrick Cloke	a4521ce0a8	Support the stable /hierarchy endpoint from MSC2946 (#11329) ... This also makes additional updates where the implementation had drifted from the approved MSC. Unstable endpoints will be removed at a later data.	3 years ago
Eric Eastwood	f1d5c2f269	Split out federated PDU retrieval into a non-cached version (#11242) ... Context: https://github.com/matrix-org/synapse/pull/11114/files#r741643968	3 years ago
reivilibre	75ca0a6168	Annotate `log_function` decorator (#10943) ... Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	3 years ago
Patrick Cloke	32072dcdac	Strip "join_authorised_via_users_server" from join events which do not need it. (#10933) ... This fixes a "Event not signed by authorising server" error when transition room member from join -> join, e.g. when updating a display name or avatar URL for restricted rooms.	3 years ago
Patrick Cloke	d1bf5f7c9d	Strip "join_authorised_via_users_server" from join events which do not need it. (#10933) ... This fixes a "Event not signed by authorising server" error when transition room member from join -> join, e.g. when updating a display name or avatar URL for restricted rooms.	3 years ago
Richard van der Hoff	85551b7a85	Factor out common code for persisting fetched auth events (#10896) ... * Factor more stuff out of `_get_events_and_persist` It turns out that the event-sorting algorithm in `_get_events_and_persist` is also useful in other circumstances. Here we move the current `_auth_and_persist_fetched_events` to `_auth_and_persist_fetched_events_inner`, and then factor the sorting part out to `_auth_and_persist_fetched_events`. * `_get_remote_auth_chain_for_event`: remove redundant `outlier` assignment `get_event_auth` returns events with the outlier flag already set, so this is redundant (though we need to update a test where `get_event_auth` is mocked). * `_get_remote_auth_chain_for_event`: move existing-event tests earlier Move a couple of tests outside the loop. This is a bit inefficient for now, but a future commit will make it better. It should be functionally identical. * `_get_remote_auth_chain_for_event`: use `_auth_and_persist_fetched_events` We can use the same codepath for persisting the events fetched as part of an auth chain as for those fetched individually by `_get_events_and_persist` for building the state at a backwards extremity. * `_get_remote_auth_chain_for_event`: use a dict for efficiency `_auth_and_persist_fetched_events` sorts the events itself, so we no longer need to care about maintaining the ordering from `get_event_auth` (and no longer need to sort by depth in `get_event_auth`). That means that we can use a map, making it easier to filter out events we already have, etc. * changelog * `_auth_and_persist_fetched_events`: improve docstring	3 years ago
Patrick Cloke	5548fe0978	Cache the result of fetching the room hierarchy over federation. (#10647)	3 years ago
Patrick Cloke	31dac7ffee	Do not include stack traces for known exceptions when trying multiple federation destinations. (#10662)	3 years ago
Patrick Cloke	c4cf0c0473	Attempt to pull from the legacy spaces summary API over federation. (#10583) ... If the new /hierarchy API does not exist on all destinations, fallback to querying the /spaces API and translating the results. This is a backwards compatibility hack since not all of the federated homeservers will update at the same time.	3 years ago
Patrick Cloke	7de445161f	Support federation in the new spaces summary API (MSC2946). (#10569)	3 years ago
Erik Johnston	60f0534b6e	Fix exceptions in logs when failing to get remote room list (#10541)	3 years ago
Patrick Cloke	3b354faad0	Refactoring before implementing the updated spaces summary. (#10527) ... This should have no user-visible changes, but refactors some pieces of the SpaceSummaryHandler before adding support for the updated MSC2946.	3 years ago
Patrick Cloke	3a541a7daa	Improve failover logic for MSC3083 restricted rooms. (#10447) ... If the federation client receives an M_UNABLE_TO_AUTHORISE_JOIN or M_UNABLE_TO_GRANT_JOIN response it will attempt another server before giving up completely.	3 years ago
Patrick Cloke	228decfce1	Update the MSC3083 support to verify if joins are from an authorized server. (#10254)	3 years ago
Jonathan de Jong	bf72d10dbf	Use inline type hints in various other places (in `synapse/`) (#10380)	3 years ago
Patrick Cloke	9e5ab6dd58	Remove the experimental flag for knocking and use stable prefixes / endpoints. (#10167) ... * Room version 7 for knocking. * Stable prefixes and endpoints (both client and federation) for knocking. * Removes the experimental configuration flag.	3 years ago
Sorunome	d936371b69	Implement knock feature (#6739) ... This PR aims to implement the knock feature as proposed in https://github.com/matrix-org/matrix-doc/pull/2403 Signed-off-by: Sorunome mail@sorunome.de Signed-off-by: Andrew Morgan andrewm@element.io	4 years ago
Erik Johnston	c842c581ed	When joining a remote room limit the number of events we concurrently check signatures/hashes for (#10117) ... If we do hundreds of thousands at once the memory overhead can easily reach 500+ MB.	4 years ago
Erik Johnston	64887f06fc	Use ijson to parse the response to `/send_join`, reducing memory usage. (#9958) ... Instead of parsing the full response to `/send_join` into Python objects (which can be huge for large rooms) and *then* parsing that into events, we instead use ijson to stream parse the response directly into `EventBase` objects.	4 years ago
Patrick Cloke	1350b053da	Pass errors back to the client when trying multiple federation destinations. (#9868) ... This ensures that something like an auth error (403) will be returned to the requester instead of attempting to try more servers, which will likely result in the same error, and then passing back a generic 400 error.	4 years ago
Jonathan de Jong	4b965c862d	Remove redundant "coding: utf-8" lines (#9786) ... Part of #9744 Removes all redundant `# -*- coding: utf-8 -*-` lines from files, as python 3 automatically reads source code as utf-8 now. `Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>`	4 years ago
Patrick Cloke	44bb881096	Add type hints to expiring cache. (#9730)	4 years ago
Richard van der Hoff	c73cc2c2ad	Spaces summary: call out to other servers (#9653) ... When we hit an unknown room in the space tree, see if there are other servers that we might be able to poll to get the data. Fixes: #9447	4 years ago
Patrick Cloke	b7748d3c00	Import HomeServer from the proper module. (#9665)	4 years ago
Eric Eastwood	0a00b7ff14	Update black, and run auto formatting over the codebase (#9381) ... - Update black version to the latest - Run black auto formatting over the codebase - Run autoformatting according to [`docs/code_style.md `](80d6dc9783/docs/code_style.md) - Update `code_style.md` docs around installing black to use the correct version	4 years ago
Erik Johnston	f2c1560eca	Ratelimit invites by room and target user (#9258)	4 years ago
Patrick Cloke	620ecf13b0	Various improvements to the federation client. (#9129) ... * Type hints for `FederationClient`. * Using `async` functions instead of returning `Awaitable` instances.	4 years ago
Richard van der Hoff	2649d545a5	Mypy fixes for `synapse.handlers.federation` (#8422) ... For some reason, an apparently unrelated PR upset mypy about this module. Here are a number of little fixes.	4 years ago
Patrick Cloke	8a4a4186de	Simplify super() calls to Python 3 syntax. (#8344) ... This converts calls like super(Foo, self) -> super(). Generated with: sed -i "" -Ee 's/super\([^\(]+\)/super()/g' **/*.py	4 years ago
Andrew Morgan	27c1abc7b8	Use _check_sigs_and_hash_and_fetch to validate backfill requests (#8350) ... This is a bit of a hack, as `_check_sigs_and_hash_and_fetch` is intended for attempting to pull an event from the database/(re)pull it from the server that originally sent the event if checking the signature of the event fails. During backfill we *know* that we won't have the event in our database, however it is still useful to be able to query the original sending server as the server we're backfilling from may be acting maliciously. The main benefit and reason for this change however is that `_check_sigs_and_hash_and_fetch` will drop an event during backfill if it cannot be successfully validated, whereas the current code will simply fail the backfill request - resulting in the client's /messages request silently being dropped. This is a quick patch to fix backfilling rooms that contain malformed events. A better implementation in planned in future.	4 years ago
Erik Johnston	c570f24acc	Don't assume that an event has an origin field ... This fixes #8319.	4 years ago
Patrick Cloke	c978f6c451	Convert federation client to async/await. (#7975)	4 years ago
Patrick Cloke	00e57b755c	Convert synapse.app to async/await. (#7868)	4 years ago
Patrick Cloke	38e1fac886	Fix some spelling mistakes / typos. (#7811)	4 years ago
Richard van der Hoff	67593b1728	Add `HomeServer.signing_key` property (#7805) ... ... instead of duplicating `config.signing_key[0]` everywhere	4 years ago
Andrew Morgan	6b22921b19	async/await is_server_admin (#7363)	5 years ago
Andrew Morgan	2e8955f4a6	Further improvements to requesting the public rooms list on a homeserver which has it set to private (#7368)	5 years ago
Patrick Cloke	c2db6599c8	Fix a bug in the federation API which could cause occasional "Failed to get PDU" errors (#7089).	5 years ago
Patrick Cloke	7581d30e9f	Remove unused federation endpoint (`query_auth`) (#7026)	5 years ago
Patrick Cloke	12d4259000	Add some type annotations to the federation base & client classes (#6995)	5 years ago
Richard van der Hoff	928edef979	Pass room_version into `event_from_pdu_json` ... It's called from all over the shop, so this one's a bit messy.	5 years ago
Richard van der Hoff	b0c8bdd49d	pass room version into FederationClient.send_join (#6854) ... ... which allows us to sanity-check the create event.	5 years ago
Richard van der Hoff	ee0525b2b2	Simplify `room_version` handling in `FederationClient.send_invite`	5 years ago
Richard van der Hoff	f84700fba8	Pass room version object into `FederationClient.get_pdu`	5 years ago
Richard van der Hoff	6bbd890f05	make FederationClient._do_send_invite async	5 years ago
Richard van der Hoff	146fec0820	Apply suggestions from code review ... Co-Authored-By: Erik Johnston <erik@matrix.org>	5 years ago