49 Commits (6c1f7c722f0baade9aecf41f600fcced670c4fcb)

Author	SHA1	Message	Date
Brendan Abolivier	8120a238a4	Refactor a bit	5 years ago
Brendan Abolivier	37a9873f63	Also don't fail on aliases events in this case	5 years ago
Brendan Abolivier	e38c44b418	Lint	5 years ago
Brendan Abolivier	2dce68c651	Also don't filter out events sent by ignored users when checking state visibility	5 years ago
Brendan Abolivier	9c0775e86a	Fix condition	5 years ago
Brendan Abolivier	69ce55c510	Don't filter out dummy events when we're checking the visibility of state	5 years ago
Brendan Abolivier	31a2116331	Hide extremities dummy events from clients	5 years ago
Patrick Cloke	509e381afa	Clarify list/set/dict/tuple comprehensions and enforce via flake8 (#6957) ... Ensure good comprehension hygiene using flake8-comprehensions.	5 years ago
Matthew Hodgson	8e64c5a24c	filter out m.room.aliases from the CS API until a better solution is specced (#6878) ... We're in the middle of properly mitigating spam caused by malicious aliases being added to a room. However, until this work fully lands, we temporarily filter out all m.room.aliases events from /sync and /messages on the CS API, to remove abusive aliases. This is considered acceptable as m.room.aliases events were never a reliable record of the given alias->id mapping and were purely informational, and in their current state do more harm than good.	5 years ago
Brendan Abolivier	ac87ddb242	Update the documentation of the filtering function	5 years ago
Brendan Abolivier	78ec11c085	Lint	5 years ago
Brendan Abolivier	708cef88cf	Discard retention policies when retrieving state ... Purge jobs don't delete the latest event in a room in order to keep the forward extremity and not break the room. On the other hand, get_state_events, when given an at_token argument calls filter_events_for_client to know if the user can see the event that matches that (sync) token. That function uses the retention policies of the events it's given to filter out those that are too old from a client's view. Some clients, such as Riot, when loading a room, request the list of members for the latest sync token it knows about, and get confused to the point of refusing to send any message if the server tells it that it can't get that information. This can happen very easily with the message retention feature turned on and a room with low activity so that the last event sent becomes too old according to the room's retention policy. An easy and clean fix for that issue is to discard the room's retention policies when retrieving state.	5 years ago
Brendan Abolivier	f03c9d3444	Don't apply retention policy based filtering on state events ... As per MSC1763, 'Retention is only considered for non-state events.', so don't filter out state events based on the room's retention policy.	5 years ago
Brendan Abolivier	09957ce0e4	Implement per-room message retention policies	5 years ago
Erik Johnston	69f0054ce6	Port to use state storage	5 years ago
Amber Brown	4806651744	Replace returnValue with return (#5736)	5 years ago
Amber Brown	32e7c9e7f2	Run Black. (#5482)	6 years ago
Erik Johnston	a9de04be72	Implement soft fail	6 years ago
Erik Johnston	aa06d26ae0	clarify comments	6 years ago
Erik Johnston	0d2d046709	Fix missing null guard	6 years ago
Erik Johnston	d1523aed6b	Only check history visibility when filtering ... When filtering events to send to server we check more than just history visibility. However when deciding whether to backfill or not we only care about the history visibility.	6 years ago
Erik Johnston	71b625d808	Stop backpaginating when events not visible	6 years ago
Erik Johnston	cb53ce9d64	Refactor state group lookup to reduce DB hits (#4011) ... Currently when fetching state groups from the data store we make two hits two the database: once for members and once for non-members (unless request is filtered to one or the other). This adds needless load to the datbase, so this PR refactors the lookup to make only a single database hit.	6 years ago
Ivan Shapovalov	fb216a22db	synapse/visibility.py: fix SyntaxError on py3.7	6 years ago
Richard van der Hoff	495975e231	Optimisation for filter_events_for_server ... We're better off hashing just the event_id than the whole ((type, state_key), event_id) tuple - so use a dict instead of a set. Also, iteritems > items.	6 years ago
Richard van der Hoff	dae6dc1e77	Remove redundant checks on room forgottenness ... Fixes #3550	6 years ago
Amber Brown	3132b89f12	Make the rest of the .iterwhatever go away (#3562)	6 years ago
Richard van der Hoff	79eb339c66	add a comment	6 years ago
Richard van der Hoff	d897be6a98	Fix visibility of events from erased users over federation	6 years ago
Richard van der Hoff	94440ae994	fix imports	6 years ago
Richard van der Hoff	2172a3d8cb	add a comment	6 years ago
Richard van der Hoff	09e29fb58b	Attempt to make _filter_events_for_server more efficient	6 years ago
Richard van der Hoff	ea69d35651	Move filter_events_for_server out of FederationHandler ... for easier unit testing.	6 years ago
Amber Brown	49af402019	run isort	6 years ago
Erik Johnston	244484bf3c	Revert "Revert "Merge pull request #3431 from matrix-org/rav/erasure_visibility"" ... This reverts commit 1d009013b3.	7 years ago
Richard van der Hoff	1d009013b3	Revert "Merge pull request #3431 from matrix-org/rav/erasure_visibility" ... This reverts commit ce0d911156, reversing changes made to b4a5d767a9.	7 years ago
Richard van der Hoff	b6faef2ad7	Filter out erased messages ... Redact any messges sent by erased users.	7 years ago
Richard van der Hoff	bd348f0af6	remove dead filter_events_for_clients ... This is only used by filter_events_for_client, so we can simplify the whole thing by just doing one user at a time, and removing a dead storage function to boot.	7 years ago
Richard van der Hoff	7e6fa29cb5	Remove preserve_context_over_{fn, deferred} ... Both of these functions ae known to leak logcontexts. Replace the remaining calls to them and kill them off.	7 years ago
Erik Johnston	2d1b7955ae	Don't filter out current state events from timeline	7 years ago
Erik Johnston	f502b0dea1	Perf: Don't filter events for push ... We know the users are joined and we can explicitly check for if they are ignoring the user, so lets do that.	7 years ago
Erik Johnston	78f306a6f7	Revert "Speed up filtering of a single event in push" ... This reverts commit 421fdf7460.	8 years ago
Erik Johnston	421fdf7460	Speed up filtering of a single event in push	8 years ago
Erik Johnston	86780a8bc3	Don't convert to deferreds when not necessary	8 years ago
David Baker	e1f1784f99	Fix rejection of invites not reaching sync ... Always allow the user to see their own leave events, otherwise they won't see the event if they reject an invite for a room whose history visibility is set such that they cannot see events before joining.	8 years ago
David Baker	86e865d7d2	Oops, remove unintentional change	8 years ago
David Baker	a2dfab12c5	Fix token request for addition of phone numbers	8 years ago
Erik Johnston	a3dc1e9cbe	Replace context.current_state with context.current_state_ids	8 years ago
Erik Johnston	9219139351	Preserve some logcontexts	8 years ago
Mark Haines	7e23476814	move filter_events_for_client out of base handler	9 years ago