watcha-synapse

Commit Graph

Author	SHA1	Message	Date
Richard van der Hoff	e24ff8ebe3	Remove `HomeServer.get_datastore()` (#12031 ) The presence of this method was confusing, and mostly present for backwards compatibility. Let's get rid of it. Part of #11733	3 years ago
Shay	70ce9aea71	Strip unauthorized fields from `unsigned` object in events received over federation (#11530 ) * add some tests to verify we are stripping unauthorized fields out of unsigned * add function to strip unauthorized fields from the unsigned object of event * newsfragment * update newsfragment number * add check to on_send_membership_event * refactor tests * fix lint error * slightly refactor tests and add some comments * slight refactor * refactor tests * fix import error * slight refactor * remove unsigned filtration code from synapse/handlers/federation_event.py * lint * move unsigned filtering code to event base * refactor tests * update newsfragment * requested changes * remove unused retun values	3 years ago
Richard van der Hoff	73cbb284b9	Remove redundant parameters on `_check_event_auth` (#11292 ) as of #11012, these parameters are unused.	3 years ago
Richard van der Hoff	2622b28c5c	Inline `_check_event_auth` for outliers (#10926 ) * Inline `_check_event_auth` for outliers When we are persisting an outlier, most of `_check_event_auth` is redundant: * `_update_auth_events_and_context_for_auth` does nothing, because the `input_auth_events` are (now) exactly the event's auth_events, which means that `missing_auth` is empty. * we don't care about soft-fail, kicking guest users or `send_on_behalf_of` for outliers ... so the only thing that matters is the auth itself, so let's just do that. * `_auth_and_persist_fetched_events_inner`: de-async `prep` `prep` no longer calls any `async` methods, so let's make it synchronous. * Simplify `_check_event_auth` We no longer need to support outliers here, which makes things rather simpler. * changelog * lint	3 years ago
Richard van der Hoff	abedf7d77f	Get rid of `_auth_and_persist_event` (#10781 ) This is only called in two places, and the code seems much clearer without it.	3 years ago
Richard van der Hoff	1800aabfc2	Split `FederationHandler` in half (#10692 ) The idea here is to take anything to do with incoming events and move it out to a separate handler, as a way of making FederationHandler smaller.	3 years ago
Richard van der Hoff	e81d62009e	Split `on_receive_pdu` in half (#10640 ) Here we split on_receive_pdu into two functions (on_receive_pdu and process_pulled_event), rather than having both cases in the same method. There's a tiny bit of overlap, but not that much.	3 years ago
Richard van der Hoff	1bebc0b78c	Clean up federation event auth code (#10539 ) * drop old-room hack pretty sure we don't need this any more. * Remove incorrect comment about modifying `context` It doesn't look like the supplied context is ever modified. * Stop `_auth_and_persist_event` modifying its parameters This is only called in three places. Two of them don't pass `auth_events`, and the third doesn't use the dict after passing it in, so this should be non-functional. * Stop `_check_event_auth` modifying its parameters `_check_event_auth` is only called in three places. `on_send_membership_event` doesn't pass an `auth_events`, and `prep` and `_auth_and_persist_event` do not use the map after passing it in. * Stop `_update_auth_events_and_context_for_auth` modifying its parameters Return the updated auth event dict, rather than modifying the parameter. This is only called from `_check_event_auth`. * Improve documentation on `_auth_and_persist_event` Rename `auth_events` parameter to better reflect what it contains. * Improve documentation on `_NewEventInfo` * Improve documentation on `_check_event_auth` rename `auth_events` parameter to better describe what it contains * changelog	3 years ago
Patrick Cloke	b076bc276e	Always use the name as the log ID. (#9829 ) As far as I can tell our logging contexts are meant to log the request ID, or sometimes the request ID followed by a suffix (this is generally stored in the name field of LoggingContext). There's also code to log the name@memory location, but I'm not sure this is ever used. This simplifies the code paths to require every logging context to have a name and use that in logging. For sub-contexts (created via nested_logging_contexts, defer_to_threadpool, Measure) we use the current context's str (which becomes their name or the string "sentinel") and then potentially modify that (e.g. add a suffix).	4 years ago
Patrick Cloke	936e69825a	Separate creating an event context from persisting it in the federation handler (#9800 ) This refactoring allows adding logic that uses the event context before persisting it.	4 years ago
Patrick Cloke	e8816c6ace	Revert "Check for space membership during a remote join of a restricted room. (#9763 )" This reverts commit `cc51aaaa7a`. The PR was prematurely merged and not yet approved.	4 years ago
Patrick Cloke	cc51aaaa7a	Check for space membership during a remote join of a restricted room. (#9763 ) When receiving a /send_join request for a room with join rules set to 'restricted', check if the user is a member of the spaces defined in the 'allow' key of the join rules. This only applies to an experimental room version, as defined in MSC3083.	4 years ago
Jonathan de Jong	4b965c862d	Remove redundant "coding: utf-8" lines (#9786 ) Part of #9744 Removes all redundant `# -- coding: utf-8 --` lines from files, as python 3 automatically reads source code as utf-8 now. `Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>`	4 years ago
Patrick Cloke	0b3112123d	Use mock from the stdlib. (#9772 )	4 years ago
Patrick Cloke	1619802228	Various clean-ups to the logging context code (#8935 )	4 years ago
Patrick Cloke	30fba62108	Apply an IP range blacklist to push and key revocation requests. (#8821 ) Replaces the `federation_ip_range_blacklist` configuration setting with an `ip_range_blacklist` setting with wider scope. It now applies to: * Federation * Identity servers * Push notifications * Checking key validitity for third-party invite events The old `federation_ip_range_blacklist` setting is still honored if present, but with reduced scope (it only applies to federation and identity servers).	4 years ago
Erik Johnston	2ac908f377	Don't instansiate Requester directly (#8614 )	4 years ago
Patrick Cloke	c9c0ad5e20	Remove the deprecated Handlers object (#8494 ) All handlers now available via get_*_handler() methods on the HomeServer.	4 years ago
Patrick Cloke	4a739c73b4	Convert simple_update* and simple_select* to async (#8173 )	4 years ago
Patrick Cloke	ac77cdb64e	Add a shadow-banned flag to users. (#8092 )	4 years ago
Patrick Cloke	fbe930dad2	Convert the roommember database to async/await. (#8070 )	4 years ago
Patrick Cloke	c978f6c451	Convert federation client to async/await. (#7975 )	4 years ago
Patrick Cloke	6b3ac3b8cd	Convert device handler to async/await (#7871 )	4 years ago
Andrew Morgan	fcd6961441	Add option to enable encryption by default for new rooms (#7639 ) Fixes https://github.com/matrix-org/synapse/issues/2431 Adds config option `encryption_enabled_by_default_for_room_type`, which determines whether encryption should be enabled with the default encryption algorithm in private or public rooms upon creation. Whether the room is private or public is decided based upon the room creation preset that is used. Part of this PR is also pulling out all of the individual instances of `m.megolm.v1.aes-sha2` into a constant variable to eliminate typos ala https://github.com/matrix-org/synapse/pull/7637 Based on #7637	5 years ago
Brendan Abolivier	33c39ab93c	Process cross-signing keys when resyncing device lists (#7594 ) It looks like `user_device_resync` was ignoring cross-signing keys from the results received from the remote server. This patch fixes this, by processing these keys using the same process `_handle_signing_key_updates` does (and effectively factor that part out of that function).	5 years ago
Erik Johnston	1531b214fc	Add ability to wait for replication streams (#7542 ) The idea here is that if an instance persists an event via the replication HTTP API it can return before we receive that event over replication, which can lead to races where code assumes that persisting an event immediately updates various caches (e.g. current state of the room). Most of Synapse doesn't hit such races, so we don't do the waiting automagically, instead we do so where necessary to avoid unnecessary delays. We may decide to change our minds here if it turns out there are a lot of subtle races going on. People probably want to look at this commit by commit.	5 years ago
Brendan Abolivier	d1ae1015ec	Retry to sync out of sync device lists (#7453 ) When a call to `user_device_resync` fails, we don't currently mark the remote user's device list as out of sync, nor do we retry to sync it. https://github.com/matrix-org/synapse/pull/6776 introduced some code infrastructure to mark device lists as stale/out of sync. This commit uses that code infrastructure to mark device lists as out of sync if processing an incoming device list update makes the device handler realise that the device list is out of sync, but we can't resync right now. It also adds a looping call to retry all failed resync every 30s. This shouldn't cause too much spam in the logs as this commit also removes the "Failed to handle device list update for..." warning logs when catching `NotRetryingDestination`. Fixes #7418	5 years ago
Andrew Morgan	6b22921b19	async/await is_server_admin (#7363 )	5 years ago
Richard van der Hoff	799001f2c0	Add a `make_event_from_dict` method (#6858 ) ... and use it in places where it's trivial to do so. This will make it easier to pass room versions into the FrozenEvent constructors.	5 years ago
Richard van der Hoff	e77237b935	convert to async: FederationHandler.on_receive_pdu and associated functions: * on_receive_pdu * handle_queued_pdus * get_missing_events_for_pdu	5 years ago
Erik Johnston	852f80d8a6	Fixup tests	5 years ago
Richard van der Hoff	c6516adbe0	Factor out an _AsyncEventContextImpl (#6298 ) The intention here is to make it clearer which fields we can expect to be populated when: notably, that the _event_type etc aren't used for the synchronous impl of EventContext.	5 years ago
Erik Johnston	a8d16f6c00	Review comments	5 years ago
Amber Brown	463b072b12	Move logging utilities out of the side drawer of util/ and into logging/ (#5606 )	5 years ago
Amber Brown	b36c82576e	Run Black on the tests again (#5170 )	6 years ago
Richard van der Hoff	884a561447	Fix some tests which leaked logcontexts	6 years ago
Erik Johnston	b86d05a279	Clean up event accesses and tests This is in preparation to refactor FrozenEvent to support different event formats for different room versions	6 years ago
Richard van der Hoff	484a9b8c81	Remove redundant, failing, test This test didn't do what it claimed to do, and what it claimed to do was the same as test_cant_hide_direct_ancestors anyway. This stuff is tested by sytest anyway.	6 years ago
Richard van der Hoff	4a15a3e4d5	Include eventid in log lines when processing incoming federation transactions (#3959 ) when processing incoming transactions, it can be hard to see what's going on, because we process a bunch of stuff in parallel, and because we may end up recursively working our way through a chain of three or four events. This commit creates a way to use logcontexts to add the relevant event ids to the log lines.	6 years ago
Amber Brown	99dd975dae	Run tests under PostgreSQL (#3423 )	6 years ago
Amber Brown	3132b89f12	Make the rest of the .iterwhatever go away (#3562 )	6 years ago
Amber Brown	49af402019	run isort	6 years ago
Amber Brown	f03a5d1a17	pep8	7 years ago
Amber Brown	35cc3e8b14	stylistic cleanup	7 years ago
Amber Brown	8d62baa48c	cleanups	7 years ago
Amber Brown	77078d6c8e	handle federation not telling us about prev_events	7 years ago

47 Commits (7317b0be82e31d7b41be64e2fea92aad428283d8)