watcha-synapse

Commit Graph

Author	SHA1	Message	Date
Aaron Raimist	8238b55e08	Update description of server_name config option (#8415 )	4 years ago
Will Hunt	c2bdf040aa	Discard an empty upload_name before persisting an uploaded file (#7905 )	4 years ago
Erik Johnston	b1433bf231	Don't table scan events on worker startup (#8419 ) * Fix table scan of events on worker startup. This happened because we assumed "new" writers had an initial stream position of 0, so the replication code tried to fetch all events written by the instance between 0 and the current position. Instead, set the initial position of new writers to the current persisted up to position, on the assumption that new writers won't have written anything before that point. * Consider old writers coming back as "new". Otherwise we'd try and fetch entries between the old stale token and the current position, even though it won't have written any rows. Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	4 years ago
Richard van der Hoff	2649d545a5	Mypy fixes for `synapse.handlers.federation` (#8422 ) For some reason, an apparently unrelated PR upset mypy about this module. Here are a number of little fixes.	4 years ago
Will Hunt	8676d8ab2e	Filter out appservices from mau count (#8404 ) This is an attempt to fix #8403.	4 years ago
Andrew Morgan	1c6b8752b8	Only assert valid next_link params when provided (#8417 ) Broken in https://github.com/matrix-org/synapse/pull/8275 and has yet to be put in a release. Fixes https://github.com/matrix-org/synapse/issues/8418. `next_link` is an optional parameter. However, we were checking whether the `next_link` param was valid, even if it wasn't provided. In that case, `next_link` was `None`, which would clearly not be a valid URL. This would prevent password reset and other operations if `next_link` was not provided, and the `next_link_domain_whitelist` config option was set.	4 years ago
Richard van der Hoff	866c84da8d	Add metrics to track success/otherwise of replication requests (#8406 ) One hope is that this might provide some insights into #3365.	4 years ago
Richard van der Hoff	1c262431f9	Fix handling of connection timeouts in outgoing http requests (#8400 ) * Remove `on_timeout_cancel` from `timeout_deferred` The `on_timeout_cancel` param to `timeout_deferred` wasn't always called on a timeout (in particular if the canceller raised an exception), so it was unreliable. It was also only used in one place, and to be honest it's easier to do what it does a different way. * Fix handling of connection timeouts in outgoing http requests Turns out that if we get a timeout during connection, then a different exception is raised, which wasn't always handled correctly. To fix it, catch the exception in SimpleHttpClient and turn it into a RequestTimedOutError (which is already a documented exception). Also add a description to RequestTimedOutError so that we can see which stage it failed at. * Fix incorrect handling of timeouts reading federation responses This was trapping the wrong sort of TimeoutError, so was never being hit. The effect was relatively minor, but we should fix this so that it does the expected thing. * Fix inconsistent handling of `timeout` param between methods `get_json`, `put_json` and `delete_json` were applying a different timeout to the response body to `post_json`; bring them in line and test. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>	4 years ago
Andrew Morgan	d4605d1f16	Don't check whether a 3pid is allowed to register during password reset This endpoint should only deal with emails that have already been approved, and are attached with user's account. There's no need to re-check them here.	4 years ago
Erik Johnston	bd380d942f	Add checks for postgres sequence consistency (#8402 )	4 years ago
Richard van der Hoff	5e3ca12b15	Create a mechanism for marking tests "logcontext clean" (#8399 )	4 years ago
Richard van der Hoff	450ec48445	A pair of tiny cleanups in the federation request code. (#8401 )	4 years ago
Matthew Hodgson	4b3a1faa08	typo	4 years ago
Patrick Cloke	31acc5c309	Escape the error description on the sso_error template. (#8405 )	4 years ago
Richard van der Hoff	fec6f9ac17	Fix occasional "Re-starting finished log context" from keyring (#8398 ) * Fix test_verify_json_objects_for_server_awaits_previous_requests It turns out that this wasn't really testing what it thought it was testing (in particular, `check_context` was turning failures into success, which was making the tests pass even though it wasn't clear they should have been. It was also somewhat overcomplex - we can test what it was trying to test without mocking out perspectives servers. * Fix warnings about finished logcontexts in the keyring We need to make sure that we finish the key fetching magic before we run the verifying code, to ensure that we don't mess up our logcontexts.	4 years ago
Tdxdxoz	abd04b6af0	Allow existing users to login via OpenID Connect. (#8345 ) Co-authored-by: Benjamin Koch <bbbsnowball@gmail.com> This adds configuration flags that will match a user to pre-existing users when logging in via OpenID Connect. This is useful when switching to an existing SSO system.	4 years ago
Erik Johnston	3e87d79e1c	Fix schema delta for servers that have not backfilled (#8396 ) Fixes #8395.	4 years ago
Erik Johnston	f112cfe5bb	Fix MultiWriteIdGenerator's handling of restarts. (#8374 ) On startup `MultiWriteIdGenerator` fetches the maximum stream ID for each instance from the table and uses that as its initial "current position" for each writer. This is problematic as a) it involves either a scan of events table or an index (neither of which is ideal), and b) if rows are being persisted out of order elsewhere while the process restarts then using the maximum stream ID is not correct. This could theoretically lead to race conditions where e.g. events that are persisted out of order are not sent down sync streams. We fix this by creating a new table that tracks the current positions of each writer to the stream, and update it each time we finish persisting a new entry. This is a relatively small overhead when persisting events. However for the cache invalidation stream this is a much bigger relative overhead, so instead we note that for invalidation we don't actually care about reliability over restarts (as there's no caches to invalidate) and simply don't bother reading and writing to the new table in that particular case.	4 years ago
Andrew Morgan	920dd1083e	1.20.1	4 years ago
Andrew Morgan	3f4a2a7064	Hotfix: disable autoescape by default when rendering Jinja2 templates (#8394 ) #8037 changed the default `autoescape` option when rendering Jinja2 templates from `False` to `True`. This caused some bugs, noticeably around redirect URLs being escaped in SAML2 auth confirmation templates, causing those URLs to break for users. This change returns the previous behaviour as it stood. We may want to look at each template individually and see whether autoescaping is a good idea at some point, but for now lets just fix the breakage.	4 years ago
Richard van der Hoff	11c9e17738	Add type annotations to SimpleHttpClient (#8372 )	4 years ago
Erik Johnston	ac11fcbbb8	Add EventStreamPosition type (#8388 ) The idea is to remove some of the places we pass around `int`, where it can represent one of two things: 1. the position of an event in the stream; or 2. a token that partitions the stream, used as part of the stream tokens. The valid operations are then: 1. did a position happen before or after a token; 2. get all events that happened before or after a token; and 3. get all events between two tokens. (Note that we don't want to allow other operations as we want to change the tokens to be vector clocks rather than simple ints)	4 years ago
Richard van der Hoff	2983049a77	Factor out `_send_dummy_event_for_room` (#8370 ) this makes it possible to use from the manhole, and seems cleaner anyway.	4 years ago
Richard van der Hoff	91c60f3042	Improve logging of state resolution (#8371 ) I'd like to get a better insight into what we are doing with respect to state res. The list of state groups we are resolving across should be short (if it isn't, that's a massive problem in itself), so it should be fine to log it in ite entiretly. I've done some grepping and found approximately zero cases in which the "shortcut" code delivered the result, so I've ripped that out too.	4 years ago
Richard van der Hoff	302dc89f6a	Fix bug which caused failure on join with malformed membership events (#8385 )	4 years ago
Erik Johnston	cbabb312e0	Use `async with` for ID gens (#8383 ) This will allow us to hit the DB after we've finished using the generated stream ID.	4 years ago
Mathieu Velten	916bb9d0d1	Don't push if an user account has expired (#8353 )	4 years ago
Patrick Cloke	bbde4038df	Do not check lint/test dependencies at runtime. (#8377 ) moves non-runtime dependencies out of synapse.python_dependencies (test and lint)	4 years ago
Andrew Morgan	4325be1a52	Fix missing null character check on guest_access room state When updating room_stats_state, we try to check for null bytes slipping in to the content for state events. It turns out we had added guest_access as a field to room_stats_state without including it in the null byte check. Lo and behold, a null byte in a m.room.guest_access event then breaks room_stats_state updates. This PR adds the check for guest_access. A further PR will improve this function so that this hopefully does not happen again in future.	4 years ago
Dirk Klimpel	8998217540	Fixed a bug with reactivating users with the admin API (#8362 ) Fixes: #8359 Trying to reactivate a user with the admin API (`PUT /_synapse/admin/v2/users/<user_name>`) causes an internal server error. Seems to be a regression in #8033.	4 years ago
Dirk Klimpel	4da01f9c61	Admin API for reported events (#8217 ) Add an admin API to read entries of table `event_reports`. API: `GET /_synapse/admin/v1/event_reports`	4 years ago
Andrew Morgan	55bb5fda33	1.20.0	4 years ago
Dionysis Grigoropoulos	37ca5924bd	Create function to check for long names in devices (#8364 ) * Create a new function to verify that the length of a device name is under a certain threshold. * Refactor old code and tests to use said function. * Verify device name length during registration of device * Add a test for the above Signed-off-by: Dionysis Grigoropoulos <dgrig@erethon.com>	4 years ago
Richard van der Hoff	4f3096d866	Add a comment re #1691	4 years ago
Patrick Cloke	babc027543	Fix a bad merge from release-v1.20.0. (#8354 )	4 years ago
Patrick Cloke	d5f7182ba1	1.20.0rc5	4 years ago
Dirk Klimpel	d688b4bafc	Admin API for querying rooms where a user is a member (#8306 ) Add a new admin API `GET /_synapse/admin/v1/users/<user_id>/joined_rooms` to list all rooms where a user is a member.	4 years ago
Andrew Morgan	5b70acb44c	1.19.3	4 years ago
reivilibre	36efbcaf51	Catch-up after Federation Outage (bonus): Catch-up on Synapse Startup (#8322 ) Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Fix _set_destination_retry_timings This came about because the code assumed that retry_interval could not be NULL — which has been challenged by catch-up.	4 years ago
Patrick Cloke	8a4a4186de	Simplify super() calls to Python 3 syntax. (#8344 ) This converts calls like super(Foo, self) -> super(). Generated with: sed -i "" -Ee 's/super\([^\(]+\)/super()/g' */.py	4 years ago
Will Hunt	68c7a6936f	Allow appservice users to /login (#8320 ) Add ability for ASes to /login using the `uk.half-shot.msc2778.login.application_service` login `type`. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	4 years ago
Andrew Morgan	27c1abc7b8	Use _check_sigs_and_hash_and_fetch to validate backfill requests (#8350 ) This is a bit of a hack, as `_check_sigs_and_hash_and_fetch` is intended for attempting to pull an event from the database/(re)pull it from the server that originally sent the event if checking the signature of the event fails. During backfill we know that we won't have the event in our database, however it is still useful to be able to query the original sending server as the server we're backfilling from may be acting maliciously. The main benefit and reason for this change however is that `_check_sigs_and_hash_and_fetch` will drop an event during backfill if it cannot be successfully validated, whereas the current code will simply fail the backfill request - resulting in the client's /messages request silently being dropped. This is a quick patch to fix backfilling rooms that contain malformed events. A better implementation in planned in future.	4 years ago
Erik Johnston	43f2b67e4d	Intelligently select extremities used in backfill. (#8349 ) Instead of just using the most recent extremities let's pick the ones that will give us results that the pagination request cares about, i.e. pick extremities only if they have a smaller depth than the pagination token. This is useful when we fail to backfill an extremity, as we no longer get stuck requesting that same extremity repeatedly.	4 years ago
Patrick Cloke	9db4c1b175	Add flags to /versions about whether new rooms are encrypted by default. (#8343 )	4 years ago
Erik Johnston	14b5b48a22	Fix ratelimiting for federation `/send` requests. (#8342 ) c.f. #8295 for rationale	4 years ago
Jonathan de Jong	efb6b6629c	Move lint dependencies to extras_require (#8330 ) Lint dependencies can now be installed with pip install -e ".[lint]" This should help keep the version in sync between tox and documentation.	4 years ago
Jonathan de Jong	837293c314	Remove obsolete __future__ imports (#8337 )	4 years ago
Patrick Cloke	c3c9732c53	Use admin_patterns for all admin APIs. (#8331 ) This reduces duplication of the admin prefix in regular expressions.	4 years ago
Jonathan de Jong	53284c425e	Fix a potential bug of UnboundLocalError (#8329 ) Replaced with less buggier control flow	4 years ago
Jonathan de Jong	a3f124b821	Switch metaclass initialization to python 3-compatible syntax (#8326 )	4 years ago

1 2 3 4 5 ...

12434 Commits (8238b55e08e8fbd7c7169b72281538a3e34c6488)