19747 Commits (84fac0f814f69645ff1ad564ef8294b31203dc95)

 

All Branches   

Search

Author	SHA1	Message	Date
Dan Callahan	d7141e0b8b	Fix Shellcheck SC2006: Use $(...) notation ... Use $(...) notation instead of legacy backticked `...`. https://github.com/koalaman/shellcheck/wiki/SC2006 Signed-off-by: Dan Callahan <danc@element.io>	3 years ago
Dan Callahan	b5e910521b	Fix Shellcheck SC2129: Consider using {..} >> file ... Consider using { cmd1; cmd2; } >> file instead of individual redirects. https://github.com/koalaman/shellcheck/wiki/SC2129 Signed-off-by: Dan Callahan <danc@element.io>	3 years ago
Dan Callahan	13f084eb58	Fix Shellcheck SC2086: Quote to prevent splitting ... Double quote to prevent globbing and word splitting. https://github.com/koalaman/shellcheck/wiki/SC2086 Signed-off-by: Dan Callahan <danc@element.io>	3 years ago
Dan Callahan	31096132c3	Fix Shellcheck SC2012: Use find instead of ls ... Use find instead of ls to better handle non-alphanumeric filenames. https://github.com/koalaman/shellcheck/wiki/SC2012 Signed-off-by: Dan Callahan <danc@element.io>	3 years ago
Dan Callahan	9d0f9d51d5	Fix Shellcheck SC2016: Single quotes don't expand ... Expressions don't expand in single quotes, use double quotes for that. https://github.com/koalaman/shellcheck/wiki/SC2016 This specifically warned about the '$aregis...' part of the sed script. Which is a relatively obscure use of sed. Splitting this into two commands makes its intent more obvious and avoids contravening Shellcheck's lints. Signed-off-by: Dan Callahan <danc@element.io>	3 years ago
Dan Callahan	bab2bc844c	Fix Shellcheck SC1091: Can't follow file ... Not following: (error message here) https://github.com/koalaman/shellcheck/wiki/SC1091 Signed-off-by: Dan Callahan <danc@element.io>	3 years ago
Dan Callahan	7cf83c0aca	Fix Shellcheck SC1001: Meaningless char escapes ... This \o will be a regular 'o' in this context. https://github.com/koalaman/shellcheck/wiki/SC1001 Signed-off-by: Dan Callahan <danc@element.io>	3 years ago
Dan Callahan	99e698d6ed	Fix Shellcheck SC2089 and SC2090: Quotes in vars ... SC2089: Quotes/backslashes will be treated literally. Use an array. https://github.com/koalaman/shellcheck/wiki/SC2089 SC2090: Quotes/backslashes in this variable will not be respected. https://github.com/koalaman/shellcheck/wiki/SC2090 Putting literal JSON in a variable mistakenly triggers these warnings. Instead of adding ignore directives, this can be avoided by inlining the JSON data into the curl invocation. Since the variable is only used in this one location, inlining is fine. Signed-off-by: Dan Callahan <danc@element.io>	3 years ago
Dan Callahan	dfa6143133	Fix Shellcheck SC2155: Declare + export separately ... Declare and assign separately to avoid masking return values. https://github.com/koalaman/shellcheck/wiki/SC2155 Signed-off-by: Dan Callahan <danc@element.io>	3 years ago
Dan Callahan	6a9d84a676	Fix Shellcheck SC2166: test -a is not well defined ... Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. https://github.com/koalaman/shellcheck/wiki/SC2166 Signed-off-by: Dan Callahan <danc@element.io>	3 years ago
Dan Callahan	6c736fa472	Fix Shellcheck SC2154: variable possibly undefined ... var is referenced but not assigned. https://github.com/koalaman/shellcheck/wiki/SC2154 Signed-off-by: Dan Callahan <danc@element.io>	3 years ago
Dan Callahan	898e3be4c9	Fix Shellcheck SC2064: Use single quotes on traps ... Use single quotes, otherwise this expands now rather than when signalled. https://github.com/koalaman/shellcheck/wiki/SC2064 Signed-off-by: Dan Callahan <danc@element.io>	3 years ago
Dan Callahan	5eb481cd5b	Fix Shellcheck SC2115: Ensure never expands to /* ... Use "${var:?}" to ensure this never expands to /* . https://github.com/koalaman/shellcheck/wiki/SC2115 Signed-off-by: Dan Callahan <danc@element.io>	3 years ago
Dan Callahan	64adbb7b54	Fix Shellcheck SC2046: Quote to prevent word split ... Quote this to prevent word splitting https://www.shellcheck.net/wiki/SC2046 Signed-off-by: Dan Callahan <danc@element.io>	3 years ago
Dan Callahan	12d79ff1b6	Fix Shellcheck SC2164: exit in case cd fails. ... Use `cd ... || exit` in case cd fails. https://github.com/koalaman/shellcheck/wiki/SC2164 Signed-off-by: Dan Callahan <danc@element.io>	3 years ago
Sean Quah	2b82ec425f	Add type hints for most `HomeServer` parameters (#11095)	3 years ago
Jason Robinson	b9ce53e878	Fix synapse.config module "read" command (#11145) ... `synapse.config.__main__` has the possibility to read a config item. This can be used to conveniently also validate the config is valid before trying to start Synapse. The "read" command broke in https://github.com/matrix-org/synapse/pull/10916 as it now requires passing in "server.server_name" for example. Also made the read command optional so one can just call this with just the confirm file reference and get a "Config parses OK" if things are ok. Signed-off-by: Jason Robinson <jasonr@matrix.org> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	3 years ago
Dirk Klimpel	b0f03aeb6a	Add more information what happens when a user is deactivated (#11083)	3 years ago
Patrick Cloke	ba00e20234	Add a thread relation type per MSC3440. (#11088) ... Adds experimental support for MSC3440's `io.element.thread` relation type (and the aggregation for it).	3 years ago
David Robertson	2d91b6256e	Fix adding excluded users to the private room sharing tables when joining a room (#11143) ... * We only need to fetch users in private rooms * Filter out `user_id` at the top * Discard excluded users in the top loop We weren't doing this in the "First, if they're our user" branch so this is a bugfix. * The caller must check that `user_id` is included This is in the docstring. There are two call sites: - one in `_handle_room_publicity_change`, which explicitly checks before calling; - and another in `_handle_room_membership_event`, which returns early if the user is excluded. So this change is safe. * Test joining a private room with an excluded user * Tweak an existing test * Changelog * test docstring * lint	3 years ago
Andrew Morgan	6408372234	Improve docstrings for methods related to sending EDUs to application services (#11138)	3 years ago
Patrick Cloke	0f9adc99ad	Add missing type hints to synapse.crypto. (#11146) ... And require type hints for this module.	3 years ago
Richard van der Hoff	09eff1b3db	fix relative link in docker readme (#11144) ... relative links don't work when it's on dockerhub.	3 years ago
Dirk Klimpel	ef7fe09778	Fix setting a user's external_id via the admin API returns 500 and deletes users existing external mappings if that external ID is already mapped (#11051) ... Fixes #10846	3 years ago
Richard van der Hoff	57501d9194	Update `sign_json` to support inline key config (#11139) ... It's been possible to configure a key inline in the homeserver.yaml since 13bc1e0746. Update `sign_json` to work with this.	3 years ago
Robert Edström	62db603fa0	Consider IP whitelist for identity server resolution (#11120) ... Signed-off-by: Robert Edström <github@legogris.se>	3 years ago
Richard van der Hoff	0930e9ae12	Clean up `_update_auth_events_and_context_for_auth` (#11122) ... Remove some redundant code, and generally simplify.	3 years ago
Aaron R	2c61a318cc	Show error when timestamp in seconds is provided to the /purge_media_cache API (#11101)	3 years ago
Sean Quah	ee2cee5f52	Merge branch 'master' into develop	3 years ago
Travis Ralston	106d99b8cd	Remove false warning about copying the log config to a homeserver.yaml (#11092) ... Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	3 years ago
Brendan Abolivier	78d5896d19	Document the version of Synapse each module callback was introduced in (#11132) ... * Mention callbacks introduced in v1.37.0 According to the documentation introduced in https://github.com/matrix-org/synapse/pull/10062 * Mention callbacks introduced in v1.39.0 According to https://github.com/matrix-org/synapse/pull/10386 and https://github.com/matrix-org/synapse/pull/9884 * Mention callbacks introduced in v1.42.0 According to https://github.com/matrix-org/synapse/pull/10524 * Mention callbacks introduced in v1.44.0 and v1.45.0 As per https://github.com/matrix-org/synapse/pull/10898, https://github.com/matrix-org/synapse/pull/10910 and https://github.com/matrix-org/synapse/pull/10894 * Mention callbacks introduced in v1.46.0 According to https://github.com/matrix-org/synapse/pull/10548	3 years ago
Sean Quah	9b016a0fb4	Remove link to #10947 from changelog	3 years ago
Sean Quah	522489fbcd	1.45.1	3 years ago
Sean Quah	df95d3aec2	Revert change to counting of deactivated users towards the monthly active users limit (#11127) ... Temporarily revert "Add functionality to remove deactivated users from the monthly_active_users table (#10947)". This reverts commit eda8c88b84.	3 years ago
Patrick Cloke	0dd0c40329	Add missing type hints to event fetching. (#11121) ... Updates the event rows returned from the database to be attrs classes instead of dictionaries.	3 years ago
Andrew Morgan	5e0e683541	Fix instances of [example]{.title-ref} in the upgrade notes (#11118)	3 years ago
David Robertson	a6c318735d	Merge branch 'master' into develop	3 years ago
David Robertson	95813ff43c	Be less inconsistent about v1.2.3 versus 1.2.3	3 years ago
David Robertson	a21f8c4b41	Duplicate known issues under 1.45 release	3 years ago
David Robertson	8b1185347a	1.45.0	3 years ago
Dan Callahan	191396f4ba	Reword changelog regarding a suspected regression (#11117) ... Signed-off-by: Dan Callahan <danc@element.io>	3 years ago
Richard van der Hoff	f3efa0036b	Move _persist_auth_tree into FederationEventHandler (#11115) ... This is just a lift-and-shift, because it fits more naturally here. We do rename it to `process_remote_join` at the same time though.	3 years ago
Richard van der Hoff	0170774b19	Rename `_auth_and_persist_fetched_events` (#11116) ... ... to `_auth_and_persist_outliers`, since that reflects its purpose better.	3 years ago
Richard van der Hoff	d85bc9a4a7	Include rejected status when we log events. (#11008) ... If we find ourselves dealing with rejected events, we proably want to know about it. Let's include it in the stringification of the event so that it gets logged.	3 years ago
Patrick Cloke	3ab55d43bd	Add missing type hints to synapse.api. (#11109) ... * Convert UserPresenceState to attrs. * Remove args/kwargs from error classes and explicitly pass msg/errorcode.	3 years ago
Richard van der Hoff	cc33d9eee2	Check auth on received events' auth_events (#11001) ... Currently, when we receive an event whose auth_events differ from those we expect, we state-resolve between the two state sets, and check that the event passes auth based on the resolved state. This means that it's possible for us to accept events which don't pass auth at their declared auth_events (or where the auth events themselves were rejected), leading to problems down the line like #10083. This change means we will: * ignore any events where we cannot find the auth events * reject any events whose auth events were rejected * reject any events which do not pass auth at their declared auth_events. Together with a whole raft of previous work, this is a partial fix to #9595. Fixes #6643. Based on #11009.	3 years ago
Richard van der Hoff	a5d2ea3d08	Check *all* auth events for room id and rejection (#11009) ... This fixes a bug where we would accept an event whose `auth_events` include rejected events, if the rejected event was shadowed by another `auth_event` with same `(type, state_key)`. The approach is to pass a list of auth events into `check_auth_rules_for_event` instead of a dict, which of course means updating the call sites. This is an extension of #10956.	3 years ago
Brendan Abolivier	73743b8ad1	Document Synapse's behaviour when dealing with multiple modules (#11096) ... Document Synapse's behaviour when multiple modules register the same callback/web resource/etc. Co-authored-by: reivilibre <oliverw@matrix.org>	3 years ago
Richard van der Hoff	e8f24b6c35	`_run_push_actions_and_persist_event`: handle no min_depth (#11014) ... Make sure that we correctly handle rooms where we do not yet have a `min_depth`, and also add some comments and logging.	3 years ago
Hillery Shay	7d70582eb0	Fix broken export-data admin command and add a test for it to CI (#11078) ... Fix broken export-data admin command and add a test for it to CI	3 years ago