watcha-synapse

Commit Graph

Author	SHA1	Message	Date
Patrick Cloke	a121507cfe	Adds misc missing type hints (#11953 )	3 years ago
Richard van der Hoff	c3db7a0b59	Tests: replace mocked Authenticator with the real thing (#11913 ) If we prepopulate the test homeserver with a key for a remote homeserver, we can make federation requests to it without having to stub out the authenticator. This has two advantages: * means that what we are testing is closer to reality (ie, we now have complete tests for the incoming-request-authorisation flow) * some tests require that other objects be signed by the remote server (eg, the event in `/send_join`), and doing that would require a whole separate set of mocking out. It's much simpler just to use real keys.	3 years ago
Dirk Klimpel	d36943c4df	Support the stable API endpoint for MSC3283: new settings in `/capabilities` endpoint (#11933 )	3 years ago
Patrick Cloke	df36945ff0	Support pagination tokens from /sync and /messages in the relations API. (#11952 )	3 years ago
Denis Kasak	337f38cac3	Implement a content type allow list for URL previews (#11936 ) This implements an allow list for content types for which Synapse will attempt URL preview. If a URL resolves to a resource with a content type which isn't in the list, the download will terminate immediately. This makes sense given that Synapse would never successfully generate a URL preview for such files in the first place, and helps prevent issues with streaming media servers, such as #8302. Signed-off-by: Denis Kasak dkasak@termina.org.uk	3 years ago
Patrick Cloke	d0e78af35e	Add missing type hints to synapse.replication. (#11938 )	3 years ago
Patrick Cloke	8c94b3abe9	Experimental support to include bundled aggregations in search results (MSC3666) (#11837 )	3 years ago
Brendan Abolivier	0640f8ebaa	Add a callback to allow modules to deny 3PID (#11854 ) Part of the Tchap Synapse mainlining. This allows modules to implement extra logic to figure out whether a given 3PID can be added to the local homeserver. In the Tchap use case, this will allow a Synapse module to interface with the custom endpoint /internal_info.	3 years ago
Andrew Morgan	cf06783d54	Remove optional state of `ApplicationService.is_interested`'s `store` parameter (#11911 )	3 years ago
Andrew Morgan	0c4878caf2	Add a unit test for users receiving their own device list updates (#11909 )	3 years ago
Jonathan de Jong	02632b3504	Stabilise MSC3231 (Token Based Registration) (#11867 )	3 years ago
Patrick Cloke	119edf51eb	Remove support for the webclient listener. (#11895 ) Also remove support for non-HTTP(S) web_client_location.	3 years ago
reivilibre	833247553f	Allow specifying the application service-specific `user_id` parameter in the `join` test helper. (#11616 )	3 years ago
Richard van der Hoff	31b554c297	Fixes for opentracing scopes (#11869 ) `start_active_span` was inconsistent as to whether it would activate the span immediately, or wait for `scope.__enter__` to happen (it depended on whether the current logcontext already had an associated scope). The inconsistency was rather confusing if you were hoping to set up a couple of separate spans before activating either. Looking at the other implementations of opentracing `ScopeManager`s, the intention is that it should be activated immediately, as the name implies. Indeed, the idea is that you don't have to use the scope as a contextmanager at all - you can just call `.close` on the result. Hence, our cleanup has to happen in `.close` rather than `.__exit__`. So, the main change here is to ensure that `start_active_span` does activate the span, and that `scope.close()` does close the scope. We also add some tests, which requires a `tracer` param so that we don't have to rely on the global variable in unit tests.	3 years ago
reivilibre	af795173be	Add a background database update to purge account data for deactivated users. (#11655 )	3 years ago
reivilibre	513913cc6b	Expose the registered device ID from the `register_appservice_user` test helper. (#11615 )	3 years ago
Andrew Morgan	3f72c2a322	Convert `ApplicationServiceTestCase` to use `simple_async_mock` (#11880 )	3 years ago
Andrew Morgan	64ec45fc1b	Send to-device messages to application services (#11215 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	3 years ago
Dirk Klimpel	901b264c0c	Add type hints to `tests/rest/admin` (#11851 )	3 years ago
Brendan Abolivier	bf60da1a60	Configurable limits on avatars (#11846 ) Only allow files which file size and content types match configured limits to be set as avatar. Most of the inspiration from the non-test code comes from matrix-org/synapse-dinsic#19	3 years ago
Brendan Abolivier	2d3bd9aa67	Add a module callback to set username at registration (#11790 ) This is in the context of mainlining the Tchap fork of Synapse. Currently in Tchap usernames are derived from the user's email address (extracted from the UIA results, more specifically the m.login.email.identity step). This change also exports the check_username method from the registration handler as part of the module API, so that a module can check if the username it's trying to generate is correct and doesn't conflict with an existing one, and fallback gracefully if not. Co-authored-by: David Robertson <davidr@element.io>	3 years ago
Patrick Cloke	2897fb6b4f	Improvements to bundling aggregations. (#11815 ) This is some odds and ends found during the review of #11791 and while continuing to work in this code: * Return attrs classes instead of dictionaries from some methods to improve type safety. * Call `get_bundled_aggregations` fewer times. * Adds a missing assertion in the tests. * Do not return empty bundled aggregations for an event (preferring to not include the bundle at all, as the docstring states).	3 years ago
Brendan Abolivier	95b3f952fa	Add a config flag to inhibit `M_USER_IN_USE` during registration (#11743 ) This is mostly motivated by the tchap use case, where usernames are automatically generated from the user's email address (in a way that allows figuring out the email address from the username). Therefore, it's an issue if we respond to requests on /register and /register/available with M_USER_IN_USE, because it can potentially leak email addresses (which include the user's real name and place of work). This commit adds a flag to inhibit the M_USER_IN_USE errors that are raised both by /register/available, and when providing a username early into the registration process. This error will still be raised if the user completes the registration process but the username conflicts. This is particularly useful when using modules (https://github.com/matrix-org/synapse/pull/11790 adds a module callback to set the username of users at registration) or SSO, since they can ensure the username is unique. More context is available in the PR that introduced this behaviour to synapse-dinsic: matrix-org/synapse-dinsic#48 - as well as the issue in the matrix-dinsic repo: matrix-org/matrix-dinsic#476	3 years ago
Dirk Klimpel	6a72c910f1	Add admin API to get a list of federated rooms (#11658 )	3 years ago
Dirk Klimpel	0d6cfea9b8	Add admin API to reset connection timeouts for remote server (#11639 ) * Fix get federation status of destination if no error occured	3 years ago
Patrick Cloke	807efd26ae	Support rendering previews with data: URLs in them (#11767 ) Images which are data URLs will no longer break URL previews and will properly be "downloaded" and thumbnailed.	3 years ago
reivilibre	df54c8485a	Remove account data (including client config, push rules and ignored users) upon user deactivation. (#11621 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	3 years ago
Andrew Morgan	8ff465d206	Fix logic for dropping old events in fed queue (#11806 ) Co-authored-by: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Richard van der Hoff <richard@matrix.org>	3 years ago
Andrew Morgan	dc671d3ea7	Fix logic for dropping old events in fed queue (#11806 ) Co-authored-by: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Richard van der Hoff <richard@matrix.org>	3 years ago
Richard van der Hoff	2aa37a4250	Add `state_key` and `rejection_reason` to `events` (#11792 ) ... and start populating them for new events	3 years ago
Patrick Cloke	7a11509d17	Do not try to serialize raw aggregations dict. (#11791 )	3 years ago
Patrick Cloke	b784299cbc	Do not try to serialize raw aggregations dict. (#11791 )	3 years ago
Richard van der Hoff	9f2016e96e	Drop unused table `public_room_list_stream`. (#11795 ) This is a follow-up to #10565.	3 years ago
reivilibre	4c2096599c	Make the `get_global_account_data_by_type_for_user` cache be a tree-cache whose key is prefixed with the user ID (#11788 )	3 years ago
Brendan Abolivier	bfe6d5553a	Correctly await on_logged_out callbacks (#11786 )	3 years ago
Andrew Morgan	121b9e2475	Add a regression test for using both webclient and client resources simultaneously (#11765 )	3 years ago
Sean Quah	af13a3be29	Fix a bug that corrupted the cache of federated space hierarchies (#11775 ) `FederationClient.get_room_hierarchy()` caches its return values, so refactor the code to avoid modifying the returned room summary.	3 years ago
Patrick Cloke	68acb0a29d	Include whether the requesting user has participated in a thread. (#11577 ) Per updates to MSC3440. This is implement as a separate method since it needs to be cached on a per-user basis, instead of a per-thread basis.	3 years ago
Daniel Sonck	6b241f5286	Make pagination of rooms in admin api stable (#11737 ) Always add state.room_id after the configurable ORDER BY. Otherwise, for any sort, certain pages can contain results from other pages. (Especially when sorting by creator, since there may be many rooms by the same creator) * Document different order direction of numerical fields "joined_members", "joined_local_members", "version" and "state_events" are ordered in descending direction by default (dir=f). Added a note in tests to explain the differences in ordering. Signed-off-by: Daniël Sonck <daniel@sonck.nl>	3 years ago
Andrew Morgan	18862f20b5	Remove the 'password_hash' from the Users Admin API endpoint response dictionary (#11576 )	3 years ago
Patrick Cloke	3e0536cd2a	Replace uses of simple_insert_many with simple_insert_many_values. (#11742 ) This should be (slightly) more efficient and it is simpler to have a single method for inserting multiple values.	3 years ago
reivilibre	b602ba194b	Fix a bug introduced in Synapse v1.50.0rc1 whereby outbound federation could fail because too many EDUs were produced for device updates. (#11730 ) Co-authored-by: David Robertson <davidr@element.io>	3 years ago
Patrick Cloke	0c40c619aa	Include bundled aggregations in the sync response cache. (#11659 )	3 years ago
Jason Robinson	2560b1b6b2	Allow tracking puppeted users for MAU (#11561 ) Currently when puppeting another user, the user doing the puppeting is tracked for client IPs and MAU (if configured). When tracking MAU is important, it becomes necessary to be possible to also track the client IPs and MAU of puppeted users. As an example a client that manages user creation and creation of tokens via the Synapse admin API, passing those tokens for the client to use. This PR adds optional configuration to enable tracking of puppeted users into monthly active users. The default behaviour stays the same. Signed-off-by: Jason Robinson <jasonr@matrix.org>	3 years ago
reivilibre	22abfca8d9	Fix a bug introduced in Synapse v1.0.0 whereby device list updates would not be sent to remote homeservers if there were too many to send at once. (#11729 ) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	3 years ago
David Robertson	1b1aed38e3	Deal with mypy errors w/ type-hinted pynacl 1.5.0 (#11714 ) * Deal with mypy errors w/ type-hinted pynacl 1.5.0 Fixes #11644. I really don't like that we're monkey patching pynacl SignedKey instances with alg and version objects. But I'm too scared to make the changes necessary right now. (Ideally I would replace `signedjson.types.SingingKey` with a runtime class which wraps or inherits from `nacl.signing.SigningKey`.) C.f. https://github.com/matrix-org/python-signedjson/issues/16	3 years ago
David Robertson	c43dd4d01b	Deal with mypy errors w/ type-hinted pynacl 1.5.0 (#11714 ) * Deal with mypy errors w/ type-hinted pynacl 1.5.0 Fixes #11644. I really don't like that we're monkey patching pynacl SignedKey instances with alg and version objects. But I'm too scared to make the changes necessary right now. (Ideally I would replace `signedjson.types.SingingKey` with a runtime class which wraps or inherits from `nacl.signing.SigningKey`.) C.f. https://github.com/matrix-org/python-signedjson/issues/16	3 years ago
Patrick Cloke	8e57584a58	Support spaces with > 50 rooms in the /hierarchy endpoint. (#11695 ) By returning all of the m.space.child state of the space, not just the first 50. The number of rooms returned is still capped at 50. For the federation API this implies that the requesting server will need to individually query for any other rooms it is not joined to.	3 years ago
David Robertson	d3cf0730f8	Optionally use an on-disk sqlite db in tests (#11702 ) * Optionally use an on-disk sqlite db in tests When debugging a test it is sometimes useful to inspect the state of the DB. This is not easy when the db is in-memory: one cannot attach the sqlite CLI to another process's DB. With this change, if SYNAPSE_TEST_PERSIST_SQLITE_DB is set, we use `_trial_temp/test.db` as our sqlite database. One can then use `sqlite3 _trial_temp/test.db` and query to your heart's content. The DB is destroyed and recreated between different test cases. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	3 years ago
David Robertson	2bb4bd1269	Test that bans win a join against a race when computing `/sync` response (#11701 )	3 years ago

1 2 3 4 5 ...

2844 Commits (8744becc7c4caf4f191532ff17c6156e0111ae60)