watcha-synapse

Commit Graph

Author	SHA1	Message	Date
Patrick Cloke	01a45869f0	Update MSC3958 support to interact with intentional mentions. (#15992 ) * Updates the rule ID. * Use `event_property_is` instead of `event_match`. This updates the implementation of MSC3958 to match the latest text from the MSC.	1 year ago
Patrick Cloke	f880e64b11	Stabilize support for MSC3952: Intentional mentions. (#15520 )	1 year ago
Patrick Cloke	1e89976b26	Rename blacklist/whitelist internally. (#15620 ) Avoid renaming configuration settings for now and rename internal code to use blocklist and allowlist instead.	2 years ago
Sean Quah	3b837d856c	Revert "Reduce the size of the HTTP connection pool for non-pushers" (#15530 ) #15514 introduced a regression where Synapse would encounter `PartialDownloadError`s when fetching OpenID metadata for certain providers on startup. Due to #8088, this prevents Synapse from starting entirely. Revert the change while we decide what to do about the regression.	2 years ago
Erik Johnston	4de271a7fc	Allow adding random delay to push (#15516 ) This is to discourage timing based profiling on the push gateways.	2 years ago
Patrick Cloke	6aca4e7cb8	Reduce the size of the HTTP connection pool for non-pushers. (#15514 ) Pushers tend to make many connections to the same HTTP host (e.g. a new event comes in, causes events to be pushed, and then the homeserver connects to the same host many times). Due to this the per-host HTTP connection pool size was increased, but this does not make sense for other SimpleHttpClients. Add a parameter for the connection pool and override it for pushers (making a separate SimpleHttpClient for pushers with the increased configuration). This returns the HTTP connection pool settings to the default Twisted ones for non-pusher HTTP clients.	2 years ago
Quentin Gliech	5b70f240cf	Make cleaning up pushers depend on the device_id instead of the token_id (#15280 ) This makes it so that we rely on the `device_id` to delete pushers on logout, instead of relying on the `access_token_id`. This ensures we're not removing pushers on token refresh, and prepares for a world without access token IDs (also known as the OIDC). This actually runs the `set_device_id_for_pushers` background update, which was forgotten in #13831. Note that for backwards compatibility it still deletes pushers based on the `access_token` until the background update finishes.	2 years ago
Patrick Cloke	68a6717312	Reject mentions on the C-S API which are invalid. (#15311 ) Invalid mentions data received over the Client-Server API should be rejected with a 400 error. This will hopefully stop clients from sending invalid data, although does not help with data received over federation.	2 years ago
David Robertson	3b0083c92a	Use immutabledict instead of frozendict (#15113 ) Additionally: * Consistently use `freeze()` in test --------- Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: 6543 <6543@obermui.de>	2 years ago
Patrick Cloke	20ed8c926b	Stabilize support for MSC3873: disambuguated event push keys. (#15190 ) This removes the experimental configuration option and always escapes the push rule condition keys. Also escapes any (experimental) push rule condition keys in the base rules which contain dot in a field name.	2 years ago
Patrick Cloke	820f02b70b	Stabilize support for MSC3966: event_property_contains push condition. (#15187 ) This removes the configuration flag & updates the identifiers to use the stable version.	2 years ago
Patrick Cloke	fd9cadcf53	Stabilize support for MSC3758: event_property_is push condition (#15185 ) This removes the configuration flag & updates the identifiers to use the stable version.	2 years ago
Patrick Cloke	8ef324ea6f	Update intentional mentions (MSC3952) to depend on `exact_event_property_contains` (MSC3966). (#15051 ) This replaces the specific `is_user_mention` push rule condition used in MSC3952 with the generic `exact_event_property_contains` push rule condition from MSC3966.	2 years ago
Patrick Cloke	e746f80b4f	Do not accept pattern_type from user input in push rules. (#15088 ) Internally the push rules module uses a `pattern_type` property for `event_match` conditions (and `related_event_match`) to mark the condition as matching the current user's Matrix ID or localpart. This is leaky to the Client-Server API where a user can successfully set a condition which provides `pattern_type` instead of `pattern` (note that there's no benefit to doing this -- the user can just use their own Matrix ID or localpart instead). When serializing back to the client the `pattern_type` property is converted into a proper `pattern`. The following changes are made to avoid this: * Separate the `KnownCondition::EventMatch` enum value into `EventMatch` and `EventMatchType`, each with their own expected properties. (Note that a similar change is made for `RelatedEventMatch`.) * Make it such that the `pattern_type` variants serialize to the same condition kind, but cannot be deserialized (since they're only provided by base rules). * As a final tweak, convert `user_id` vs. `user_localpart` values into an enum.	2 years ago
Andrew Morgan	b40657314e	Add module API callbacks for adding and deleting local 3PID associations (#15044	2 years ago
Shay	1c95ddd09b	Batch up storing state groups when creating new room (#14918 )	2 years ago
Patrick Cloke	ec79870f14	Fix a typo in MSC3873 config option. (#15138 ) Previously the experimental configuration option referred to the wrong MSC number.	2 years ago
dependabot[bot]	9bb2eac719	Bump black from 22.12.0 to 23.1.0 (#15103 )	2 years ago
Patrick Cloke	979f237b28	Update intentional mentions (MSC3952) to depend on `exact_event_match` (MSC3758). (#15037 ) This replaces the specific `is_room_mention` push rule condition used in MSC3952 with the generic `exact_event_match` push rule condition from MSC3758. No functionality changes due to this.	2 years ago
Patrick Cloke	42aea0d8af	Add final type hint to tests.unittest. (#15072 ) Adds a return type to HomeServerTestCase.make_homeserver and deal with any variables which are no longer Any.	2 years ago
Patrick Cloke	119e0795a5	Implement MSC3966: Add a push rule condition to search for a value in an array. (#15045 ) The `exact_event_property_contains` condition can be used to search for a value inside of an array.	2 years ago
Patrick Cloke	14be78d492	Support for MSC3758: exact_event_match push condition (#14964 ) This specifies to search for an exact value match, instead of string globbing. It only works across non-compound JSON values (null, boolean, integer, and strings).	2 years ago
Patrick Cloke	c951fbedcb	MSC3873: Escape keys when flattening dicts. (#15004 ) This disambiguates keys which attempt to match fields with a dot in them (e.g. m.relates_to). Disabled by default behind an experimental configuration flag.	2 years ago
Patrick Cloke	5b55c32d61	Add tests for using _flatten_dict with an event. (#15002 )	2 years ago
Patrick Cloke	b2d97bac09	Implement MSC3958: suppress notifications from edits (#14960 ) Co-authored-by: Brad Murray <brad@beeper.com> Co-authored-by: Nick Barrett <nick@beeper.com> Copy the suppress_edits push rule from Beeper to implement MSC3958. `9415a1284b/rust/src/push/base_rules.rs (L98-L114)`	2 years ago
Patrick Cloke	f0cae26d58	Add a docstring & tests for _flatten_dict. (#14981 )	2 years ago
Patrick Cloke	52700a0bcf	Support the backwards compatibility features in MSC3952. (#14958 ) If the feature is enabled and the event has a `m.mentions` property, skip processing of the legacy mentions rules.	2 years ago
David Robertson	510d4b06e7	Handle malformed values of `notification.room` in power level events (#14942 ) * Better test for bad values in power levels events The previous test only checked that Synapse didn't raise an exception, but didn't check that we had correctly interpreted the value of the dodgy power level. It also conflated two things: bad room notification levels, and bad user levels. There _is_ logic for converting the latter to integers, but we should test it separately. * Check we ignore types that don't convert to int * Handle `None` values in `notifications.room` * Changelog * Also test that bad values are rejected by event auth * Docstring * linter scripttttttttt	2 years ago
Patrick Cloke	2a51f3ec36	Implement MSC3952: Intentional mentions (#14823 ) MSC3952 defines push rules which searches for mentions in a list of Matrix IDs in the event body, instead of searching the entire event body for display name / local part. This is implemented behind an experimental configuration flag and does not yet implement the backwards compatibility pieces of the MSC.	2 years ago
Patrick Cloke	071f8b0f9b	Factor out common code in tests and fix comments. (#14819 )	2 years ago
Patrick Cloke	7f2cabf271	Fix-up type hints for tests.push module. (#14816 )	2 years ago
Will Hunt	71f3e53ad0	Add `push.enabled` option to disable push notification calculation (#14551 ) * Add initial option * changelog * Some more linting	2 years ago
realtyem	854a6884d8	Modernize unit tests configuration settings for workers. (#14568 ) Use the newer foo_instances configuration instead of the deprecated flags to enable specific features (e.g. start_pushers).	2 years ago
Travis Ralston	3da6450327	Initial support for MSC3931: Room version push rule feature flags (#14520 ) * Add support for MSC3931: Room Version Supports push rule condition * Create experimental flag for future work, and use it to gate MSC3931 * Changelog entry	2 years ago
DeepBlueV7.X	2d0ba3f89a	Implementation for MSC3664: Pushrules for relations (#11804 )	2 years ago
Shay	b7a7ff6ee3	Add initial power level event to batch of bulk persisted events when creating a new room. (#14228 )	2 years ago
Patrick Cloke	09be8ab5f9	Remove the experimental implementation of MSC3772. (#14094 ) MSC3772 has been abandoned.	2 years ago
David Robertson	e9a0419c8d	Fix sending events into rooms with non-integer power levels (#14073 )	2 years ago
Erik Johnston	285b9e9b6c	Speed up calculating push actions in large rooms (#13973 ) We move the expensive check of visibility to after calculating push actions, avoiding the expensive check for users who won't get pushed anyway. I think this should have a big impact on rooms with large numbers of local users that have pushed disabled.	2 years ago
Erik Johnston	ebd9e2dac6	Implement push rule evaluation in Rust. (#13838 )	2 years ago
Brendan Abolivier	ccca14140a	Track device IDs for pushers (#13831 ) Second half of the MSC3881 implementation	2 years ago
Brendan Abolivier	8ae42ab8fa	Support enabling/disabling pushers (from MSC3881) (#13799 ) Partial implementation of MSC3881	2 years ago
Erik Johnston	b4ae3b0d44	Don't include appservice users when calculating push rules (#13332 ) This can cause a lot of extra load on servers with lots of appservice users. Introduced in #13078	2 years ago
Erik Johnston	0d1d3e0708	Speed up `get_unread_event_push_actions_by_room` (#13005 ) Fixes #11887 hopefully. The core change here is that `event_push_summary` now holds a summary of counts up until a much more recent point, meaning that the range of rows we need to count in `event_push_actions` is much smaller. This needs two major changes: 1. When we get a receipt we need to recalculate `event_push_summary` rather than just delete it 2. The logic for deleting `event_push_actions` is now divorced from calculating `event_push_summary`. In future it would be good to calculate `event_push_summary` while we persist a new event (it should just be a case of adding one to the relevant rows in `event_push_summary`), as that will further simplify the get counts logic and remove the need for us to periodically update `event_push_summary` in a background job.	2 years ago
Patrick Cloke	88ce3080d4	Experimental support for MSC3772 (#12740 ) Implements the following behind an experimental configuration flag: * A new push rule kind for mutually related events. * A new default push rule (`.m.rule.thread_reply`) under an unstable prefix. This is missing part of MSC3772: * The `.m.rule.thread_reply_to_me` push rule, this depends on MSC3664 / #11804.	3 years ago
Dirk Klimpel	9d21ecf7ce	Add type hints to tests files. (#12256 )	3 years ago
Dirk Klimpel	9e06e22064	Add type hints to more tests files. (#12240 )	3 years ago
Nick Mills-Barrett	735e89bd3a	Add an additional HTTP pusher + push rule tests. (#12188 ) And rename the field used for caching from _id to _cache_key.	3 years ago
Richard van der Hoff	6c0b44a3d7	Fix `PushRuleEvaluator` and `Filter` to work on frozendicts (#12100 ) * Fix `PushRuleEvaluator` to work on frozendicts frozendicts do not (necessarily) inherit from dict, so this needs to handle them correctly. * Fix event filtering for frozen events Looks like this one was introduced by #11194.	3 years ago
Richard van der Hoff	e24ff8ebe3	Remove `HomeServer.get_datastore()` (#12031 ) The presence of this method was confusing, and mostly present for backwards compatibility. Let's get rid of it. Part of #11733	3 years ago

1 2

97 Commits (8c56e18e4786a28bedbafb1a73fd1abc8806933f)