12408 Commits (91c60f304256c08e8aff53ed13d5b282057277d6)

Author	SHA1	Message	Date
Richard van der Hoff	91c60f3042	Improve logging of state resolution (#8371) ... I'd like to get a better insight into what we are doing with respect to state res. The list of state groups we are resolving across should be short (if it isn't, that's a massive problem in itself), so it should be fine to log it in ite entiretly. I've done some grepping and found approximately zero cases in which the "shortcut" code delivered the result, so I've ripped that out too.	4 years ago
Richard van der Hoff	302dc89f6a	Fix bug which caused failure on join with malformed membership events (#8385)	4 years ago
Erik Johnston	cbabb312e0	Use `async with` for ID gens (#8383) ... This will allow us to hit the DB after we've finished using the generated stream ID.	4 years ago
Mathieu Velten	916bb9d0d1	Don't push if an user account has expired (#8353)	4 years ago
Patrick Cloke	bbde4038df	Do not check lint/test dependencies at runtime. (#8377) ... moves non-runtime dependencies out of synapse.python_dependencies (test and lint)	4 years ago
Andrew Morgan	4325be1a52	Fix missing null character check on guest_access room state ... When updating room_stats_state, we try to check for null bytes slipping in to the content for state events. It turns out we had added guest_access as a field to room_stats_state without including it in the null byte check. Lo and behold, a null byte in a m.room.guest_access event then breaks room_stats_state updates. This PR adds the check for guest_access. A further PR will improve this function so that this hopefully does not happen again in future.	4 years ago
Dirk Klimpel	8998217540	Fixed a bug with reactivating users with the admin API (#8362) ... Fixes: #8359 Trying to reactivate a user with the admin API (`PUT /_synapse/admin/v2/users/<user_name>`) causes an internal server error. Seems to be a regression in #8033.	4 years ago
Dirk Klimpel	4da01f9c61	Admin API for reported events (#8217) ... Add an admin API to read entries of table `event_reports`. API: `GET /_synapse/admin/v1/event_reports`	4 years ago
Andrew Morgan	55bb5fda33	1.20.0	4 years ago
Dionysis Grigoropoulos	37ca5924bd	Create function to check for long names in devices (#8364) ... * Create a new function to verify that the length of a device name is under a certain threshold. * Refactor old code and tests to use said function. * Verify device name length during registration of device * Add a test for the above Signed-off-by: Dionysis Grigoropoulos <dgrig@erethon.com>	4 years ago
Richard van der Hoff	4f3096d866	Add a comment re #1691	4 years ago
Patrick Cloke	babc027543	Fix a bad merge from release-v1.20.0. (#8354)	4 years ago
Patrick Cloke	d5f7182ba1	1.20.0rc5	4 years ago
Dirk Klimpel	d688b4bafc	Admin API for querying rooms where a user is a member (#8306) ... Add a new admin API `GET /_synapse/admin/v1/users/<user_id>/joined_rooms` to list all rooms where a user is a member.	4 years ago
Andrew Morgan	5b70acb44c	1.19.3	4 years ago
reivilibre	36efbcaf51	Catch-up after Federation Outage (bonus): Catch-up on Synapse Startup (#8322) ... Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Fix _set_destination_retry_timings This came about because the code assumed that retry_interval could not be NULL — which has been challenged by catch-up.	4 years ago
Patrick Cloke	8a4a4186de	Simplify super() calls to Python 3 syntax. (#8344) ... This converts calls like super(Foo, self) -> super(). Generated with: sed -i "" -Ee 's/super\([^\(]+\)/super()/g' **/*.py	4 years ago
Will Hunt	68c7a6936f	Allow appservice users to /login (#8320) ... Add ability for ASes to /login using the `uk.half-shot.msc2778.login.application_service` login `type`. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	4 years ago
Andrew Morgan	27c1abc7b8	Use _check_sigs_and_hash_and_fetch to validate backfill requests (#8350) ... This is a bit of a hack, as `_check_sigs_and_hash_and_fetch` is intended for attempting to pull an event from the database/(re)pull it from the server that originally sent the event if checking the signature of the event fails. During backfill we *know* that we won't have the event in our database, however it is still useful to be able to query the original sending server as the server we're backfilling from may be acting maliciously. The main benefit and reason for this change however is that `_check_sigs_and_hash_and_fetch` will drop an event during backfill if it cannot be successfully validated, whereas the current code will simply fail the backfill request - resulting in the client's /messages request silently being dropped. This is a quick patch to fix backfilling rooms that contain malformed events. A better implementation in planned in future.	4 years ago
Erik Johnston	43f2b67e4d	Intelligently select extremities used in backfill. (#8349) ... Instead of just using the most recent extremities let's pick the ones that will give us results that the pagination request cares about, i.e. pick extremities only if they have a smaller depth than the pagination token. This is useful when we fail to backfill an extremity, as we no longer get stuck requesting that same extremity repeatedly.	4 years ago
Patrick Cloke	9db4c1b175	Add flags to /versions about whether new rooms are encrypted by default. (#8343)	4 years ago
Erik Johnston	14b5b48a22	Fix ratelimiting for federation `/send` requests. (#8342) ... c.f. #8295 for rationale	4 years ago
Jonathan de Jong	efb6b6629c	Move lint dependencies to extras_require (#8330) ... Lint dependencies can now be installed with pip install -e ".[lint]" This should help keep the version in sync between tox and documentation.	4 years ago
Jonathan de Jong	837293c314	Remove obsolete __future__ imports (#8337)	4 years ago
Patrick Cloke	c3c9732c53	Use admin_patterns for all admin APIs. (#8331) ... This reduces duplication of the admin prefix in regular expressions.	4 years ago
Jonathan de Jong	53284c425e	Fix a potential bug of UnboundLocalError (#8329) ... Replaced with less buggier control flow	4 years ago
Jonathan de Jong	a3f124b821	Switch metaclass initialization to python 3-compatible syntax (#8326)	4 years ago
Patrick Cloke	7141057e85	1.20.0rc4	4 years ago
Erik Johnston	5ffd68dca1	1.19.2	4 years ago
Erik Johnston	c570f24acc	Don't assume that an event has an origin field ... This fixes #8319.	4 years ago
reivilibre	576bc37d31	Catch-up after Federation Outage (split, 4): catch-up loop (#8272)	4 years ago
Patrick Cloke	aec294ee0d	Use slots in attrs classes where possible (#8296) ... slots use less memory (and attribute access is faster) while slightly limiting the flexibility of the class attributes. This focuses on objects which are instantiated "often" and for short periods of time.	4 years ago
Patrick Cloke	d2a3eb04a4	Fix typos in comments.	4 years ago
Tulir Asokan	b82d68c0bd	Add the topic and avatar to the room details admin API (#8305)	4 years ago
Patrick Cloke	6605470bfb	Improve SAML error messages (#8248)	4 years ago
Erik Johnston	04cc249b43	Add experimental support for sharding event persister. Again. (#8294) ... This is *not* ready for production yet. Caveats: 1. We should write some tests... 2. The stream token that we use for events can get stalled at the minimum position of all writers. This means that new events may not be processed and e.g. sent down sync streams if a writer isn't writing or is slow.	4 years ago
Patrick Cloke	2832ef5bb7	1.20.0rc3	4 years ago
Erik Johnston	fe8ed1b46f	Make `StreamToken.room_key` be a `RoomStreamToken` instance. (#8281)	4 years ago
Patrick Cloke	b86764662b	Fix the exception that is raised when invalid JSON is encountered. (#8291)	4 years ago
Erik Johnston	5d3e306d9f	Clean up `Notifier.on_new_room_event` code path (#8288) ... The idea here is that we pass the `max_stream_id` to everything, and only use the stream ID of the particular event to figure out *when* the max stream position has caught up to the event and we can notify people about it. This is to maintain the distinction between the position of an item in the stream (i.e. event A has stream ID 513) and a token that can be used to partition the stream (i.e. give me all events after stream ID 352). This distinction becomes important when the tokens are more complicated than a single number, which they will be once we start tracking the position of multiple writers in the tokens. The valid operations here are: 1. Is a position before or after a token 2. Fetching all events between two tokens 3. Merging multiple tokens to get the "max", i.e. `C = max(A, B)` means that for all positions P where P is before A *or* before B, then P is before C. Future PR will change the token type to a dedicated type.	4 years ago
Andrew Morgan	a3a90ee031	Show a confirmation page during user password reset (#8004) ... This PR adds a confirmation step to resetting your user password between clicking the link in your email and your password actually being reset. This is to better align our password reset flow with the industry standard of requiring a confirmation from the user after email validation.	4 years ago
Patrick Cloke	b312769c0e	Do not error when thumbnailing invalid files (#8236) ... If a file cannot be thumbnailed for some reason (e.g. the file is empty), then catch the exception and convert it to a reasonable error message for the client.	4 years ago
Patrick Cloke	2ea1c68249	Remove some unused distributor signals (#8216) ... Removes the `user_joined_room` and stops calling it since there are no observers. Also cleans-up some other unused signals and related code.	4 years ago
Richard van der Hoff	536f4a2482	1.20.0rc2	4 years ago
Erik Johnston	c9dbee50ae	Fixup pusher pool notifications (#8287) ... `pusher_pool.on_new_notifications` expected a min and max stream ID, however that was not what we were passing in. Instead, let's just pass it the current max stream ID and have it track the last stream ID it got passed. I believe that it mostly worked as we called the function for every event. However, it would break for events that got persisted out of order, i.e, that were persisted but the max stream ID wasn't incremented as not all preceding events had finished persisting, and push for that event would be delayed until another event got pushed to the effected users.	4 years ago
Erik Johnston	dc9dcdbd59	Revert "Fixup pusher pool notifications" ... This reverts commit e7fd336a53.	4 years ago
Erik Johnston	e7fd336a53	Fixup pusher pool notifications	4 years ago
reivilibre	a5370072b5	Don't remember `enabled` of deleted push rules and properly return 404 for missing push rules in `.../actions` and `.../enabled` (#7796) ... Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	4 years ago
Patrick Cloke	e45b834119	Add types to async_helpers (#8260)	4 years ago
Erik Johnston	1553adc831	Fix mypy error on develop (#8282)	4 years ago