3525 Commits (91c60f304256c08e8aff53ed13d5b282057277d6)

Author	SHA1	Message	Date
Dionysis Grigoropoulos	37ca5924bd	Create function to check for long names in devices (#8364) ... * Create a new function to verify that the length of a device name is under a certain threshold. * Refactor old code and tests to use said function. * Verify device name length during registration of device * Add a test for the above Signed-off-by: Dionysis Grigoropoulos <dgrig@erethon.com>	4 years ago
Patrick Cloke	babc027543	Fix a bad merge from release-v1.20.0. (#8354)	4 years ago
Patrick Cloke	8a4a4186de	Simplify super() calls to Python 3 syntax. (#8344) ... This converts calls like super(Foo, self) -> super(). Generated with: sed -i "" -Ee 's/super\([^\(]+\)/super()/g' **/*.py	4 years ago
Erik Johnston	43f2b67e4d	Intelligently select extremities used in backfill. (#8349) ... Instead of just using the most recent extremities let's pick the ones that will give us results that the pagination request cares about, i.e. pick extremities only if they have a smaller depth than the pagination token. This is useful when we fail to backfill an extremity, as we no longer get stuck requesting that same extremity repeatedly.	4 years ago
Jonathan de Jong	a3f124b821	Switch metaclass initialization to python 3-compatible syntax (#8326)	4 years ago
Patrick Cloke	aec294ee0d	Use slots in attrs classes where possible (#8296) ... slots use less memory (and attribute access is faster) while slightly limiting the flexibility of the class attributes. This focuses on objects which are instantiated "often" and for short periods of time.	4 years ago
Patrick Cloke	6605470bfb	Improve SAML error messages (#8248)	4 years ago
Erik Johnston	04cc249b43	Add experimental support for sharding event persister. Again. (#8294) ... This is *not* ready for production yet. Caveats: 1. We should write some tests... 2. The stream token that we use for events can get stalled at the minimum position of all writers. This means that new events may not be processed and e.g. sent down sync streams if a writer isn't writing or is slow.	4 years ago
Erik Johnston	fe8ed1b46f	Make `StreamToken.room_key` be a `RoomStreamToken` instance. (#8281)	4 years ago
Erik Johnston	5d3e306d9f	Clean up `Notifier.on_new_room_event` code path (#8288) ... The idea here is that we pass the `max_stream_id` to everything, and only use the stream ID of the particular event to figure out *when* the max stream position has caught up to the event and we can notify people about it. This is to maintain the distinction between the position of an item in the stream (i.e. event A has stream ID 513) and a token that can be used to partition the stream (i.e. give me all events after stream ID 352). This distinction becomes important when the tokens are more complicated than a single number, which they will be once we start tracking the position of multiple writers in the tokens. The valid operations here are: 1. Is a position before or after a token 2. Fetching all events between two tokens 3. Merging multiple tokens to get the "max", i.e. `C = max(A, B)` means that for all positions P where P is before A *or* before B, then P is before C. Future PR will change the token type to a dedicated type.	4 years ago
Patrick Cloke	2ea1c68249	Remove some unused distributor signals (#8216) ... Removes the `user_joined_room` and stops calling it since there are no observers. Also cleans-up some other unused signals and related code.	4 years ago
Erik Johnston	c9dbee50ae	Fixup pusher pool notifications (#8287) ... `pusher_pool.on_new_notifications` expected a min and max stream ID, however that was not what we were passing in. Instead, let's just pass it the current max stream ID and have it track the last stream ID it got passed. I believe that it mostly worked as we called the function for every event. However, it would break for events that got persisted out of order, i.e, that were persisted but the max stream ID wasn't incremented as not all preceding events had finished persisting, and push for that event would be delayed until another event got pushed to the effected users.	4 years ago
Erik Johnston	dc9dcdbd59	Revert "Fixup pusher pool notifications" ... This reverts commit e7fd336a53.	4 years ago
Erik Johnston	e7fd336a53	Fixup pusher pool notifications	4 years ago
Erik Johnston	1553adc831	Fix mypy error on develop (#8282)	4 years ago
Erik Johnston	63c0e9e195	Add types to StreamToken and RoomStreamToken (#8279) ... The intention here is to change `StreamToken.room_key` to be a `RoomStreamToken` in a future PR, but that is a big enough change without this refactoring too.	4 years ago
Erik Johnston	0f545e6b96	Clean up types for PaginationConfig (#8250) ... This removes `SourcePaginationConfig` and `get_pagination_rows`. The reasoning behind this is that these generic classes/functions erased the types of the IDs it used (i.e. instead of passing around `StreamToken` it'd pass in e.g. `token.room_key`, which don't have uniform types).	4 years ago
Patrick Cloke	c619253db8	Stop sub-classing object (#8249)	4 years ago
Brendan Abolivier	9f8abdcc38	Revert "Add experimental support for sharding event persister. (#8170)" (#8242) ... * Revert "Add experimental support for sharding event persister. (#8170)" This reverts commit 82c1ee1c22. * Changelog	4 years ago
Erik Johnston	be16ee59a8	Add type hints to more handlers (#8244)	4 years ago
Erik Johnston	208e1d3eb3	Fix typing for `@cached` wrapped functions (#8240) ... This requires adding a mypy plugin to fiddle with the type signatures a bit.	4 years ago
Erik Johnston	5bfc79486d	Fix typing for SyncHandler (#8237)	4 years ago
Brendan Abolivier	5a1dd297c3	Re-implement unread counts (again) (#8059)	4 years ago
Erik Johnston	82c1ee1c22	Add experimental support for sharding event persister. (#8170) ... This is *not* ready for production yet. Caveats: 1. We should write some tests... 2. The stream token that we use for events can get stalled at the minimum position of all writers. This means that new events may not be processed and e.g. sent down sync streams if a writer isn't writing or is slow.	4 years ago
Patrick Cloke	b939251c37	Fix errors when updating the user directory with invalid data (#8223)	4 years ago
Patrick Cloke	da77520cd1	Convert additional databases to async/await part 2 (#8200)	4 years ago
Richard van der Hoff	aa07c37cf0	Move and rename `get_devices_with_keys_by_user` (#8204) ... * Move `get_devices_with_keys_by_user` to `EndToEndKeyWorkerStore` this seems a better fit for it. This commit simply moves the existing code: no other changes at all. * Rename `get_devices_with_keys_by_user` to better reflect what it does. * get_device_stream_token abstract method To avoid referencing fields which are declared in the derived classes, make `get_device_stream_token` abstract, and define that in the classes which define `_device_list_id_gen`.	4 years ago
Richard van der Hoff	45e8f7726f	Rename `get_e2e_device_keys` to better reflect its purpose (#8205) ... ... and to show that it does something slightly different to `_get_e2e_device_keys_txn`. `include_all_devices` and `include_deleted_devices` were never used (and `include_deleted_devices` was broken, since that would cause `None`s in the result which were not handled in the loop below. Add some typing too.	4 years ago
Patrick Cloke	d2ac767de2	Convert ReadWriteLock to async/await. (#8202)	4 years ago
Patrick Cloke	aec7085179	Convert state and stream stores and related code to async (#8194)	4 years ago
Patrick Cloke	b055dc9322	Ensure that the OpenID Connect remote ID is a string. (#8190)	4 years ago
Patrick Cloke	5c03134d0f	Convert additional database code to async/await. (#8195)	4 years ago
Patrick Cloke	d5e73cb6aa	Define StateMap as immutable and add a MutableStateMap type. (#8183)	4 years ago
Andrew Morgan	2c2e649be2	Move and refactor LoginRestServlet helper methods (#8182) ... This is split out from https://github.com/matrix-org/synapse/pull/7438, which had gotten rather large. `LoginRestServlet` has a couple helper methods, `login_submission_legacy_convert` and `login_id_thirdparty_from_phone`. They're primarily used for converting legacy user login submissions to "identifier" dicts ([see spec](https://matrix.org/docs/spec/client_server/r0.6.1#post-matrix-client-r0-login)). Identifying information such as usernames or 3PID information used to be top-level in the login body. They're now supposed to be put inside an [identifier](https://matrix.org/docs/spec/client_server/r0.6.1#identifier-types) parameter instead. #7438's purpose is to allow using the new identifier parameter during User-Interactive Authentication, which is currently handled in AuthHandler. That's why I've moved these helper methods there. I also moved the refactoring of these method from #7438 as they're relevant.	4 years ago
Patrick Cloke	4a739c73b4	Convert simple_update* and simple_select* to async (#8173)	4 years ago
Patrick Cloke	6fe12c9512	Do not propagate typing notifications from shadow-banned users. (#8176)	4 years ago
Andrew Morgan	e0d6244beb	Remove unused parameter from, and add safeguard in, get_room_data (#8174) ... Small cleanup PR. * Removed the unused `is_guest` argument * Added a safeguard to a (currently) impossible code path, fixing static checking at the same time.	4 years ago
Patrick Cloke	2e6c90ff84	Do not propagate profile changes of shadow-banned users into rooms. (#8157)	4 years ago
Patrick Cloke	5099bd68da	Do not allow send_nonmember_event to be called with shadow-banned users. (#8158)	4 years ago
Patrick Cloke	5758dcf30c	Add type hints for state. (#8140)	4 years ago
Patrick Cloke	cbd8d83da7	Stop shadow-banned users from sending non-member events. (#8142)	4 years ago
Brendan Abolivier	420484a334	Allow capping a room's retention policy (#8104)	4 years ago
Brendan Abolivier	393a811a41	Fix join ratelimiter breaking profile updates and idempotency (#8153)	4 years ago
Will Hunt	2df82ae451	Do not apply ratelimiting on joins to appservices (#8139) ... Add new method ratelimiter.can_requester_do_action and ensure that appservices are exempt from being ratelimited. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>	4 years ago
Will Hunt	cbbf9126cb	Do not apply ratelimiting on joins to appservices (#8139) ... Add new method ratelimiter.can_requester_do_action and ensure that appservices are exempt from being ratelimited. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>	4 years ago
Patrick Cloke	3f91638da6	Allow denying or shadow banning registrations via the spam checker (#8034)	4 years ago
Patrick Cloke	e259d63f73	Stop shadow-banned users from sending invites. (#8095)	4 years ago
Patrick Cloke	592cdf73be	Improve the error code when trying to register using a name reserved for guests. (#8135)	4 years ago
Patrick Cloke	dbc630a628	Use the JSON encoder without whitespace in more places. (#8124)	4 years ago
Patrick Cloke	eebf52be06	Be stricter about JSON that is accepted by Synapse (#8106)	4 years ago