621 Commits (982fe2965515e4536a0aa0153fa6bee238179f51)

Author	SHA1	Message	Date
Andrew Morgan	7b06f85c0e	Ensure we use a copy of the event content dict before modifying it in serialize_event (#9585) ... This bug was discovered by DINUM. We were modifying `serialized_event["content"]`, which - if you've got `USE_FROZEN_DICTS` turned on or are [using a third party rules module](17cd48fe51/synapse/events/third_party_rules.py (L73-L76)) - will raise a 500 if you try to a edit a reply to a message. `serialized_event["content"]` could be set to the edit event's content, instead of a copy of it, which is bad as we attempt to modify it. Instead, we also end up modifying the original event's content. DINUM uses a third party rules module, which meant the event's content got frozen and thus an exception was raised. To be clear, the problem is not that the event's content was frozen. In fact doing so helped us uncover the fact we weren't copying event content correctly.	4 years ago
Dirk Klimpel	8000cf1315	Return m.change_password.enabled=false if local database is disabled (#9588) ... Instead of if the user does not have a password hash. This allows a SSO user to add a password to their account, but only if the local password database is configured.	4 years ago
Richard van der Hoff	dd69110d95	Add support for stable MSC2858 API (#9617) ... The stable format uses different brand identifiers, so we need to support two identifiers for each IdP.	4 years ago
Patrick Cloke	33a02f0f52	Fix additional type hints from Twisted upgrade. (#9518)	4 years ago
Richard van der Hoff	15090de850	SSO: redirect to public URL before setting cookies (#9436) ... ... otherwise, we don't get the cookie back.	4 years ago
Andrew Morgan	0a363f9ca4	Remove cache for get_shared_rooms_for_users (#9416) ... This PR remove the cache for the `get_shared_rooms_for_users` storage method (the db method driving the experimental "what rooms do I share with this user?" feature: [MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)). Currently subsequent requests to the endpoint will return the same result, even if your shared rooms with that user have changed. The cache was added in https://github.com/matrix-org/synapse/pull/7785, but we forgot to ensure it was invalidated appropriately. Upon attempting to invalidate it, I found that the cache had to be entirely invalidated whenever a user (remote or local) joined or left a room. This didn't make for a very useful cache, especially for a function that may or may not be called very often. Thus, I've opted to remove it instead of invalidating it.	4 years ago
Rishabh Arya	e17553e185	Parse ui_auth.session_timeout as a duration (instead of treating it as ms) (#9426)	4 years ago
Eric Eastwood	0a00b7ff14	Update black, and run auto formatting over the codebase (#9381) ... - Update black version to the latest - Run black auto formatting over the codebase - Run autoformatting according to [`docs/code_style.md `](80d6dc9783/docs/code_style.md) - Update `code_style.md` docs around installing black to use the correct version	4 years ago
Patrick Cloke	731e08c63a	Handle missing data in power levels events during room upgrade. (#9395)	4 years ago
Patrick Cloke	74af356baf	Convert additional test-cases to homeserver test case. (#9396) ... And convert some inlineDeferreds to async-friendly functions.	4 years ago
Patrick Cloke	e40d88cff3	Backout changes for automatically calculating the public baseurl. (#9313) ... This breaks some people's configurations (if their Client-Server API is not accessed via port 443).	4 years ago
Patrick Cloke	8a33d217bd	Convert some test cases to use HomeserverTestCase. (#9377) ... This has the side-effect of being able to remove use of `inlineCallbacks` in the test-cases for cleaner tracebacks.	4 years ago
Richard van der Hoff	e288499c60	Social login UI polish (#9301)	4 years ago
Richard van der Hoff	4167494c90	Replace username picker with a template (#9275) ... There's some prelimiary work here to pull out the construction of a jinja environment to a separate function. I wanted to load the template at display time rather than load time, so that it's easy to update on the fly. Honestly, I think we should do this with all our templates: the risk of ending up with malformed templates is far outweighed by the improved turnaround time for an admin trying to update them.	4 years ago
Richard van der Hoff	9c715a5f19	Fix SSO on workers (#9271) ... Fixes #8966. * Factor out build_synapse_client_resource_tree Start a function which will mount resources common to all workers. * Move sso init into build_synapse_client_resource_tree ... so that we don't have to do it for each worker * Fix SSO-login-via-a-worker Expose the SSO login endpoints on workers, like the documentation says. * Update workers config for new endpoints Add documentation for endpoints recently added (#8942, #9017, #9262) * remove submit_token from workers endpoints list this *doesn't* work on workers (yet). * changelog * Add a comment about the odd path for SAML2Resource	4 years ago
Richard van der Hoff	f78d07bf00	Split out a separate endpoint to complete SSO registration (#9262) ... There are going to be a couple of paths to get to the final step of SSO reg, and I want the URL in the browser to consistent. So, let's move the final step onto a separate path, which we redirect to.	4 years ago
Erik Johnston	f2c1560eca	Ratelimit invites by room and target user (#9258)	4 years ago
Erik Johnston	4b73488e81	Ratelimit 3PID /requestToken API (#9238)	4 years ago
Richard van der Hoff	a737cc2713	Implement MSC2858 support (#9183) ... Fixes #8928.	4 years ago
Patrick Cloke	4a55d267ee	Add an admin API for shadow-banning users. (#9209) ... This expands the current shadow-banning feature to be usable via the admin API and adds documentation for it. A shadow-banned users receives successful responses to their client-server API requests, but the events are not propagated into rooms. Shadow-banning a user should be used as a tool of last resort and may lead to confusing or broken behaviour for the client.	4 years ago
Richard van der Hoff	7447f19702	Prefix idp_id with "oidc-" (#9189) ... ... to avoid clashes with other SSO mechanisms	4 years ago
Richard van der Hoff	02070c69fa	Fix bugs in handling clientRedirectUrl, and improve OIDC tests (#9127, #9128) ... * Factor out a common TestHtmlParser Looks like I'm doing this in a few different places. * Improve OIDC login test Complete the OIDC login flow, rather than giving up halfway through. * Ensure that OIDC login works with multiple OIDC providers * Fix bugs in handling clientRedirectUrl - don't drop duplicate query-params, or params with no value - allow utf-8 in query-params	4 years ago
Richard van der Hoff	b5dea8702d	Fix test failure due to bad merge ... 0dd2649c1 (#9112) changed the signature of `auth_via_oidc`. Meanwhile, 26d10331e (#9091) introduced a new test which relied on the old signature of `auth_via_oidc`. The two branches were never tested together until they landed in develop.	4 years ago
Richard van der Hoff	0dd2649c12	Improve UsernamePickerTestCase (#9112) ... * make the OIDC bits of the test work at a higher level - via the REST api instead of poking the OIDCHandler directly. * Move it to test_login.py, where I think it fits better.	4 years ago
Richard van der Hoff	26d10331e5	Add a test for wrong user returned by SSO	4 years ago
Richard van der Hoff	233c8b9fce	Add a test for UI-Auth-via-SSO (#9082) ... * Add complete test for UI-Auth-via-SSO. * review comments	4 years ago
Dirk Klimpel	7a2e9b549d	Remove user's avatar URL and displayname when deactivated. (#8932) ... This only applies if the user's data is to be erased.	4 years ago
Richard van der Hoff	8a910f97a4	Add some tests for the IDP picker flow	4 years ago
Richard van der Hoff	bbd04441ed	Fix type hints in test_login.py	4 years ago
Richard van der Hoff	3fc2399dbe	black-format tests/rest/client/v1/test_login.py ... black seems to want to reformat this, despite `black --check` being happy with it :/	4 years ago
Richard van der Hoff	8d3d264052	Skip unit tests which require optional dependencies (#9031) ... If we are lacking an optional dependency, skip the tests that rely on it.	4 years ago
Richard van der Hoff	d2c616a413	Combine the SSO Redirect Servlets (#9015) ... * Implement CasHandler.handle_redirect_request ... to make it match OidcHandler and SamlHandler * Clean up interface for OidcHandler.handle_redirect_request Make it accept `client_redirect_url=None`. * Clean up interface for `SamlHandler.handle_redirect_request` ... bring it into line with CAS and OIDC by making it take a Request parameter, move the magic for `client_redirect_url` for UIA into the handler, and fix the return type to be a `str` rather than a `bytes`. * Define a common protocol for SSO auth provider impls * Give SsoIdentityProvider an ID and register them * Combine the SSO Redirect servlets Now that the SsoHandler knows about the identity providers, we can combine the various *RedirectServlets into a single implementation which delegates to the right IdP. * changelog	4 years ago
Patrick Cloke	a802606475	Support PyJWT v2.0.0. (#8986) ... Tests were broken due to an API changing. The code used in Synapse proper should be compatible with both versions already.	4 years ago
Patrick Cloke	5d4c330ed9	Allow re-using a UI auth validation for a period of time (#8970)	4 years ago
Richard van der Hoff	2dd2e90e2b	Test `get_extra_attributes` fallback ... despite the warnings saying "don't implement get_extra_attributes", we had implemented it, so the tests weren't doing what we thought they were.	4 years ago
Richard van der Hoff	c9dd47d668	lint	4 years ago
Richard van der Hoff	394516ad1b	Remove spurious "SynapseRequest" result from `make_request" ... This was never used, so let's get rid of it.	4 years ago
Richard van der Hoff	ac2acf1524	Remove redundant reading of SynapseRequest.args ... this didn't seem to be doing a lot, so remove it.	4 years ago
Richard van der Hoff	0378581c13	remove 'response' result from `_get_shared_rooms`	4 years ago
Richard van der Hoff	7eebe4b3fc	Replace `request.code` with `channel.code` ... The two are equivalent, but really we want to check the HTTP result that got returned to the channel, not the code that the Request object *intended* to return to the channel.	4 years ago
Erik Johnston	1d55c7b567	Don't ratelimit autojoining of rooms (#8921) ... Fixes #8866	4 years ago
Richard van der Hoff	cf3b8156be	Fix errorcode for disabled registration (#8867) ... The spec says we should return `M_FORBIDDEN` when someone tries to register and registration is disabled.	4 years ago
Richard van der Hoff	0bac276890	UIA: offer only available auth flows ... During user-interactive auth, do not offer password auth to users with no password, nor SSO auth to users with no SSO. Fixes #7559.	4 years ago
Patrick Cloke	30fba62108	Apply an IP range blacklist to push and key revocation requests. (#8821) ... Replaces the `federation_ip_range_blacklist` configuration setting with an `ip_range_blacklist` setting with wider scope. It now applies to: * Federation * Identity servers * Push notifications * Checking key validitity for third-party invite events The old `federation_ip_range_blacklist` setting is still honored if present, but with reduced scope (it only applies to federation and identity servers).	4 years ago
Andrew Morgan	edb3d3f827	Allow specifying room version in 'RestHelper.create_room_as' and add typing (#8854) ... This PR adds a `room_version` argument to the `RestHelper`'s `create_room_as` function for tests. I plan to use this for testing knocking, which currently uses an unstable room version.	4 years ago
Richard van der Hoff	4d9496559d	Support "identifier" dicts in UIA (#8848) ... The spec requires synapse to support `identifier` dicts for `m.login.password` user-interactive auth, which it did not (instead, it required an undocumented `user` parameter.) To fix this properly, we need to pull the code that interprets `identifier` into `AuthHandler.validate_login` so that it can be called from the UIA code. Fixes #5665.	4 years ago
Jonathan de Jong	ca60822b34	Simplify the way the `HomeServer` object caches its internal attributes. (#8565) ... Changes `@cache_in_self` to use underscore-prefixed attributes.	4 years ago
Dirk Klimpel	3f0ff53158	Remove deprecated `/_matrix/client/*/admin` endpoints (#8785) ... These are now only available via `/_synapse/admin/v1`.	4 years ago
Richard van der Hoff	acfe3b3065	Remove redundant `HomeserverTestCase.render`	4 years ago
Richard van der Hoff	be8fa65d0b	Remove redundant calls to `render()`	4 years ago