watcha-synapse

Commit Graph

Author	SHA1	Message	Date
Sean Quah	8eaffe013c	Update `_wrap_in_base_path` type hints to preserve function arguments (#11055 )	3 years ago
Patrick Cloke	1db9282dfa	Fix formatting string when oEmbed errors occur. (#11061 )	3 years ago
Erik Johnston	333d6f4e84	Fix race in `MultiWriterIdGenerator` (#11045 ) The race allowed the current position to advance too far when stream IDs are still being persisted. This happened when it received a new stream ID from a remote write between a new stream ID being allocated and it being added to the set of unpersisted stream IDs. Fixes #9424.	3 years ago
Sean Quah	36224e056a	Add type hints to `synapse.storage.databases.main.client_ips` (#10972 )	3 years ago
Sean Quah	b8b905c4ea	Fix inconsistent behavior of `get_last_client_by_ip` (#10970 ) Make `get_last_client_by_ip` return the same dictionary structure regardless of whether the data has been persisted to the database. This change will allow slightly cleaner type hints to be applied later on.	3 years ago
Sean Quah	6b18eb4430	Fix opentracing and Prometheus metrics for replication requests (#10996 ) This commit fixes two bugs to do with decorators not instrumenting `ReplicationEndpoint`'s `send_request` correctly. There are two decorators on `send_request`: Prometheus' `Gauge.track_inprogress()` and Synapse's `opentracing.trace`. `Gauge.track_inprogress()` does not have any support for async functions when used as a decorator. Since async functions behave like regular functions that return coroutines, only the creation of the coroutine was covered by the metric and none of the actual body of `send_request`. `Gauge.track_inprogress()` returns a regular, non-async function wrapping `send_request`, which is the source of the next bug. The `opentracing.trace` decorator would normally handle async functions correctly, but since the wrapped `send_request` is a non-async function, the decorator ends up suffering from the same issue as `Gauge.track_inprogress()`: the opentracing span only measures the creation of the coroutine and none of the actual function body. Using `Gauge.track_inprogress()` as a context manager instead of a decorator resolves both bugs.	3 years ago
Brendan Abolivier	8c5255b664	1.45.0rc1	3 years ago
reivilibre	406f7bfa17	Add an approximate difference method to StateFilters (#10825 )	3 years ago
David Robertson	e0f11ae4a5	disallow-untyped-defs for synapse.push (#11023 )	3 years ago
reivilibre	3828dd819b	Pass through `SynapseError`s that are raised from experimental `check_event_allowed` callback of the module API (#11042 ) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	3 years ago
Eric Eastwood	a7d22c36db	Refactor MSC2716 `/batch_send` endpoint into separate handler functions (#10974 )	3 years ago
Patrick Cloke	1b112840d2	Autodiscover oEmbed endpoint from returned HTML (#10822 ) Searches the returned HTML for an oEmbed endpoint using the autodiscovery mechanism (`<link rel=...>`), and will request it to generate the preview.	3 years ago
David Robertson	51a5da74cc	Annotate synapse.storage.util (#10892 ) Also mark `synapse.streams` as having has no untyped defs Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	3 years ago
David Robertson	797ee7812d	Relax `ignore-missing-imports` for modules that have stubs now and update mypy (#11006 ) Updating mypy past version 0.9 means that third-party stubs are no-longer distributed with typeshed. See http://mypy-lang.blogspot.com/2021/06/mypy-0900-released.html for details. We therefore pull in stub packages in setup.py Additionally, some modules that we were previously ignoring import failures for now have stubs. So let's use them. The rest of this change consists of fixups to make the newer mypy + stubs pass CI. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	3 years ago
David Robertson	670a8d9a1e	Fix overwriting profile when making room public (#11003 ) This splits apart `handle_new_user` into a function which adds an entry to the `user_directory` and a function which updates the room sharing tables. I plan to continue doing more of this kind of refactoring to clarify the implementation.	3 years ago
Patrick Cloke	eb9ddc8c2e	Remove the deprecated BaseHandler. (#11005 ) The shared ratelimit function was replaced with a dedicated RequestRatelimiter class (accessible from the HomeServer object). Other properties were copied to each sub-class that inherited from BaseHandler.	3 years ago
Sean Quah	49a683d871	Fix long-standing bug where `ReadWriteLock` could drop logging contexts (#10993 ) Use `PreserveLoggingContext()` to ensure that logging contexts are not lost when exiting a read/write lock. When exiting a read/write lock, callbacks on a `Deferred` are triggered as a signal to any waiting coroutines. Any waiting coroutine that becomes runnable is likely to follow the Synapse logging context rules and will restore its own logging context, then either run to completion or await another `Deferred`, resetting the logging context in the process.	3 years ago
Nick Barrett	bb228f3523	Include exception in json logging (#11028 )	3 years ago
David Robertson	e79ee48313	disallow-untyped-defs for synapse.server_notices (#11021 )	3 years ago
David Robertson	e0bf34dada	Don't alter directory entries for local users when setting a per-room nickname (#11002 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	3 years ago
Richard van der Hoff	96fe77c254	Improve the logging in _auth_and_persist_outliers (#11010 ) Include the event ids being peristed	3 years ago
Richard van der Hoff	86af6b2f0e	Add a comment in _process_received_pdu (#11011 )	3 years ago
Brendan Abolivier	52aefd5086	Catch AttributeErrors when calling registerProducer (#10995 ) Looks like the wrong exception type was caught in #10932.	3 years ago
David Robertson	f563676c09	`disallow-untyped-defs` for `synapse.state` (#11004 ) * `disallow-untyped-defs` for `synapse.state` Much smaller than I was expecting!	3 years ago
Brendan Abolivier	4e51621064	Add a spamchecker method to allow or deny 3pid invites (#10894 ) This is in the context of creating new module callbacks that modules in https://github.com/matrix-org/synapse-dinsic can use, in an effort to reconcile the spam checker API in synapse-dinsic with the one in mainline. Note that a module callback already exists for 3pid invites (https://matrix-org.github.io/synapse/develop/modules/third_party_rules_callbacks.html#check_threepid_can_be_invited) but it doesn't check whether the sender of the invite is allowed to send it.	3 years ago
Patrick Cloke	f4b1a9a527	Require direct references to configuration variables. (#10985 ) This removes the magic allowing accessing configurable variables directly from the config object. It is now required that a specific configuration class is used (e.g. `config.foo` must be replaced with `config.server.foo`).	3 years ago
Brendan Abolivier	829f2a82b0	Add a spamchecker callback to allow or deny room joins (#10910 ) Co-authored-by: Erik Johnston <erik@matrix.org>	3 years ago
David Robertson	370bca32e6	Don't drop user dir deltas when server leaves room (#10982 ) Fix a long-standing bug where a batch of user directory changes would be silently dropped if the server left a room early in the batch. * Pull out `wait_for_background_update` in tests Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	3 years ago
David Robertson	f8d0f72b27	More types for synapse.util, part 1 (#10888 ) The following modules now pass `disallow_untyped_defs`: * synapse.util.caches.cached_call * synapse.util.caches.lrucache * synapse.util.caches.response_cache * synapse.util.caches.stream_change_cache * synapse.util.caches.ttlcache pass * synapse.util.daemonize * synapse.util.patch_inline_callbacks pass `no-untyped-defs` * synapse.util.versionstring Additional typing in synapse.util.metrics. Didn't get this to pass `no-untyped-defs`, think I'll need to watch #10847	3 years ago
David Robertson	4f00432ce1	Fix potential leak of per-room profiles when the user dir is rebuilt. (#10981 ) There are two steps to rebuilding the user directory: 1. a scan over rooms, followed by 2. a scan over local users. The former reads avatars and display names from the `room_memberships` table and therefore contains potentially private avatars and display names. The latter reads from the the `profiles` table which only contains public data; moreover it will overwrite any private profiles that the rooms scan may have written to the user directory. This means that the rebuild could leak private user while the rebuild was in progress, only to later cover up the leaks once the rebuild had completed. This change skips over local users when writing user_directory rows when scanning rooms. Doing so means that it'll take longer for a rebuild to make local users searchable, which is unfortunate. I think a future PR can improve this by swapping the order of the two steps above. (And indeed there's more to do here, e.g. copying from `profiles` without going via Python.) Small tidy-ups while I'm here: * Remove duplicated code from test_initial. This was meant to be pulled into `purge_and_rebuild_user_dir`. * Move `is_public` before updating sharing tables. No functional change; it's still before the first read of `is_public`. * Don't bother creating a set from dict keys. Slightly nicer and makes the code simpler. Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	3 years ago
Eric Eastwood	392863fbf1	Fix logic flaw preventing tracking of MSC2716 events in existing room versions (#10962 ) We correctly allowed using the MSC2716 batch endpoint for the room creator in existing room versions but accidentally didn't track the events because of a logic flaw. This prevented you from connecting subsequent chunks together because it would throw the unknown batch ID error. We only want to process MSC2716 events when: - The room version supports MSC2716 - Any room where the homeserver has the `msc2716_enabled` experimental feature enabled and the event is from the room creator	3 years ago
Brendan Abolivier	b2c5e79291	1.44.0	3 years ago
Richard van der Hoff	3a5b0cbe7a	Ensure that we reject events which use rejected events for auth (#10956 ) When we consider whether to accept events, we should not accept those which depend on rejected events for their auth events. This (together with earlier changes such as https://github.com/matrix-org/synapse/pull/10771 and https://github.com/matrix-org/synapse/pull/10896) forms a partial fix to https://github.com/matrix-org/synapse/issues/9595. There still remain code paths where we do not check the `auth_events` at all.	3 years ago
Richard van der Hoff	787af4a106	Host `cache_joined_hosts_for_event` to caller (#10986 ) `_check_event_auth` is only called in two places, and only one of those sets `send_on_behalf_of`. Warming the cache isn't really part of auth anyway, so moving it out makes a lot more sense.	3 years ago
Richard van der Hoff	d099535deb	`_update_auth_events_and_context_for_auth`: add some comments (#10987 ) Add some more comments about wtf is going on here.	3 years ago
Richard van der Hoff	cb88ed912b	`_check_event_auth`: move event validation earlier (#10988 ) There's little point in doing a fancy state reconciliation dance if the event itself is invalid. Likewise, there's no point checking it again in `_check_for_soft_fail`.	3 years ago
Sean Quah	660c8c1415	Log stack traces when a missing opentracing span is detected (#10983 ) Make it easier to track down where opentracing spans are going missing by including stack traces in the logs.	3 years ago
Hillery Shay	eda8c88b84	Add functionality to remove deactivated users from the monthly_active_users table (#10947 ) * add test * add function to remove user from monthly active table in deactivate code * add function to remove user from monthly active table * add changelog entry * update changelog number * requested changes * update docstring on new function * fix lint error * Update synapse/storage/databases/main/monthly_active_users.py Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	3 years ago
Brendan Abolivier	2d2c6a41fe	1.44.0rc3	3 years ago
David Robertson	f7b034a24b	Consistently exclude from user_directory (#10960 ) * Introduce `should_include_local_users_in_dir` We exclude three kinds of local users from the user_directory tables. At present we don't consistently exclude all three in the same places. This commit introduces a new function to gather those exclusion conditions together. Because we have to handle local and remote users in different ways, I've made that function only consider the case of remote users. It's the caller's responsibility to make the local versus remote distinction clear and correct. A test fixup is required. The test now hits a path which makes db queries against the users table. The expected rows were missing, because we were using a dummy user that hadn't actually been registered. We also add new test cases to covert the exclusion logic. ---- By my reading this makes these changes: * When an app service user registers or changes their profile, they will _not_ be added to the user directory. (Previously only support and deactivated users were excluded). This is consistent with the logic that rebuilds the user directory. See also [the discussion here](https://github.com/matrix-org/synapse/pull/10914#discussion_r716859548). * When rebuilding the directory, exclude support and disabled users from room sharing tables. Previously only appservice users were excluded. * Exclude all three categories of local users when rebuilding the directory. Previously `_populate_user_directory_process_users` didn't do any exclusion. Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	3 years ago
Patrick Cloke	a0f48ee89d	Use direct references for configuration variables (part 7). (#10959 )	3 years ago
Sean Quah	d1cbad388f	Fix error in `get_user_ip_and_agents` when fetching from the database (#10968 )	3 years ago
Patrick Cloke	32072dcdac	Strip "join_authorised_via_users_server" from join events which do not need it. (#10933 ) This fixes a "Event not signed by authorising server" error when transition room member from join -> join, e.g. when updating a display name or avatar URL for restricted rooms.	3 years ago
Patrick Cloke	7e440520c9	Add type hints to filtering classes. (#10958 )	3 years ago
Patrick Cloke	9e5a429c8b	Clean-up registration tests (#10945 ) Uses `override_config` and fixes test_auto_create_auto_join_where_no_consent to properly configure auto-join rooms.	3 years ago
Patrick Cloke	d1bf5f7c9d	Strip "join_authorised_via_users_server" from join events which do not need it. (#10933 ) This fixes a "Event not signed by authorising server" error when transition room member from join -> join, e.g. when updating a display name or avatar URL for restricted rooms.	3 years ago
Lukas Lihotzki	145cb6d08e	Fix getTurnServer response: return an integer ttl (#10922 ) `ttl` must be an integer according to the OpenAPI spec: https://github.com/matrix-org/matrix-doc/blob/old_master/data/api/client-server/voip.yaml#L70 True division (`/`) returns a float instead (`"ttl": 7200.0`). Floor division (`//`) returns an integer, so the response is spec compliant. Signed-off-by: Lukas Lihotzki <lukas@lihotzki.de>	3 years ago
David Robertson	29364145b2	Pass str to twisted's IReactorTCP (#10895 ) This follows a correction made in twisted/twisted#1664 and should fix our Twisted Trial CI job. Until that change is in a twisted release, we'll have to ignore the type of the `host` argument. I've raised #10899 to remind us to review the issue in a few months' time.	3 years ago
Olivier Wilkinson (reivilibre)	3412f5c8d8	1.44.0rc2	3 years ago
Eric Eastwood	c4bf48ee6f	Fix event context for outliers in important MSC2716 spot (#10938 ) Fix event context for outlier causing failures in all of the MSC2716 Complement tests. The `EventContext.for_outlier` refactor happened in https://github.com/matrix-org/synapse/pull/10883 and this spot was left out.	3 years ago

1 2 3 4 5 ...

13718 Commits (988de0afb0469d9ee85fedcd7f1eb34af7d28db5)