watcha-synapse

Commit Graph

Author	SHA1	Message	Date
BramvdnHeuvel	9f111075e8	Fix copy-paste error in the password section of the sample-config. (#10804 )	3 years ago
Patrick Cloke	003846d68a	Use the BaseReporter super-class for _WrappedRustReporter. (#10799 ) This fixes mypy errors with jaeger-client >= 4.7.0 and should be a no-op for versions before that.	3 years ago
reivilibre	524b8ead77	Add types to synapse.util. (#10601 )	3 years ago
Patrick Cloke	63f28e4a0c	Handle room upgrades for spaces (#10774 ) By copying the `room_type` field of the create event and migrating any non-empty `m.space.child` events to the new room that is created.	3 years ago
David Robertson	318162f5de	Easy refactors of the user directory (#10789 ) No functional changes here. This came out as I was working to tackle #5677	3 years ago
AndrewFerr	0c0da36a68	Ask consent on SSO registration with default mxid (#10733 ) Fixes #10732: consent flow skipped during SSO user registration if username is left at default Signed-off-by: Andrew Ferrazzutti fair@miscworks.net	3 years ago
Erik Johnston	7f0565e029	Don't needlessly batch in `add_event_to_cache` (#10784 ) We've already batched up the events previously, and assume in other places in the events.py file that we have. Removing this makes it easier to adjust the batch sizes in one place.	3 years ago
Sean	273b6861f2	Remove unstable MSC2858 API, including `experimental.msc2858_enabled` config option (#10693 ) Signed-off-by: Sean Quah <seanq@element.io>	3 years ago
Patrick Cloke	a621ba0259	Prefer room v9 for restricted rooms. (#10772 ) Hint to clients via the room capabilities API (MSC3244) that room version 9 should be preferred for creating a room with restricted join rules (instead of room version 8).	3 years ago
Richard van der Hoff	abedf7d77f	Get rid of `_auth_and_persist_event` (#10781 ) This is only called in two places, and the code seems much clearer without it.	3 years ago
Patrick Cloke	1fdf2cf8e8	Document that /spaces & /hierarchy can be routed to workers. (#10648 ) Also refactors some of the registration of endpoints on workers.	3 years ago
Erik Johnston	74f01e11c9	Skip handling of push actions for outlier events (#10780 ) Outlier events don't ever have push actions associated with them, so we can skip some expensive queries during event persistence.	3 years ago
Patrick Cloke	0288e6033b	Add a constant for m.federate. (#10775 )	3 years ago
Erik Johnston	66d72b7e17	Change logging of puppeted requests to better differentiate users (#10779 ) This used to be a comma and got accidentally changed to a period in #9654, but a pipe character is more easier to parse visually.	3 years ago
Patrick Cloke	580a15e039	Request JSON for oEmbed requests (and ignore XML only providers). (#10759 ) This adds the format to the request arguments / URL to ensure that JSON data is returned (which is all that Synapse supports). This also adds additional error checking / filtering to the configuration file to ignore XML-only providers.	3 years ago
Richard van der Hoff	aacdce8fc0	Add some assertions about outliers (#10773 ) I think I have finally teased apart the codepaths which handle outliers, and those that handle non-outliers. Let's add some assertions to demonstrate my newfound knowledge.	3 years ago
Richard van der Hoff	5724883ac2	Persist auth events before the events that rely on them (#10771 ) If we're persisting an event E which has auth_events A1, A2, then we ought to make sure that we correctly auth and persist A1 and A2, before we blindly accept E. This PR does part of that - it persists the auth events first - but it does not fully solve the problem, because we still don't check that the auth events weren't rejected.	3 years ago
Azrenbeth	6631321687	1.42.0	3 years ago
Patrick Cloke	89ba834818	Use attrs internally for the URL preview code & add documentation. (#10753 )	3 years ago
Patrick Cloke	a23f3abb9b	Return stripped m.space.child events via the space summary. (#10760 ) The full event content cannot be trusted from this API (as no auth chain, etc.) is processed over federation. Returning the full event content was a bug as MSC2946 specifies that only the stripped state should be returned. This also avoids calculating aggregations / annotations which go unused.	3 years ago
Richard van der Hoff	f30c9745ab	Underscore-prefix private fields in `FederationEventHandler` (#10746 )	3 years ago
Azrenbeth	f1c6b76418	Add logging to help debug #9424 (#10704 )	3 years ago
Azrenbeth	6e895366ea	Add config option to use non-default manhole password and keys (#10643 )	3 years ago
Brendan Abolivier	e9958d908d	1.42.0rc2	3 years ago
Brendan Abolivier	8c9e723fe0	Add a warning when using deprecated template_dir settings (#10768 ) The deprecation itself happened in #10596 which shipped with Synapse v1.41.0. However, it doesn't seem fair to suddenly drop support for these settings in ~4-6w without being more vocal about said deprecation.	3 years ago
Richard van der Hoff	b298de780a	Stop using BaseHandler in `FederationEventHandler` (#10745 ) It's now only used in a couple of places, so we can drop it altogether.	3 years ago
Andrew Morgan	40a1fddd1b	Allow `room_alias_name` parameter to be handled by /createRoom calls on workers (#10757 )	3 years ago
Andrew Morgan	7bb3673f37	Ease searching for M_TOO_LARGE-related error codes (#10750 )	3 years ago
Richard van der Hoff	56e2a30634	Move `maybe_kick_guest_users` out of `BaseHandler` (#10744 ) This is part of my ongoing war against BaseHandler. I've moved kick_guest_users into RoomMemberHandler (since it calls out to that handler anyway), and split maybe_kick_guest_users into the two places it is called.	3 years ago
Erik Johnston	2ca0d64854	Speed up persisting redacted events (#10756 )	3 years ago
Eric Eastwood	1ca70fd312	Allow room creator to send MSC2716 related events in existing room versions (#10566 ) * Allow room creator to send MSC2716 related events in existing room versions Discussed at https://github.com/matrix-org/matrix-doc/pull/2716/#discussion_r682474869 Restoring `get_create_event_for_room_txn` from, `44bb3f0cf5` * Add changelog * Stop people from trying to redact MSC2716 events in unsupported room versions * Populate rooms.creator column for easy lookup > From some [out of band discussion](https://matrix.to/#/!UytJQHLQYfvYWsGrGY:jki.re/$p2fKESoFst038x6pOOmsY0C49S2gLKMr0jhNMz_JJz0?via=jki.re&via=matrix.org), my plan is to use `rooms.creator`. But currently, we don't fill in `creator` for remote rooms when a user is invited to a room for example. So we need to add some code to fill in `creator` wherever we add to the `rooms` table. And also add a background update to fill in the rows missing `creator` (we can use the same logic that `get_create_event_for_room_txn` is doing by looking in the state events to get the `creator`). > > https://github.com/matrix-org/synapse/pull/10566#issuecomment-901616642 * Remove and switch away from get_create_event_for_room_txn * Fix no create event being found because no state events persisted yet * Fix and add tests for rooms creator bg update * Populate rooms.creator field for easy lookup Part of https://github.com/matrix-org/synapse/pull/10566 - Fill in creator whenever we insert into the rooms table - Add background update to backfill any missing creator values * Add changelog * Fix usage * Remove extra delta already included in #10697 * Don't worry about setting creator for invite * Only iterate over rows missing the creator See https://github.com/matrix-org/synapse/pull/10697#discussion_r695940898 * Use constant to fetch room creator field See https://github.com/matrix-org/synapse/pull/10697#discussion_r696803029 * More protection from other random types See https://github.com/matrix-org/synapse/pull/10697#discussion_r696806853 * Move new background update to end of list See https://github.com/matrix-org/synapse/pull/10697#discussion_r696814181 * Fix query casing * Fix ambiguity iterating over cursor instead of list Fix `psycopg2.ProgrammingError: no results to fetch` error when tests run with Postgres. ``` SYNAPSE_POSTGRES=1 SYNAPSE_TEST_LOG_LEVEL=INFO python -m twisted.trial tests.storage.databases.main.test_room ``` --- We use `txn.fetchall` because it will return the results as a list or an empty list when there are no results. Docs: > `cursor` objects are iterable, so, instead of calling explicitly fetchone() in a loop, the object itself can be used: > > https://www.psycopg.org/docs/cursor.html#cursor-iterable And I'm guessing iterating over a raw cursor does something weird when there are no results. --- Test CI failure: https://github.com/matrix-org/synapse/pull/10697/checks?check_run_id=3468916530 ``` tests.test_visibility.FilterEventsForServerTestCase.test_large_room =============================================================================== [FAIL] Traceback (most recent call last): File "/home/runner/work/synapse/synapse/tests/storage/databases/main/test_room.py", line 85, in test_background_populate_rooms_creator_column self.get_success( File "/home/runner/work/synapse/synapse/tests/unittest.py", line 500, in get_success return self.successResultOf(d) File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/trial/_synctest.py", line 700, in successResultOf self.fail( twisted.trial.unittest.FailTest: Success result expected on <Deferred at 0x7f4022f3eb50 current result: None>, found failure result instead: Traceback (most recent call last): File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/internet/defer.py", line 701, in errback self._startRunCallbacks(fail) File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/internet/defer.py", line 764, in _startRunCallbacks self._runCallbacks() File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/internet/defer.py", line 858, in _runCallbacks current.result = callback( # type: ignore[misc] File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/internet/defer.py", line 1751, in gotResult current_context.run(_inlineCallbacks, r, gen, status) --- <exception caught here> --- File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/internet/defer.py", line 1657, in _inlineCallbacks result = current_context.run( File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/python/failure.py", line 500, in throwExceptionIntoGenerator return g.throw(self.type, self.value, self.tb) File "/home/runner/work/synapse/synapse/synapse/storage/background_updates.py", line 224, in do_next_background_update await self._do_background_update(desired_duration_ms) File "/home/runner/work/synapse/synapse/synapse/storage/background_updates.py", line 261, in _do_background_update items_updated = await update_handler(progress, batch_size) File "/home/runner/work/synapse/synapse/synapse/storage/databases/main/room.py", line 1399, in _background_populate_rooms_creator_column end = await self.db_pool.runInteraction( File "/home/runner/work/synapse/synapse/synapse/storage/database.py", line 686, in runInteraction result = await self.runWithConnection( File "/home/runner/work/synapse/synapse/synapse/storage/database.py", line 791, in runWithConnection return await make_deferred_yieldable( File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/internet/defer.py", line 858, in _runCallbacks current.result = callback( # type: ignore[misc] File "/home/runner/work/synapse/synapse/tests/server.py", line 425, in <lambda> d.addCallback(lambda x: function(args, kwargs)) File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/enterprise/adbapi.py", line 293, in _runWithConnection compat.reraise(excValue, excTraceback) File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/python/deprecate.py", line 298, in deprecatedFunction return function(args, *kwargs) File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/python/compat.py", line 404, in reraise raise exception.with_traceback(traceback) File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/enterprise/adbapi.py", line 284, in _runWithConnection result = func(conn, args, *kw) File "/home/runner/work/synapse/synapse/synapse/storage/database.py", line 786, in inner_func return func(db_conn, args, *kwargs) File "/home/runner/work/synapse/synapse/synapse/storage/database.py", line 554, in new_transaction r = func(cursor, args, *kwargs) File "/home/runner/work/synapse/synapse/synapse/storage/databases/main/room.py", line 1375, in _background_populate_rooms_creator_column_txn for room_id, event_json in txn: psycopg2.ProgrammingError: no results to fetch ``` Move code not under the MSC2716 room version underneath an experimental config option See https://github.com/matrix-org/synapse/pull/10566#issuecomment-906437909 * Add ordering to rooms creator background update See https://github.com/matrix-org/synapse/pull/10697#discussion_r696815277 * Add comment to better document constant See https://github.com/matrix-org/synapse/pull/10697#discussion_r699674458 * Use constant field	3 years ago
Erik Johnston	92b6ac31b2	Speed up MultiWriterIdGenerator when lots of IDs are in flight. (#10755 )	3 years ago
Patrick Cloke	ae3c16318b	Support MSC3375: room version 9. (#10747 )	3 years ago
Sean	924276f482	Add a partial index to `presence_stream` to speed up startups (#10748 ) Signed-off-by: Sean Quah <seanq@element.io>	3 years ago
Erik Johnston	0eae330a26	Use `execute_values` more in PostgreSQL (#10754 ) `execute_values` is a faster version of `execute_batch`.	3 years ago
Patrick Cloke	2cb85bdf75	Raise an error if an unknown preset is used to create a room. (#10738 ) Raises a 400 error instead of a 500 if an unknown preset is passed from a client to create a room.	3 years ago
Patrick Cloke	ecbfa4fe4f	Additional type hints for client REST servlets (part 5) (#10736 ) Additionally this enforce type hints on all function signatures inside of the synapse.rest.client package.	3 years ago
Erik Johnston	f58d202e3f	Fix bug with reusing 'txn' when persisting event. (#10743 ) This will only happen when a server has multiple out of band membership events in a single room.	3 years ago
Patrick Cloke	c586d6803a	Ignore rooms with unknown room versions in the spaces summary. (#10727 ) This avoids breaking the entire endpoint if a room with an unsupported room version is encountered.	3 years ago
Patrick Cloke	6258730ebe	Consider the `origin_server_ts` of the `m.space.child` event when ordering rooms. (#10730 ) This updates the ordering of the returned events from the spaces summary API to that defined in MSC2946 (which updates MSC1772). Previously a step was skipped causing ordering to be inconsistent with clients.	3 years ago
Patrick Cloke	d1f1b46c2c	Additional type hints for client REST servlets (part 4) (#10728 )	3 years ago
Eric Eastwood	dc75fb7f05	Populate `rooms.creator` field for easy lookup (#10697 ) Part of https://github.com/matrix-org/synapse/pull/10566 - Fill in creator whenever we insert into the rooms table - Add background update to backfill any missing creator values	3 years ago
David Robertson	d9069388f3	Correctly include room avatars in email notifications (#10658 ) Judging by the template, this was intended ages ago, but we never actually passed an avatar URL to the template. So let's provide one. Closes #1546. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	3 years ago
Sean	f8bf83b811	Skip the final GC on shutdown to improve restart times (#10712 ) Use `gc.freeze()` on exit to exclude all existing objects from the final GC. In testing, this sped up shutdown by up to a few seconds. `gc.freeze()` runs in constant time, so there is little chance of performance regression. Signed-off-by: Sean Quah <seanq@element.io>	3 years ago
Olivier Wilkinson (reivilibre)	6b2aca473a	1.42.0rc1	3 years ago
Andrew Morgan	3693ea61f5	Fix iteration in _remove_deleted_email_pushers background job. (#10734 )	3 years ago
Patrick Cloke	e2481dbe93	Allow configuration of the oEmbed URLs. (#10714 ) This adds configuration options (under an `oembed` section) to configure which URLs are matched to use oEmbed for URL previews.	3 years ago
Patrick Cloke	287918e2d4	Additional type hints for the client REST servlets (part 3). (#10707 )	3 years ago
Patrick Cloke	78e590d473	Move the sessions delta to the latest schema version. (#10725 ) This was erroneously put under schema version 62 instead of 63.	3 years ago
Richard van der Hoff	a4c8a2f08b	1.41.1	3 years ago

1 2 3 4 5 ...

13589 Commits (9f111075e8204dd55e141f04d78e06c718892956)