579 Commits (9fbaed325f7e3ed4edff25636043b885b1cf388d)

Author	SHA1	Message	Date
Erik Johnston	c2c153dd3b	Log more detail when we fail to authenticate request	6 years ago
Erik Johnston	808d8e06aa	Don't log exceptions when failing to fetch server keys ... Not being able to resolve or connect to remote servers is an expected error, so we shouldn't log at ERROR with stacktraces.	6 years ago
Amber Brown	c334ca67bb	Integrate presence from hotfixes (#3694)	6 years ago
Amber Brown	b37c472419	Rename async to async_helpers because `async` is a keyword on Python 3.7 (#3678)	6 years ago
Erik Johnston	72d1902bbe	Fixup doc comments	6 years ago
Richard van der Hoff	53bca4690b	more metrics for the federation and appservice senders	6 years ago
Richard van der Hoff	19a17068f1	Check m.room.create for sane room_versions	6 years ago
Erik Johnston	a3f5bf79a0	Add EDU/query handling over replication	6 years ago
Richard van der Hoff	f900d50824	include known room versions in outgoing make_joins	6 years ago
Richard van der Hoff	3777fa26aa	sanity check response from make_join	6 years ago
Richard van der Hoff	0d63d93ca8	Enforce compatibility when processing make_join requests ... Reject make_join requests from servers which do not support the room version. Also include the room version in the response.	6 years ago
Richard van der Hoff	15c1ae45e5	Docstrings for BaseFederationServlet ... ... to save me reverse-engineering this stuff again.	6 years ago
Richard van der Hoff	0a65450d04	Validation for events/rooms in fed requests ... When we get a federation request which refers to an event id, make sure that said event is in the room the caller claims it is in. (patch supplied by @turt2live)	6 years ago
Richard van der Hoff	018d75a148	Refactor code for turning HttpResponseException into SynapseError ... This commit replaces SynapseError.from_http_response_exception with HttpResponseException.to_synapse_error. The new method actually returns a ProxiedRequestError, which allows us to pass through additional metadata from the API call.	6 years ago
Richard van der Hoff	fa7dc889f1	Be more careful which errors we send back over the C-S API ... We really shouldn't be sending all CodeMessageExceptions back over the C-S API; it will include things like 401s which we shouldn't proxy. That means that we need to explicitly turn a few HttpResponseExceptions into SynapseErrors in the federation layer. The effect of the latter is that the matrix errcode will get passed through correctly to calling clients, which might help with some of the random M_UNKNOWN errors when trying to join rooms.	6 years ago
Richard van der Hoff	c82ccd3027	Factor out exception handling in federation_client ... Factor out the error handling from make_membership_event, send_join, and send_leave, so that it can be shared.	6 years ago
Amber Brown	da7785147d	Python 3: Convert some unicode/bytes uses (#3569)	6 years ago
Travis Ralston	37be52ac34	limt -> limit	6 years ago
Travis Ralston	e908b86832	Remove pdu_failures from transactions ... The field is never read from, and all the opportunities given to populate it are not utilized. It should be very safe to remove this.	6 years ago
Travis Ralston	7d32f0d745	Update the send_leave path to be an event_id ... It's still not used, however the parameter is an event ID not a transaction ID.	6 years ago
Richard van der Hoff	ce0c18dec5	Improve logging for exceptions handling PDUs ... when we get an exception handling a federation PDU, log the whole stacktrace.	6 years ago
Richard van der Hoff	667fba68f3	Run things as background processes ... This fixes #3518, and ensures that we get useful logs and metrics for lots of things that happen in the background. (There are certainly more things that happen in the background; these are just the common ones I've found running a single-process synapse locally).	6 years ago
Richard van der Hoff	6e3fc657b4	Resource tracking for background processes ... This introduces a mechanism for tracking resource usage by background processes, along with an example of how it will be used. This will help address #3518, but more importantly will give us better insights into things which are happening but not being shown up by the request metrics. We *could* do this with Measure blocks, but: - I think having them pulled out as a completely separate metric class will make it easier to distinguish top-level processes from those which are nested. - I want to be able to report on in-flight background processes, and I don't think we want to do this for *all* Measure blocks.	6 years ago
Krombel	3366b9c534	rename assert_params_in_request to assert_params_in_dict ... the method "assert_params_in_request" does handle dicts and not requests. A request body has to be parsed to json before this method can be used	6 years ago
Amber Brown	49af402019	run isort	6 years ago
Richard van der Hoff	3cf3e08a97	Implementation of server_acls ... ... as described at https://docs.google.com/document/d/1EttUVzjc2DWe2ciw4XPtNpUpIl9lWXGEsy2ewDS7rtw.	6 years ago
Richard van der Hoff	546bc9e28b	More server_name validation ... We need to do a bit more validation when we get a server name, but don't want to be re-doing it all over the shop, so factor out a separate parse_and_validate_server_name, and do the extra validation. Also, use it to verify the server name in the config file.	6 years ago
Richard van der Hoff	508196e08a	Reject invalid server names (#3480) ... Make sure that server_names used in auth headers are sane, and reject them with a sensible error code, before they disappear off into the depths of the system.	6 years ago
Amber Brown	6350bf925e	Attempt to be more performant on PyPy (#3462)	7 years ago
Amber Brown	77078d6c8e	handle federation not telling us about prev_events	7 years ago
Amber Brown	c2eff937ac	Populate synapse_federation_client_sent_pdu_destinations:count again (#3386)	7 years ago
Amber Brown	a61738b316	Remove run_on_reactor (#3395)	7 years ago
Richard van der Hoff	9fc5b74b24	simplify get_persisted_pdu ... it doesn't make much sense to use get_persisted_pdu on the receive path: just get the event straight from the store.	7 years ago
Ivan Shapovalov	c88d50aa8f	federation/send_queue.py: fix usage of sortedcontainers.SortedDict	7 years ago
Amber Brown	f7869f8f8b	Port to sortedcontainers (with tests!) (#3332)	7 years ago
Ivan Shapovalov	7d9d75e4e8	federation/send_queue.py: fix usage of LaterGauge ... Fixes a startup crash due to commit df9f72d9e5 "replacing portions".	7 years ago
Amber Brown	c936a52a9e	Consistently use six's iteritems and wrap lazy keys/values in list() if they're not meant to be lazy (#3307)	7 years ago
Amber Brown	e987079037	fixes	7 years ago
Amber Brown	53cc2cde1f	cleanup	7 years ago
Amber Brown	071206304d	cleanup pep8 errors	7 years ago
Amber Brown	85ba83eb51	fixes	7 years ago
Amber Brown	df9f72d9e5	replacing portions	7 years ago
Damir Manapov	db18d854cd	transaction_id, destination twice	7 years ago
Richard van der Hoff	33f469ba19	Apply some limits to depth to counter abuse ... * When creating a new event, cap its depth to 2^63 - 1 * When receiving events, reject any without a sensible depth As per https://docs.google.com/document/d/1I3fi2S-XnpO45qrpCsowZv8P8dHcNZ4fsBsbOW7KABI	7 years ago
Adrian Tschira	d82b6ea9e6	Move more xrange to six ... plus a bonus next() Signed-off-by: Adrian Tschira <nota@notafile.com>	7 years ago
Richard van der Hoff	2a13af23bc	Use run_in_background in preference to preserve_fn ... While I was going through uses of preserve_fn for other PRs, I converted places which only use the wrapped function once to use run_in_background, to avoid creating the function object.	7 years ago
Richard van der Hoff	9255a6cb17	Improve exception handling for background processes ... There were a bunch of places where we fire off a process to happen in the background, but don't have any exception handling on it - instead relying on the unhandled error being logged when the relevent deferred gets garbage-collected. This is unsatisfactory for a number of reasons: - logging on garbage collection is best-effort and may happen some time after the error, if at all - it can be hard to figure out where the error actually happened. - it is logged as a scary CRITICAL error which (a) I always forget to grep for and (b) it's not really CRITICAL if a background process we don't care about fails. So this is an attempt to add exception handling to everything we fire off into the background.	7 years ago
Richard van der Hoff	0c280d4d99	Reinstate linearizer for federation_server.on_context_state_request	7 years ago
Richard van der Hoff	b1dfbc3c40	Refactor store.have_events ... It turns out that most of the time we were calling have_events, we were only using half of the result. Replace have_events with have_seen_events and get_rejection_reasons, so that we can see what's going on a bit more clearly.	7 years ago
Richard van der Hoff	1f4b498b73	Add some comments	7 years ago