watcha-synapse

Commit Graph

Author	SHA1	Message	Date
Patrick Cloke	94b620a5ed	Use direct references for configuration variables (part 6). (#10916 )	3 years ago
Erik Johnston	37bb93d181	Fix exception responding to request that has been closed (#10932 ) Introduced in #10905	3 years ago
Erik Johnston	707d5e4e48	Encode JSON responses on a thread in C, mk2 (#10905 ) Currently we use `JsonEncoder.iterencode` to write JSON responses, which ensures that we don't block the main reactor thread when encoding huge objects. The downside to this is that `iterencode` falls back to using a pure Python encoder that is much less efficient and can easily burn a lot of CPU for huge responses. To fix this, while still ensuring we don't block the reactor loop, we encode the JSON on a threadpool using the standard `JsonEncoder.encode` functions, which is backed by a C library. Doing so, however, requires `respond_with_json` to have access to the reactor, which it previously didn't. There are two ways of doing this: 1. threading through the reactor object, which is a bit fiddly as e.g. `DirectServeJsonResource` doesn't currently take a reactor, but is exposed to modules and so is a PITA to change; or 2. expose the reactor in `SynapseRequest`, which requires updating a bunch of servlet types. I went with the latter as that is just a mechanical change, and I think makes sense as a request already has a reactor associated with it (via its http channel).	3 years ago
Erik Johnston	50022cff96	Add reactor to `SynapseRequest` and fix up types. (#10868 )	3 years ago
Patrick Cloke	47854c71e9	Use direct references for configuration variables (part 4). (#10893 )	3 years ago
Andrew Morgan	aa2c027792	Remove unnecessary parentheses around tuples returned from methods (#10889 )	3 years ago
Erik Johnston	b25a494779	Add types to http.site (#10867 )	3 years ago
Patrick Cloke	8c7a531e27	Use direct references for some configuration variables (part 2) (#10812 )	3 years ago
Sean Quah	14b8c0476f	Prevent logging context going missing on federation request timeout (#10810 ) In `MatrixFederationHttpClient._send_request()`, we make a HTTP request using an `Agent`, wrap that request in a timeout and await the resulting `Deferred`. On its own, the `Agent` performing the HTTP request correctly stashes and restores the logging context while waiting. The addition of the timeout introduces a path where the logging context is not restored when execution resumes. To address this, we wrap the timeout `Deferred` in a `make_deferred_yieldable()` to stash the logging context and restore it on completion of the `await`. However this is not sufficient, since by the time we construct the timeout `Deferred`, the `Agent` has already stashed and cleared the logging context when using `make_deferred_yieldable()` to produce its `Deferred` for the request. Hence, we wrap the `Agent` request in a `run_in_background()` to "fork" and preserve the logging context so that we can stash and restore it when `await`ing the timeout `Deferred`. This approach is similar to the one used with `defer.gatherResults`. Note that the code is still not fully correct. When a timeout occurs, the request remains running in the background (existing behavior which is nothing to do with the new call to `run_in_background`) and may re-start the logging context after it has finished.	3 years ago
Erik Johnston	66d72b7e17	Change logging of puppeted requests to better differentiate users (#10779 ) This used to be a comma and got accidentally changed to a period in #9654, but a pipe character is more easier to parse visually.	3 years ago
Patrick Cloke	ecbfa4fe4f	Additional type hints for client REST servlets (part 5) (#10736 ) Additionally this enforce type hints on all function signatures inside of the synapse.rest.client package.	3 years ago
Dirk Klimpel	0c3565da4c	Additional type hints for the proxy agent and SRV resolver modules. (#10608 )	3 years ago
Michael Telatynski	0ace38b7b3	Experimental support for MSC3266 Room Summary API. (#10394 )	3 years ago
Dirk Klimpel	339c3918e1	support federation queries through http connect proxy (#10475 ) Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu> Signed-off-by: Dirk Klimpel dirk@klimpel.org	3 years ago
Richard van der Hoff	d9cb658c78	Fix up type hints for Twisted 21.7 (#10490 ) Mostly this involves decorating a few Deferred declarations with extra type hints. We wrap the types in quotes to avoid runtime errors when running against older versions of Twisted that don't have generics on Deferred.	3 years ago
Dirk Klimpel	076deade02	allow specifying https:// proxy (#10411 )	3 years ago
Richard van der Hoff	d8324b8238	Fix a handful of type annotations. (#10446 ) * switch from `types.CoroutineType` to `typing.Coroutine` these should be identical semantically, and since `defer.ensureDeferred` is defined to take a `typing.Coroutine`, will keep mypy happy * Fix some annotations on inlineCallbacks functions * changelog	3 years ago
Patrick Cloke	590cc4e888	Add type hints to additional servlet functions (#10437 ) Improves type hints for: * parse_{boolean,integer} * parse_{boolean,integer}_from_args * parse_json_{value,object}_from_request And fixes any incorrect calls that resulted from unknown types.	3 years ago
Patrick Cloke	5db118626b	Add a return type to parse_string. (#10438 ) And set the required attribute in a few places which will error if a parameter is not provided.	3 years ago
Jonathan de Jong	95e47b2e78	[pyupgrade] `synapse/` (#10348 ) This PR is tantamount to running ``` pyupgrade --py36-plus --keep-percent-format `find synapse/ -type f -name "*.py"` ``` Part of #9744	3 years ago
Jonathan de Jong	bdfde6dca1	Use inline type hints in `http/federation/`, `storage/` and `util/` (#10381 )	3 years ago
Jonathan de Jong	bf72d10dbf	Use inline type hints in various other places (in `synapse/`) (#10380 )	3 years ago
Dirk Klimpel	c7603af1d0	Allow providing credentials to `http_proxy` (#10360 )	3 years ago
Erik Johnston	7695ca0618	Fix a number of logged errors caused by remote servers being down. (#10400 )	3 years ago
Patrick Cloke	0555d7b0dc	Add additional types to the federation transport server. (#10213 )	3 years ago
Michael[tm] Smith	27c06a6e06	Drop Origin & Accept from Access-Control-Allow-Headers value (#10114 ) * Drop Origin & Accept from Access-Control-Allow-Headers value This change drops the Origin and Accept header names from the value of the Access-Control-Allow-Headers response header sent by Synapse. Per the CORS protocol, it’s not necessary or useful to include those header names. Details: Per-spec at https://fetch.spec.whatwg.org/#forbidden-header-name, Origin is a “forbidden header name” set by the browser and that frontend JavaScript code is never allowed to set. So the value of Access-Control-Allow-Headers isn’t relevant to Origin or in general to other headers set by the browser itself — the browser never ever consults the Access-Control-Allow-Headers value to confirm that it’s OK for the request to include an Origin header. And per-spec at https://fetch.spec.whatwg.org/#cors-safelisted-request-header, Accept is a “CORS-safelisted request-header”, which means that browsers allow requests to contain the Accept header regardless of whether the Access-Control-Allow-Headers value contains "Accept". So it’s unnecessary for the Access-Control-Allow-Headers to explicitly include Accept. Browsers will not perform a CORS preflight for requests containing an Accept request header. Related: https://github.com/matrix-org/matrix-doc/pull/3225 Signed-off-by: Michael[tm] Smith <mike@w3.org>	3 years ago
Marcus	8070b893db	update black to 21.6b0 (#10197 ) Reformat all files with the new version. Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu>	3 years ago
Michael Kutzner	aac2c49b9b	Fix 'ip_range_whitelist' not working for federation servers (#10115 ) Add 'federation_ip_range_whitelist'. This allows backwards-compatibility, If 'federation_ip_range_blacklist' is set. Otherwise 'ip_range_whitelist' will be used for federation servers. Signed-off-by: Michael Kutzner 1mikure@gmail.com	3 years ago
Sorunome	d936371b69	Implement knock feature (#6739 ) This PR aims to implement the knock feature as proposed in https://github.com/matrix-org/matrix-doc/pull/2403 Signed-off-by: Sorunome mail@sorunome.de Signed-off-by: Andrew Morgan andrewm@element.io	4 years ago
Richard van der Hoff	1bf83a191b	Clean up the interface for injecting opentracing over HTTP (#10143 ) * Remove unused helper functions * Clean up the interface for injecting opentracing over HTTP * changelog	4 years ago
Patrick Cloke	c7f3fb2745	Add type hints to the federation server transport. (#10080 )	4 years ago
Patrick Cloke	9e4610cc27	Correct type hints for parse_string(s)_from_args. (#10137 )	4 years ago
Erik Johnston	1641c5c707	Log method and path when dropping request due to size limit (#10091 )	4 years ago
Erik Johnston	84cf3e47a0	Allow response of `/send_join` to be larger. (#10093 ) Fixes #10087.	4 years ago
Erik Johnston	3f96dbbda7	Log method and path when dropping request due to size limit (#10091 )	4 years ago
Eric Eastwood	ac3e02d089	Add `parse_strings_from_args` to get `prev_events` array (#10048 ) Split out from https://github.com/matrix-org/synapse/pull/9247 Strings: - `parse_string` - `parse_string_from_args` - `parse_strings_from_args` For comparison with ints: - `parse_integer` - `parse_integer_from_args` Previous discussions: - https://github.com/matrix-org/synapse/pull/9247#discussion_r573195687 - https://github.com/matrix-org/synapse/pull/9247#discussion_r574214156 - https://github.com/matrix-org/synapse/pull/9247#discussion_r573264791 Signed-off-by: Eric Eastwood <erice@element.io>	4 years ago
Erik Johnston	64887f06fc	Use ijson to parse the response to `/send_join`, reducing memory usage. (#9958 ) Instead of parsing the full response to `/send_join` into Python objects (which can be huge for large rooms) and then parsing that into events, we instead use ijson to stream parse the response directly into `EventBase` objects.	4 years ago
Richard van der Hoff	3ff2251754	Improved validation for received requests (#9817 ) * Simplify `start_listening` callpath * Correctly check the size of uploaded files	4 years ago
Richard van der Hoff	59d24c5bef	pass a reactor into SynapseSite (#9874 )	4 years ago
Richard van der Hoff	51a20914a8	Limit the size of HTTP responses read over federation. (#9833 )	4 years ago
Jonathan de Jong	4b965c862d	Remove redundant "coding: utf-8" lines (#9786 ) Part of #9744 Removes all redundant `# -- coding: utf-8 --` lines from files, as python 3 automatically reads source code as utf-8 now. `Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>`	4 years ago
Dan Callahan	1d5f0e3529	Bump black configuration to target py36 (#9781 ) Signed-off-by: Dan Callahan <danc@element.io>	4 years ago
Jonathan de Jong	2ca4e349e9	Bugbear: Add Mutable Parameter fixes (#9682 ) Part of #9366 Adds in fixes for B006 and B008, both relating to mutable parameter lint errors. Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>	4 years ago
Patrick Cloke	48d44ab142	Record more information into structured logs. (#9654 ) Records additional request information into the structured logs, e.g. the requester, IP address, etc.	4 years ago
Jonathan de Jong	e2b8a90897	Update mypy configuration: `no_implicit_optional = True` (#9742 )	4 years ago
Patrick Cloke	01dd90b0f0	Add type hints to DictionaryCache and TTLCache. (#9442 )	4 years ago
Patrick Cloke	b7748d3c00	Import HomeServer from the proper module. (#9665 )	4 years ago
Andrew Morgan	5b268997bd	Allow providing credentials to HTTPS_PROXY (#9657 ) Addresses https://github.com/matrix-org/synapse-dinsic/issues/70 This PR causes `ProxyAgent` to attempt to extract credentials from an `HTTPS_PROXY` env var. If credentials are found, a `Proxy-Authorization` header ([details](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Proxy-Authorization)) is sent to the proxy server to authenticate against it. The headers are not passed to the remote server. Also added some type hints.	4 years ago
Patrick Cloke	d29b71aa50	Fix remaining mypy issues due to Twisted upgrade. (#9608 )	4 years ago
Patrick Cloke	55da8df078	Fix additional type hints from Twisted 21.2.0. (#9591 )	4 years ago

1 2 3 4 5 ...

728 Commits (a19aa8b162edf99673bc9b0600c9ab550967b7e8)