watcha-synapse

Commit Graph

Author	SHA1	Message	Date
Patrick Cloke	ab3f1b3b53	Convert simple_select_one_txn and simple_select_one to return tuples. (#16612 )	3 years ago
David Robertson	91587d4cf9	Bulk-invalidate e2e cached queries after claiming keys (#16613 ) Co-authored-by: Patrick Cloke <patrickc@matrix.org>	3 years ago
Patrick Cloke	455ef04187	Avoid updating the same rows multiple times with simple_update_many_txn. (#16609 ) simple_update_many_txn had a bug in it which would cause each update to be applied twice.	3 years ago
Patrick Cloke	9738b1c497	Avoid executing no-op queries. (#16583 ) If simple_{insert,upsert,update}_many_txn is called without any data to modify then return instead of executing the query. This matches the behavior of simple_{select,delete}_many_txn.	3 years ago
Patrick Cloke	ec9ff389f4	More tests for the simple_* methods. (#16596 ) Expand tests for the simple_* database methods, additionally test against both PostgreSQL and SQLite variants.	3 years ago
Patrick Cloke	cfb6d38c47	Remove remaining usage of cursor_to_dict. (#16564 )	3 years ago
David Robertson	fdce83ee60	Claim fallback keys in bulk (#16570 )	3 years ago
Patrick Cloke	679c691f6f	Remove more usages of cursor_to_dict. (#16551 ) Mostly to improve type safety.	3 years ago
Patrick Cloke	9407d5ba78	Convert simple_select_list and simple_select_list_txn to return lists of tuples (#16505 ) This should use fewer allocations and improves type hints.	3 years ago
Patrick Cloke	a4904dcb04	Convert simple_select_many_batch, simple_select_many_txn to tuples. (#16444 )	3 years ago
Patrick Cloke	f1e43018b7	Inline simple_search_list/simple_search_list_txn. (#16434 ) This only has a single use and is over abstracted. Inline it so that we can improve type hints.	3 years ago
Patrick Cloke	06bbf1029c	Convert simple_select_list_paginate_txn to return tuples. (#16433 )	3 years ago
dependabot[bot]	b225acf3e6	Bump types-psycopg2 from 2.9.21.11 to 2.9.21.14 (#16381 ) * Bump types-psycopg2 from 2.9.21.11 to 2.9.21.14 Bumps [types-psycopg2](https://github.com/python/typeshed) from 2.9.21.11 to 2.9.21.14. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-psycopg2 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Relax the annotation of Cursor.description See https://github.com/matrix-org/synapse/pull/16343#issuecomment-1726083384 for rationale. * Changelog * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>	3 years ago
Jason Little	2a0f86f88f	Convert `_insert_graph_receipts_txn` to `simple_upsert` (#16299 )	3 years ago
David Robertson	c1c6c95d72	Log values at DEBUG level with execute_values (#16281 )	3 years ago
Patrick Cloke	9ec3da06da	Bump mypy-zope & mypy. (#16188 )	3 years ago
Shay	e625c3dca0	Revert "Stop writing to column `user_id` of tables `profiles` and `user_filters`. (#15953 ) * Revert "Stop writing to column `user_id` of tables `profiles` and `user_filters` (#15787)" This reverts commit `f25b0f8808`. * newsfragement	3 years ago
Shay	f25b0f8808	Stop writing to column `user_id` of tables `profiles` and `user_filters` (#15787 )	3 years ago
Erik Johnston	95a96b21eb	Add foreign key constraint to `event_forward_extremities`. (#15751 )	3 years ago
Andrew Morgan	2ac6c3bbb5	Don't always lock "user_ips" table when performing non-native upsert (#15788 )	3 years ago
David Robertson	d162aecaac	Quick & dirty metric for background update status (#15740 ) * Quick & dirty metric for background update status * Changelog * Remove debug Co-authored-by: Mathieu Velten <mathieuv@matrix.org> * Actually write to _aborted --------- Co-authored-by: Mathieu Velten <mathieuv@matrix.org>	3 years ago
Patrick Cloke	1e89976b26	Rename blacklist/whitelist internally. (#15620 ) Avoid renaming configuration settings for now and rename internal code to use blocklist and allowlist instead.	3 years ago
Erik Johnston	fc3a878220	Speed up rebuilding of the user directory for local users (#15529 ) The idea here is to batch up the work.	3 years ago
David Robertson	8a47d6e3a6	More precise type for LoggingTransaction.execute (#15432 ) * More precise type for LoggingTransaction.execute * Add an annotation for stream_ordering_month_ago This would have spotted the error that was fixed in "Add comma missing from #15382. (#15429)"	3 years ago
dependabot[bot]	bd4d958aaf	Bump ruff from 0.0.252 to 0.0.259 (#15328 ) * Bump ruff from 0.0.252 to 0.0.259 Bumps [ruff](https://github.com/charliermarsh/ruff) from 0.0.252 to 0.0.259. - [Release notes](https://github.com/charliermarsh/ruff/releases) - [Changelog](https://github.com/charliermarsh/ruff/blob/main/BREAKING_CHANGES.md) - [Commits](https://github.com/charliermarsh/ruff/compare/v0.0.252...v0.0.259) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Fix new warnings * Mypy * Newsfile --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>	3 years ago
Patrick Cloke	3d060eae6c	Add missing type hints to `synapse.storage.database`. (#15230 )	3 years ago
Erik Johnston	c69aae94cd	Split up txn for fetching device keys (#15215 ) We look up keys in batches, but we should do that outside of the transaction to avoid starving the database pool.	3 years ago
Patrick Cloke	733531ee3e	Add final type hint to synapse.server. (#15035 )	3 years ago
Patrick Cloke	8a05d5de21	Batch look-ups to see if rooms are partial stated. (#14917 ) * Batch look-ups to see if rooms are partial stated. * Fix issues found in linting. * Fix typo. * Apply suggestions from code review Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com> * Clarify comments. Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com> * Also improve the cache size while we're at it * is_partial_state_rooms -> is_partial_state_room_batched * Run `black` * Improve annotation for `simple_select_many_batch` * Fix is_partial_state_room_batched impl * Okay, _actually_ fix impl * Update description. * Update synapse/storage/databases/main/room.py Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Run black. Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>	3 years ago
Andrew Morgan	c4456114e1	Add experimental support for MSC3391: deleting account data (#14714 )	3 years ago
David Robertson	3d87847ecc	Enable `--warn-redundant-casts` option in mypy (#14671 ) * Enable `--warn-redundant-casts` option in mypy Doesn't do much but helps me sleep better at night. * Changelog * Fix name of the ignore * Fix one more missed cast Not sure why I didn't see this one locally, maybe I needed a poetry update * Remove old comment Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	3 years ago
Sean Quah	f792dd74e1	Remove option to skip locking of tables during emulated upserts (#14469 ) To perform an emulated upsert into a table safely, we must either: * lock the table, * be the only writer upserting into the table * or rely on another unique index being present. When the 2nd or 3rd cases were applicable, we previously avoided locking the table as an optimization. However, as seen in #14406, it is easy to slip up when adding new schema deltas and corrupt the database. The only time we lock when performing emulated upserts is while waiting for background updates on postgres. On sqlite, we do no locking at all. Let's remove the option to skip locking tables, so that we don't shoot ourselves in the foot again. Signed-off-by: Sean Quah <seanq@matrix.org>	3 years ago
Sean Quah	9cae44f49e	Track unconverted device list outbound pokes using a position instead (#14516 ) When a local device list change is added to `device_lists_changes_in_room`, the `converted_to_destinations` flag is set to `FALSE` and the `_handle_new_device_update_async` background process is started. This background process looks for unconverted rows in `device_lists_changes_in_room`, copies them to `device_lists_outbound_pokes` and updates the flag. To update the `converted_to_destinations` flag, the database performs a `DELETE` and `INSERT` internally, which fragments the table. To avoid this, track unconverted rows using a `(stream ID, room ID)` position instead of the flag. From now on, the `converted_to_destinations` column indicates rows that need converting to outbound pokes, but does not indicate whether the conversion has already taken place. Closes #14037. Signed-off-by: Sean Quah <seanq@matrix.org>	3 years ago
Andrew Morgan	e7132c3f81	Fix check to ignore blank lines in incoming TCP replication (#14449 )	4 years ago
David Robertson	c3a4780080	When restarting a partial join resync, prioritise the server which actioned a partial join (#14126 )	4 years ago
Patrick Cloke	b4ec4f5e71	Track notification counts per thread (implement MSC3773). (#13776 ) When retrieving counts of notifications segment the results based on the thread ID, but choose whether to return them as individual threads or as a single summed field by letting the client opt-in via a sync flag. The summarization code is also updated to be per thread, instead of per room.	4 years ago
Sean Quah	d65862c41f	Refactor `_get_e2e_device_keys_txn` to split large queries (#13956 ) Instead of running a single large query, run a single query for user-only lookups and additional queries for batches of user device lookups. Resolves #13580. Signed-off-by: Sean Quah <seanq@matrix.org>	4 years ago
David Robertson	285d72556b	Update mypy and mypy-zope, attempt 3 (#13993 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	4 years ago
David Robertson	8e52cb0bce	Revert "Update mypy and mypy-zope (#13925 )" This reverts commit `6d543d6d9f`.	4 years ago
David Robertson	6d543d6d9f	Update mypy and mypy-zope (#13925 ) * Update mypy and mypy-zope * Unignore assigning to LogRecord attributes Presumably https://github.com/python/typeshed/pull/8064 makes this ok Cherry-picked from #13521 * Remove unused ignores due to mypy ParamSpec fixes https://github.com/python/mypy/pull/12668 Cherry-picked from #13521 * Remove additional unused ignores * Fix new mypy complaints related to `assertGreater` Presumably due to https://github.com/python/typeshed/pull/8077 * Changelog * Reword changelog Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	4 years ago
David Robertson	15754d720f	Update UPSERT comment now that native upserts are the default (#13924 )	4 years ago
David Robertson	0a38c7ec6d	Snapshot schema 72 (#13873 ) Including another batch of fixes to the schema dump script	4 years ago
Patrick Cloke	efd108b45d	Accept & store thread IDs for receipts (implement MSC3771). (#13782 ) Updates the `/receipts` endpoint and receipt EDU handler to parse a `thread_id` from the body and insert it in the database.	4 years ago
Patrick Cloke	b2b0c85279	Support providing an index predicate for upserts. (#13822 ) This is useful to upsert against a table which has a unique partial index while avoiding conflicts.	4 years ago
David Robertson	f2d2481e56	Require SQLite >= 3.27.0 (#13760 )	4 years ago
David Robertson	19e5d44886	Revert "Update locked versions of mypy and mypy-zope (#13521 )" This reverts commit `f383b9b3ec`. Other PRs were seeing mypy failures that looked to be related to mypy-zope. Confusingly, we didn't see this on #13521. Revert this for now and investigate later.	4 years ago
David Robertson	f383b9b3ec	Update locked versions of mypy and mypy-zope (#13521 )	4 years ago
David Robertson	34949ead1f	Track DB txn times w/ two counters, not histogram (#13342 )	4 years ago
Nick Mills-Barrett	2ee0b6ef4b	Safe async event cache (#13308 ) Fix race conditions in the async cache invalidation logic, by separating the async & local invalidation calls and ensuring any async call i executed first. Signed off by Nick @ Beeper (@Fizzadar).	4 years ago
Nick Mills-Barrett	cc21a431f3	Async get event cache prep (#13242 ) Some experimental prep work to enable external event caching based on #9379 & #12955. Doesn't actually move the cache at all, just lays the groundwork for async implemented caches. Signed off by Nick @ Beeper (@Fizzadar)	4 years ago

1 2 3

148 Commits (ab3f1b3b53cdb4e2751b3e8c5eb052d7475be58f)