watcha-synapse

Commit Graph

Author	SHA1	Message	Date
dependabot[bot]	871f51c270	Bump lxml-stubs from 0.4.0 to 0.5.1 (#16885 )	10 months ago
Erik Johnston	23740eaa3d	Correctly mention previous copyright (#16820 ) During the migration the automated script to update the copyright headers accidentally got rid of some of the existing copyright lines. Reinstate them.	10 months ago
Patrick Cloke	8e1e62c9e0	Update license headers	1 year ago
dependabot[bot]	001fc7bd19	Bump ruff from 0.0.277 to 0.0.286 (#16198 ) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	1 year ago
Patrick Cloke	6f18812bb0	Add stubs package for lxml. (#15697 ) The stubs have some issues so this has some generous cast and ignores in it, but it is better than not having stubs. Note that confusing that Element is a function which creates _Element instances (and similarly for Comment).	2 years ago
Patrick Cloke	4fc8875876	Refactor media modules. (#15146 ) * Removes the `v1` directory from `test.rest.media.v1`. * Moves the non-REST code from `synapse.rest.media.v1` to `synapse.media`. * Flatten the `v1` directory from `synapse.rest.media`, but leave compatiblity with 3rd party media repositories and spam checkers.	2 years ago
David Robertson	796a4b7482	Prefer `type(x) is int` to `isinstance(x, int)` (#14945 ) * Perfer `type(x) is int` to `isinstance(x, int)` This covered all additional instances I could see where `x` was user-controlled. The remaining cases are ``` $ rg -s 'isinstance.[^_]int' tests/replication/_base.py 576: if isinstance(obj, int): synapse/util/caches/stream_change_cache.py 136: assert isinstance(stream_pos, int) 214: assert isinstance(stream_pos, int) 246: assert isinstance(stream_pos, int) 267: assert isinstance(stream_pos, int) synapse/replication/tcp/external_cache.py 133: if isinstance(result, int): synapse/metrics/__init__.py 100: if isinstance(calls, (int, float)): synapse/handlers/appservice.py 262: assert isinstance(new_token, int) synapse/config/_util.py 62: if isinstance(p, int): ``` which cover metrics, logic related to `jsonschema`, and replication and data streams. AFAICS these are all internal to Synapse Changelog	2 years ago
Jeyachandran Rathnam	babeeb4e7a	Unescape HTML entities in oEmbed titles. (#14781 ) It doesn't seem valid that HTML entities should appear in the title field of oEmbed responses, but a popular WordPress plug-in seems to do it. There should not be harm in unescaping these.	2 years ago
Patrick Cloke	00c93d2e7e	Be more lenient in the oEmbed response parsing. (#14089 ) Attempt to parse any valid information from an oEmbed response (instead of bailing at the first unexpected data). This should allow for more partial oEmbed data to be returned, resulting in better / more URL previews, even if those URL previews are only partial.	2 years ago
Philippe Daouadi	15ffc4143c	Fix preview of imgur and Tenor URLs. (#11669 ) By scraping Open Graph information from the HTML even when an autodiscovery endpoint is found. The results are then combined to capture as much information as possible from the page.	3 years ago
Patrick Cloke	eb39da6782	Move HTML parsing to a separate file for URL previews. (#11566 ) * Splits the logic for parsing HTML from the resource handling code. * Fix a circular import in the oEmbed code (which uses the HTML parsing code). * Renames some of the HTML parsing methods to: * Make it clear which methods are "internal" to the module. * Clarify what the methods do.	3 years ago
Patrick Cloke	732bbf6737	Be more lenient when parsing the version for oEmbed responses. (#11065 )	3 years ago
Patrick Cloke	1db9282dfa	Fix formatting string when oEmbed errors occur. (#11061 )	3 years ago
Patrick Cloke	1b112840d2	Autodiscover oEmbed endpoint from returned HTML (#10822 ) Searches the returned HTML for an oEmbed endpoint using the autodiscovery mechanism (`<link rel=...>`), and will request it to generate the preview.	3 years ago
Patrick Cloke	6fc8be9a1b	Include more information in oEmbed previews. (#10819 ) * Improved titles (fall back to the author name if there's not title) and include the site name. * Handle photo/video payloads. * Include the original URL in the Open Graph response. * Fix the expiration time (by properly converting from seconds to milliseconds).	3 years ago
Patrick Cloke	ba7a91aea5	Refactor oEmbed previews (#10814 ) The major change is moving the decision of whether to use oEmbed further up the call-stack. This reverts the _download_url method to being a "dumb" functionwhich takes a single URL and downloads it (as it was before #7920). This also makes more minor refactorings: * Renames internal variables for clarity. * Factors out shared code between the HTML and rich oEmbed previews. * Fixes tests to preview an oEmbed image.	3 years ago
Patrick Cloke	580a15e039	Request JSON for oEmbed requests (and ignore XML only providers). (#10759 ) This adds the format to the request arguments / URL to ensure that JSON data is returned (which is all that Synapse supports). This also adds additional error checking / filtering to the configuration file to ignore XML-only providers.	3 years ago
Patrick Cloke	e2481dbe93	Allow configuration of the oEmbed URLs. (#10714 ) This adds configuration options (under an `oembed` section) to configure which URLs are matched to use oEmbed for URL previews.	3 years ago

6 Commits (ab80b3412e314b25827bcc5c61628e024c8cf571)