50 Commits (acfb7c3b5d49e86529cdb1c4fd06460b5c330686)

Author	SHA1	Message	Date
Erik Johnston	1ef9efc1e0	Fix error reporting when using `opentracing.trace` (#7961)	4 years ago
Richard van der Hoff	15997618e2	Clean up PreserveLoggingContext (#7877) ... This had some dead code and some just plain wrong docstrings.	4 years ago
Karthikeyan Singaravelan	5662e2b0f3	Remove unused code from synapse.logging.utils. (#7897)	4 years ago
Patrick Cloke	d1d5fa66e4	Fix the trace function for async functions. (#7872) ... Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	4 years ago
Will Hunt	62b1ce8539	isort 5 compatibility (#7786) ... The CI appears to use the latest version of isort, which is a problem when isort gets a major version bump. Rather than try to pin the version, I've done the necessary to make isort5 happy with synapse.	4 years ago
Erik Johnston	5cdca53aa0	Merge different Resource implementation classes (#7732)	4 years ago
Erik Johnston	e07a8caf58	Add support for using rust-python-jaeger-reporter (#7697)	5 years ago
Dagfinn Ilmari Mannsåker	a3f11567d9	Replace all remaining six usage with native Python 3 equivalents (#7704)	5 years ago
Richard van der Hoff	d4676910c9	remove miscellaneous PY2 code	5 years ago
Patrick Cloke	d7c2df2fa3	Improve per-block CPU and DB usage metrics (#7426)	5 years ago
Patrick Cloke	fe69fb6263	Add backwards compatibility codepath to LoggingContext. (#7408)	5 years ago
Erik Johnston	37f6823f5b	Add instance name to RDATA/POSITION commands (#7364) ... This is primarily for allowing us to send those commands from workers, but for now simply allows us to ignore echoed RDATA/POSITION commands that we sent (we get echoes of sent commands when using redis). Currently we log a WARNING on the master process every time we receive an echoed RDATA.	5 years ago
Richard van der Hoff	0f05fd1530	Reduce the number of calls to `resource.getrusage` (#7183) ... Let's just call `getrusage` once on each logcontext change, rather than twice.	5 years ago
Richard van der Hoff	60adcbed91	Fix "'NoneType' has no attribute start|stop" logcontext errors (#7181) ... Fixes #7179.	5 years ago
Richard van der Hoff	39230d2171	Clean up some LoggingContext stuff (#7120) ... * Pull Sentinel out of LoggingContext ... and drop a few unnecessary references to it * Factor out LoggingContext.current_context move `current_context` and `set_context` out to top-level functions. Mostly this means that I can more easily trace what's actually referring to LoggingContext, but I think it's generally neater. * move copy-to-parent into `stop` this really just makes `start` and `stop` more symetric. It also means that it behaves correctly if you manually `set_log_context` rather than using the context manager. * Replace `LoggingContext.alive` with `finished` Turn `alive` into `finished` and make it a bit better defined.	5 years ago
Brendan Abolivier	dc6fb56c5f	Hopefully mypy is happy now	5 years ago
Brendan Abolivier	fe593ef990	Attempt at appeasing the gods of mypy	5 years ago
Neil Pilgrim	2bff4457d9	Add type hints to logging/context.py (#6309) ... * Add type hints to logging/context.py Signed-off-by: neiljp (Neil Pilgrim) <github@kepier.clara.net>	5 years ago
Patrick Cloke	509e381afa	Clarify list/set/dict/tuple comprehensions and enforce via flake8 (#6957) ... Ensure good comprehension hygiene using flake8-comprehensions.	5 years ago
Richard van der Hoff	da4e52544e	comment for run_in_background	5 years ago
Erik Johnston	495005360c	Bump version of mypy	5 years ago
Erik Johnston	ffeafade48	Update comment	5 years ago
Erik Johnston	9a2223d4c8	Fix make_deferred_yieldable to work with coroutines	5 years ago
Amber Brown	fdec84aa42	Add benchmarks for structured logging performance (#6266)	5 years ago
Amber Brown	9eebd46048	Improve the performance of structured logging (#6322)	5 years ago
Andrew Morgan	73d091be48	A couple more instances	5 years ago
Amber Brown	020add5099	Update black to 19.10b0 (#6304) ... * update version of black and also fix the mypy config being overridden	5 years ago
Andrew Morgan	54fef094b3	Remove usage of deprecated logger.warn method from codebase (#6271) ... Replace every instance of `logger.warn` with `logger.warning` as the former is deprecated.	5 years ago
Erik Johnston	f3ceaf4323	Trace non-JSON APIs, /media, /key etc	5 years ago
Amber Brown	864f144543	Fix up some typechecking (#6150) ... * type checking fixes * changelog	5 years ago
J. Ryan Stinnett	a86a290850	Fix logcontext spam on non-Linux platforms (#6059) ... This checks whether the current platform supports thread resource usage tracking before logging a warning to avoid log spam. Fixes https://github.com/matrix-org/synapse/issues/6055	5 years ago
Amber Brown	b617864cd9	Fix for structured logging tests stomping on logs (#6023)	5 years ago
Erik Johnston	d8517da85b	Don't assume there is a 'self' arg in @trace decorator	5 years ago
Jorik Schellekens	bc604e7f94	Gracefully handle log context slips and missing opentracing import errors. (#5988)	5 years ago
Jorik Schellekens	909827b422	Add opentracing to all client servlets (#5983)	5 years ago
Jorik Schellekens	b9cfd3c375	Fix opentracing contexts missing from outbound replication requests (#5982)	5 years ago
Jorik Schellekens	a90d16dabc	Opentrace device lists (#5853) ... Trace device list changes.	5 years ago
Amber Brown	7dc398586c	Implement a structured logging output system. (#5680)	5 years ago
Jorik Schellekens	8767b63a82	Propagate opentracing contexts through EDUs (#5852) ... Propagate opentracing contexts through EDUs Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	5 years ago
Jorik Schellekens	812ed6b0d5	Opentracing across workers (#5771) ... Propagate opentracing contexts across workers Also includes some Convenience modifications to opentracing for servlets, notably: - Add boolean to skip the whitelisting check on inject extract methods. - useful when injecting into carriers locally. Otherwise we'd always have to include our own servername and whitelist our servername - start_active_span_from_request instead of header - Add boolean to decide whether to extract context from a request to a servlet	5 years ago
Jorik Schellekens	c886f976e0	Opentracing doc update (#5776) ... Update opentracing docs to use the unified 'trace' method	5 years ago
Jorik Schellekens	3641784e8c	Make Jaeger fully configurable (#5694) ... * Allow Jaeger to be configured * Update sample config	5 years ago
Amber Brown	4806651744	Replace returnValue with return (#5736)	5 years ago
Jorik Schellekens	18a466b84e	Opentracing Utils (#5722) ... * Add decerators for tracing functions * Use the new clean contexts * Context and edu utils * Move opentracing setters * Move whitelisting * Sectioning comments * Better args wrapper * Docstrings Co-Authored-By: Erik Johnston <erik@matrix.org> * Remove unused methods. * Don't use global * One tracing decorator to rule them all.	5 years ago
Jorik Schellekens	826e6ec3bd	Opentracing Documentation (#5703) ... * Opentracing survival guide * Update decorator names in doc * Doc cleanup These are all alterations as a result of comments in #5703, it includes mostly typos and clarifications. The most interesting changes are: - Split developer and user docs into two sections - Add a high level description of OpenTracing * newsfile * Move contributer specific info to docstring. * Sample config. * Trailing whitespace. * Update 5703.misc * Apply suggestions from code review Mostly just rewording parts of the docs for clarity. Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	5 years ago
Jorik Schellekens	7b8bc61834	Don't accept opentracing data from clients. (#5715) ... * Don't accept opentracing data from clients. * newsfile	5 years ago
Richard van der Hoff	82345bc09a	Clean up opentracing configuration options (#5712) ... Clean up config settings and dead code. This is mostly about cleaning up the config format, to bring it into line with our conventions. In particular: * There should be a blank line after `## Section ##' headings * There should be a blank line between each config setting * There should be a `#`-only line between a comment and the setting it describes * We don't really do the `# #` style commenting-out of whole sections if we can help it * rename `tracer_enabled` to `enabled` While we're here, do more config parsing upfront, which makes it easier to use later on. Also removes redundant code from LogContextScopeManager. Also changes the changelog fragment to a `feature` - it's exciting!	5 years ago
Jorik Schellekens	38a6d3eea7	Add basic opentracing support (#5544) ... * Configure and initialise tracer Includes config options for the tracer and sets up JaegerClient. * Scope manager using LogContexts We piggy-back our tracer scopes by using log context. The current log context gives us the current scope. If new scope is created we create a stack of scopes in the context. * jaeger is a dependency now * Carrier inject and extraction for Twisted Headers * Trace federation requests on the way in and out. The span is created in _started_processing and closed in _finished_processing because we need a meaningful log context. * Create logcontext for new scope. Instead of having a stack of scopes in a logcontext we create a new context for a new scope if the current logcontext already has a scope. * Remove scope from logcontext if logcontext is top level * Disable tracer if not configured * typo * Remove dependence on jaeger internals * bools * Set service name * :Explicitely state that the tracer is disabled * Black is the new black * Newsfile * Code style * Use the new config setup. * Generate config. * Copyright * Rename config to opentracing * Remove user whitelisting * Empty whitelist by default * User ConfigError instead of RuntimeError * Use isinstance * Use tag constants for opentracing. * Remove debug comment and no need to explicitely record error * Two errors a "s(c)entry" * Docstrings! * Remove debugging brainslip * Homeserver Whitlisting * Better opentracing config comment * linting * Inclue worker name in service_name * Make opentracing an optional dependency * Neater config retreival * Clean up dummy tags * Instantiate tracing as object instead of global class * Inlcude opentracing as a homeserver member. * Thread opentracing to the request level * Reference opetnracing through hs * Instantiate dummy opentracin g for tests. * About to revert, just keeping the unfinished changes just in case * Revert back to global state, commit number: 9ce4a3d9067bf9889b86c360c05ac88618b85c4f * Use class level methods in tracerutils * Start and stop requests spans in a place where we have access to the authenticated entity * Seen it, isort it * Make sure to close the active span. * I'm getting black and blue from this. * Logger formatting Co-Authored-By: Erik Johnston <erik@matrix.org> * Outdated comment * Import opentracing at the top * Return a contextmanager * Start tracing client requests from the servlet * Return noop context manager if not tracing * Explicitely say that these are federation requests * Include servlet name in client requests * Use context manager * Move opentracing to logging/ * Seen it, isort it again! * Ignore twisted return exceptions on context exit * Escape the scope * Scopes should be entered to make them useful. * Nicer decorator names * Just one init, init? * Don't need to close something that isn't open * Docs make you smarter	5 years ago
Amber Brown	463b072b12	Move logging utilities out of the side drawer of util/ and into logging/ (#5606)	5 years ago