527 Commits (bc1db16086d0718c9c0bb61b32b825ba62049bb0)

Author	SHA1	Message	Date
Erik Johnston	23740eaa3d	Correctly mention previous copyright (#16820) ... During the migration the automated script to update the copyright headers accidentally got rid of some of the existing copyright lines. Reinstate them.	10 months ago
Patrick Cloke	579c6be5f6	Drop unused tables & unneeded access token ID for events. (#16522)	12 months ago
Patrick Cloke	8e1e62c9e0	Update license headers	1 year ago
Erik Johnston	928e964857	Fix cross-worker ratelimiting (#16558) ... c.f. #16481	1 year ago
Erik Johnston	c02406ac71	Add new module API for adding custom fields to events `unsigned` section (#16549)	1 year ago
Patrick Cloke	4cc729d480	Revert "Drop unused tables & unneeded access token ID for events. (#16268)" (#16465) ... This reverts commit cabd577460. There are additional usages of these tables which need to be removed first.	1 year ago
dependabot[bot]	0a67743d9e	Bump ruff from 0.0.290 to 0.0.292 (#16449) ... * Bump ruff from 0.0.290 to 0.0.292 Bumps [ruff](https://github.com/astral-sh/ruff) from 0.0.290 to 0.0.292. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/BREAKING_CHANGES.md) - [Commits](https://github.com/astral-sh/ruff/compare/v0.0.290...v0.0.292) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Fix up lint --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>	1 year ago
Patrick Cloke	cabd577460	Drop unused tables & unneeded access token ID for events. (#16268) ... Drop the event_txn_id table and the tables related to MSC2716, which is no longer supported in Synapse.	1 year ago
Patrick Cloke	f84da3c32e	Add a cache around server ACL checking (#16360) ... * Pre-compiles the server ACLs onto an object per room and invalidates them when new events come in. * Converts the server ACL checking into Rust.	1 year ago
Erik Johnston	954921736b	Refactor `get_user_by_id` (#16316)	1 year ago
Patrick Cloke	ebd8374fb5	Stop writing to the event_txn_id table (#16175)	1 year ago
dependabot[bot]	001fc7bd19	Bump ruff from 0.0.277 to 0.0.286 (#16198) ... Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	1 year ago
Patrick Cloke	40901af5e0	Pass the device ID around in the presence handler (#16171) ... Refactoring to pass the device ID (in addition to the user ID) through the presence handler (specifically the `user_syncing`, `set_state`, and `bump_presence_active_time` methods and their replication versions).	1 year ago
David Robertson	e691243e19	Fix typechecking with twisted trunk (#16121)	1 year ago
Mathieu Velten	8c3bcea2da	Rename pagination&purge locks and add comments explaining them (#16112)	1 year ago
Patrick Cloke	d98a43d922	Stabilize support for MSC3970: updated transaction semantics (scope to `device_id`) (#15629) ... For now this maintains compatible with old Synapses by falling back to using transaction semantics on a per-access token. A future version of Synapse will drop support for this.	1 year ago
Patrick Cloke	b7695ac388	Combine duplicated code for calculating an event ID from a txn ID (#16023) ... Refactoring related to stabilization of MSC3970, refactor to combine code which has the same logic.	1 year ago
Erik Johnston	ae55cc1e6b	Add ability to wait for locks and add locks to purge history / room deletion (#15791) ... c.f. #13476	1 year ago
Erik Johnston	fc1e534e41	Speed up updating state in large rooms (#15971) ... This should speed up updating state in rooms with lots of state.	1 year ago
Erik Johnston	ad52db3b5c	Reduce the amount of state we pull out (#15968)	1 year ago
Eric Eastwood	0f02f0b4da	Remove experimental MSC2716 implementation to incrementally import history into existing rooms (#15748) ... Context for why we're removing the implementation: - https://github.com/matrix-org/matrix-spec-proposals/pull/2716#issuecomment-1487441010 - https://github.com/matrix-org/matrix-spec-proposals/pull/2716#issuecomment-1504262734 Anyone wanting to continue MSC2716, should also address these leftover tasks: https://github.com/matrix-org/synapse/issues/10737 Closes https://github.com/matrix-org/synapse/issues/10737 in the fact that it is not longer necessary to track those things.	1 year ago
Andrew Morgan	2e59e97ebd	Move ThirdPartyEventRules into module_api/callbacks (#15535)	2 years ago
Quentin Gliech	8b3a502996	Experimental support for MSC3970: per-device transaction IDs (#15318)	2 years ago
Andrew Morgan	aec639e3e3	Move Spam Checker callbacks to a dedicated file (#15453)	2 years ago
Patrick Cloke	d07d255830	Implement MSC2175: remove the creator field from create events. (#15394)	2 years ago
Erik Johnston	827f198177	Fix error when sending message into deleted room. (#15235) ... When a room is deleted in Synapse we remove the event forward extremities in the room, so if (say a bot) tries to send a message into the room we error out due to not being able to calculate prev events for the new event *before* we check if the sender is in the room. Fixes #8094	2 years ago
Quentin Gliech	41f127e068	Pass the requester during event serialization. (#15174) ... This allows Synapse to properly include the transaction ID in the unsigned data of events.	2 years ago
Shay	1c95ddd09b	Batch up storing state groups when creating new room (#14918)	2 years ago
Richard van der Hoff	5febf88b6c	Update the error code for duplicate annotation (#15075)	2 years ago
Mathieu Velten	6cddf24e36	Faster joins: don't stall when a user joins during a fast join (#14606) ... Fixes #12801. Complement tests are at https://github.com/matrix-org/complement/pull/567. Avoid blocking on full state when handling a subsequent join into a partial state room. Also always perform a remote join into partial state rooms, since we do not know whether the joining user has been banned and want to avoid leaking history to banned users. Signed-off-by: Mathieu Velten <mathieuv@matrix.org> Co-authored-by: Sean Quah <seanq@matrix.org> Co-authored-by: David Robertson <davidr@element.io>	2 years ago
Shay	03bccd542b	Add a class UnpersistedEventContext to allow for the batching up of storing state groups (#14675) ... * add class UnpersistedEventContext * modify create new client event to create unpersistedeventcontexts * persist event contexts after creation * fix tests to persist unpersisted event contexts * cleanup * misc lints + cleanup * changelog + fix comments * lints * fix batch insertion? * reduce redundant calculation * add unpersisted event classes * rework compute_event_context, split into function that returns unpersisted event context and then persists it * use calculate_context_info to create unpersisted event contexts * update typing * $%#^&* * black * fix comments and consolidate classes, use attr.s for class * requested changes * lint * requested changes * requested changes * refactor to be stupidly explicit * clearer renaming and flow * make partial state non-optional * update docstrings --------- Co-authored-by: Erik Johnston <erik@matrix.org>	2 years ago
Shay	55e4d27b36	Limit concurrent event creation for a room to avoid state resolution when sending bursts of events to a local room (#14977)	2 years ago
Sean Quah	805b641fb6	Fix "Re-starting finished log context" spam when creating events (#14947) ... `run_in_background` calls re-use the current logging context. When they are not awaited, they can complete after the current logging context has been marked as finished, which leads to log spam. Use `run_as_background_process` instead. Fixes one of the instances of #13090. Signed-off-by: Sean Quah <seanq@matrix.org>	2 years ago
David Robertson	796a4b7482	Prefer `type(x) is int` to `isinstance(x, int)` (#14945) ... * Perfer `type(x) is int` to `isinstance(x, int)` This covered all additional instances I could see where `x` was user-controlled. The remaining cases are ``` $ rg -s 'isinstance.*[^_]int' tests/replication/_base.py 576: if isinstance(obj, int): synapse/util/caches/stream_change_cache.py 136: assert isinstance(stream_pos, int) 214: assert isinstance(stream_pos, int) 246: assert isinstance(stream_pos, int) 267: assert isinstance(stream_pos, int) synapse/replication/tcp/external_cache.py 133: if isinstance(result, int): synapse/metrics/__init__.py 100: if isinstance(calls, (int, float)): synapse/handlers/appservice.py 262: assert isinstance(new_token, int) synapse/config/_util.py 62: if isinstance(p, int): ``` which cover metrics, logic related to `jsonschema`, and replication and data streams. AFAICS these are all internal to Synapse * Changelog	2 years ago
reivilibre	5172c8c403	Faster remote room joins (worker mode): do not populate external hosts-in-room cache when sending events as this requires blocking for full state. (#14749) ... Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> Co-authored-by: Sean Quah <seanq@matrix.org>	2 years ago
Mathieu Velten	54c012c5a8	Make `handle_new_client_event` throws `PartialStateConflictError` (#14665) ... Then adapts calling code to retry when needed so it doesn't 500 to clients. Signed-off-by: Mathieu Velten <mathieuv@matrix.org> Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2 years ago
David Robertson	e2a1adbf5d	Allow selecting "prejoin" events by state keys (#14642) ... * Declare new config * Parse new config * Read new config * Don't use trial/our TestCase where it's not needed Before: ``` $ time trial tests/events/test_utils.py > /dev/null real 0m2.277s user 0m2.186s sys 0m0.083s ``` After: ``` $ time trial tests/events/test_utils.py > /dev/null real 0m0.566s user 0m0.508s sys 0m0.056s ``` * Helper to upsert to event fields without exceeding size limits. * Use helper when adding invite/knock state Now that we allow admins to include events in prejoin room state with arbitrary state keys, be a good Matrix citizen and ensure they don't accidentally create an oversized event. * Changelog * Move StateFilter tests should have done this in #14668 * Add extra methods to StateFilter * Use StateFilter * Ensure test file enforces typed defs; alphabetise * Workaround surprising get_current_state_ids * Whoops, fix mypy	2 years ago
David Robertson	b5b5f66084	Move `StateFilter` to `synapse.types` (#14668) ... * Move `StateFilter` to `synapse.types` * Changelog	2 years ago
Shay	72f3e38137	Fix possible variable shadow in `create_new_client_event` (#14575)	2 years ago
Brendan Abolivier	86c5a710d8	Implement MSC3912: Relation-based redactions (#14260) ... Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2 years ago
Shay	b7a7ff6ee3	Add initial power level event to batch of bulk persisted events when creating a new room. (#14228)	2 years ago
Shay	847e2393f3	Prepatory work for adding power level event to batched events (#14214)	2 years ago
Shay	b6baa46db0	Fix a bug where the joined hosts for a given event were not being properly cached (#14125)	2 years ago
Shay	7b7478e8b6	Batch up notifications after event persistence (#14033)	2 years ago
Shay	8ab16a92ed	Persist CreateRoom events to DB in a batch (#13800)	2 years ago
Shay	a2cf66a94d	Prepatory work for batching events to send (#13487) ... This PR begins work on batching up events during the creation of a room. The PR splits out the creation and sending/persisting of the events. The first three events in the creation of the room-creating the room, joining the creator to the room, and the power levels event are sent sequentially, while the subsequent events are created and collected to be sent at the end of the function. This is currently done by appending them to a list and then iterating over the list to send, the next step (after this PR) would be to send and persist the collected events as a batch.	2 years ago
reivilibre	6302753012	Deduplicate `is_server_notices_room`. (#13780)	2 years ago
Eric Eastwood	d58615c82c	Directly lookup local membership instead of getting all members in a room first (`get_users_in_room` mis-use) (#13608) ... See https://github.com/matrix-org/synapse/pull/13575#discussion_r953023755	2 years ago
Quentin Gliech	3dd175b628	`synapse.api.auth.Auth` cleanup: make permission-related methods use `Requester` instead of the `UserID` (#13024) ... Part of #13019 This changes all the permission-related methods to rely on the Requester instead of the UserID. This is a first step towards enabling scoped access tokens at some point, since I expect the Requester to have scope-related informations in it. It also changes methods which figure out the user/device/appservice out of the access token to return a Requester instead of something else. This avoids having store-related objects in the methods signatures.	2 years ago
reivilibre	c3516e9dec	Faster room joins: make `/joined_members` block whilst the room is partial stated. (#13514)	2 years ago