watcha-synapse

Commit Graph

Author	SHA1	Message	Date
Erik Johnston	2b7c180879	Start fewer opentracing spans (#8640 ) #8567 started a span for every background process. This is good as it means all Synapse code that gets run should be in a span (unless in the sentinel logging context), but it means we generate about 15x the number of spans as we did previously. This PR attempts to reduce that number by a) not starting one for send commands to Redis, and b) deferring starting background processes until after we're sure they're necessary. I don't really know how much this will help.	4 years ago
Patrick Cloke	d2a3eb04a4	Fix typos in comments.	4 years ago
Patrick Cloke	c619253db8	Stop sub-classing object (#8249 )	4 years ago
Patrick Cloke	dbc630a628	Use the JSON encoder without whitespace in more places. (#8124 )	4 years ago
Patrick Cloke	eebf52be06	Be stricter about JSON that is accepted by Synapse (#8106 )	4 years ago
Erik Johnston	1ef9efc1e0	Fix error reporting when using `opentracing.trace` (#7961 )	4 years ago
Patrick Cloke	d1d5fa66e4	Fix the trace function for async functions. (#7872 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	4 years ago
Will Hunt	62b1ce8539	isort 5 compatibility (#7786 ) The CI appears to use the latest version of isort, which is a problem when isort gets a major version bump. Rather than try to pin the version, I've done the necessary to make isort5 happy with synapse.	4 years ago
Erik Johnston	5cdca53aa0	Merge different Resource implementation classes (#7732 )	4 years ago
Erik Johnston	e07a8caf58	Add support for using rust-python-jaeger-reporter (#7697 )	5 years ago
Erik Johnston	37f6823f5b	Add instance name to RDATA/POSITION commands (#7364 ) This is primarily for allowing us to send those commands from workers, but for now simply allows us to ignore echoed RDATA/POSITION commands that we sent (we get echoes of sent commands when using redis). Currently we log a WARNING on the master process every time we receive an echoed RDATA.	5 years ago
Erik Johnston	f3ceaf4323	Trace non-JSON APIs, /media, /key etc	5 years ago
Amber Brown	864f144543	Fix up some typechecking (#6150 ) * type checking fixes * changelog	5 years ago
Amber Brown	b617864cd9	Fix for structured logging tests stomping on logs (#6023 )	5 years ago
Erik Johnston	d8517da85b	Don't assume there is a 'self' arg in @trace decorator	5 years ago
Jorik Schellekens	bc604e7f94	Gracefully handle log context slips and missing opentracing import errors. (#5988 )	5 years ago
Jorik Schellekens	909827b422	Add opentracing to all client servlets (#5983 )	5 years ago
Jorik Schellekens	b9cfd3c375	Fix opentracing contexts missing from outbound replication requests (#5982 )	5 years ago
Jorik Schellekens	a90d16dabc	Opentrace device lists (#5853 ) Trace device list changes.	5 years ago
Jorik Schellekens	8767b63a82	Propagate opentracing contexts through EDUs (#5852 ) Propagate opentracing contexts through EDUs Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	5 years ago
Jorik Schellekens	812ed6b0d5	Opentracing across workers (#5771 ) Propagate opentracing contexts across workers Also includes some Convenience modifications to opentracing for servlets, notably: - Add boolean to skip the whitelisting check on inject extract methods. - useful when injecting into carriers locally. Otherwise we'd always have to include our own servername and whitelist our servername - start_active_span_from_request instead of header - Add boolean to decide whether to extract context from a request to a servlet	5 years ago
Jorik Schellekens	c886f976e0	Opentracing doc update (#5776 ) Update opentracing docs to use the unified 'trace' method	5 years ago
Jorik Schellekens	3641784e8c	Make Jaeger fully configurable (#5694 ) * Allow Jaeger to be configured * Update sample config	5 years ago
Amber Brown	4806651744	Replace returnValue with return (#5736 )	5 years ago
Jorik Schellekens	18a466b84e	Opentracing Utils (#5722 ) * Add decerators for tracing functions * Use the new clean contexts * Context and edu utils * Move opentracing setters * Move whitelisting * Sectioning comments * Better args wrapper * Docstrings Co-Authored-By: Erik Johnston <erik@matrix.org> * Remove unused methods. * Don't use global * One tracing decorator to rule them all.	5 years ago
Jorik Schellekens	826e6ec3bd	Opentracing Documentation (#5703 ) * Opentracing survival guide * Update decorator names in doc * Doc cleanup These are all alterations as a result of comments in #5703, it includes mostly typos and clarifications. The most interesting changes are: - Split developer and user docs into two sections - Add a high level description of OpenTracing * newsfile * Move contributer specific info to docstring. * Sample config. * Trailing whitespace. * Update 5703.misc * Apply suggestions from code review Mostly just rewording parts of the docs for clarity. Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	5 years ago
Jorik Schellekens	7b8bc61834	Don't accept opentracing data from clients. (#5715 ) * Don't accept opentracing data from clients. * newsfile	5 years ago
Richard van der Hoff	82345bc09a	Clean up opentracing configuration options (#5712 ) Clean up config settings and dead code. This is mostly about cleaning up the config format, to bring it into line with our conventions. In particular: * There should be a blank line after `## Section ##' headings * There should be a blank line between each config setting * There should be a `#`-only line between a comment and the setting it describes * We don't really do the `# #` style commenting-out of whole sections if we can help it * rename `tracer_enabled` to `enabled` While we're here, do more config parsing upfront, which makes it easier to use later on. Also removes redundant code from LogContextScopeManager. Also changes the changelog fragment to a `feature` - it's exciting!	5 years ago
Jorik Schellekens	38a6d3eea7	Add basic opentracing support (#5544 ) * Configure and initialise tracer Includes config options for the tracer and sets up JaegerClient. * Scope manager using LogContexts We piggy-back our tracer scopes by using log context. The current log context gives us the current scope. If new scope is created we create a stack of scopes in the context. * jaeger is a dependency now * Carrier inject and extraction for Twisted Headers * Trace federation requests on the way in and out. The span is created in _started_processing and closed in _finished_processing because we need a meaningful log context. * Create logcontext for new scope. Instead of having a stack of scopes in a logcontext we create a new context for a new scope if the current logcontext already has a scope. * Remove scope from logcontext if logcontext is top level * Disable tracer if not configured * typo * Remove dependence on jaeger internals * bools * Set service name * :Explicitely state that the tracer is disabled * Black is the new black * Newsfile * Code style * Use the new config setup. * Generate config. * Copyright * Rename config to opentracing * Remove user whitelisting * Empty whitelist by default * User ConfigError instead of RuntimeError * Use isinstance * Use tag constants for opentracing. * Remove debug comment and no need to explicitely record error * Two errors a "s(c)entry" * Docstrings! * Remove debugging brainslip * Homeserver Whitlisting * Better opentracing config comment * linting * Inclue worker name in service_name * Make opentracing an optional dependency * Neater config retreival * Clean up dummy tags * Instantiate tracing as object instead of global class * Inlcude opentracing as a homeserver member. * Thread opentracing to the request level * Reference opetnracing through hs * Instantiate dummy opentracin g for tests. * About to revert, just keeping the unfinished changes just in case * Revert back to global state, commit number: 9ce4a3d9067bf9889b86c360c05ac88618b85c4f * Use class level methods in tracerutils * Start and stop requests spans in a place where we have access to the authenticated entity * Seen it, isort it * Make sure to close the active span. * I'm getting black and blue from this. * Logger formatting Co-Authored-By: Erik Johnston <erik@matrix.org> * Outdated comment * Import opentracing at the top * Return a contextmanager * Start tracing client requests from the servlet * Return noop context manager if not tracing * Explicitely say that these are federation requests * Include servlet name in client requests * Use context manager * Move opentracing to logging/ * Seen it, isort it again! * Ignore twisted return exceptions on context exit * Escape the scope * Scopes should be entered to make them useful. * Nicer decorator names * Just one init, init? * Don't need to close something that isn't open * Docs make you smarter	5 years ago

30 Commits (bce0c91d9a89097c94d687aadfed9b4ebbdcc75d)