180 Commits (c5988a8eb7279f1de2d09258a41ff21158eb62c5)

Author	SHA1	Message	Date
Richard van der Hoff	858363d0b7	Generics for `ObservableDeferred` (#10491) ... Now that `Deferred` is a generic class, let's update `ObeservableDeferred` to follow suit.	3 years ago
Jonathan de Jong	bf72d10dbf	Use inline type hints in various other places (in `synapse/`) (#10380)	3 years ago
Richard van der Hoff	1d143074c5	Improve opentracing annotations for Notifier (#10111) ... The existing tracing reports an error each time there is a timeout, which isn't really representative. Additionally, we log things about the way `wait_for_events` works (eg, the result of the callback) to the *parent* span, which is confusing.	4 years ago
Richard van der Hoff	b378d98c8f	Add debug logging for issue #9533 (#9959) ... Hopefully this will help us track down where to-device messages are getting lost/delayed.	4 years ago
Richard van der Hoff	294c675033	Remove `synapse.types.Collection` (#9856) ... This is no longer required, since we have dropped support for Python 3.5.	4 years ago
Jonathan de Jong	4b965c862d	Remove redundant "coding: utf-8" lines (#9786) ... Part of #9744 Removes all redundant `# -*- coding: utf-8 -*-` lines from files, as python 3 automatically reads source code as utf-8 now. `Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>`	4 years ago
Jonathan de Jong	2ca4e349e9	Bugbear: Add Mutable Parameter fixes (#9682) ... Part of #9366 Adds in fixes for B006 and B008, both relating to mutable parameter lint errors. Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>	4 years ago
Jonathan de Jong	e2b8a90897	Update mypy configuration: `no_implicit_optional = True` (#9742)	4 years ago
Erik Johnston	33548f37aa	Improve tracing for to device messages (#9686)	4 years ago
Eric Eastwood	0a00b7ff14	Update black, and run auto formatting over the codebase (#9381) ... - Update black version to the latest - Run black auto formatting over the codebase - Run autoformatting according to [`docs/code_style.md `](80d6dc9783/docs/code_style.md) - Update `code_style.md` docs around installing black to use the correct version	4 years ago
Erik Johnston	a03d71dc9d	Fix "Starting metrics collection from sentinel context" errors (#9053)	4 years ago
Patrick Cloke	be2db93b3c	Do not assume that the contents dictionary includes history_visibility. (#8945)	4 years ago
Erik Johnston	a6ea1a957e	Don't pull event from DB when handling replication traffic. (#8669) ... I was trying to make it so that we didn't have to start a background task when handling RDATA, but that is a bigger job (due to all the code in `generic_worker`). However I still think not pulling the event from the DB may help reduce some DB usage due to replication, even if most workers will simply go and pull that event from the DB later anyway. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	4 years ago
Erik Johnston	2b7c180879	Start fewer opentracing spans (#8640) ... #8567 started a span for every background process. This is good as it means all Synapse code that gets run should be in a span (unless in the sentinel logging context), but it means we generate about 15x the number of spans as we did previously. This PR attempts to reduce that number by a) not starting one for send commands to Redis, and b) deferring starting background processes until after we're sure they're necessary. I don't really know how much this will help.	4 years ago
Patrick Cloke	34a5696f93	Fix typos and spelling errors. (#8639)	4 years ago
Will Hunt	c276bd9969	Send some ephemeral events to appservices (#8437) ... Optionally sends typing, presence, and read receipt information to appservices.	4 years ago
Erik Johnston	921a3f8a59	Fix not sending events over federation when using sharded event persisters (#8536) ... * Fix outbound federaion with multiple event persisters. We incorrectly notified federation senders that the minimum persisted stream position had advanced when we got an `RDATA` from an event persister. Notifying of federation senders already correctly happens in the notifier, so we just delete the offending line. * Change some interfaces to use RoomStreamToken. By enforcing use of `RoomStreamTokens` we make it less likely that people pass in random ints that they got from somewhere random.	4 years ago
Patrick Cloke	a93f3121f8	Add type hints to some handlers (#8505)	4 years ago
Erik Johnston	ea70f1c362	Various clean ups to room stream tokens. (#8423)	4 years ago
Erik Johnston	ac11fcbbb8	Add EventStreamPosition type (#8388) ... The idea is to remove some of the places we pass around `int`, where it can represent one of two things: 1. the position of an event in the stream; or 2. a token that partitions the stream, used as part of the stream tokens. The valid operations are then: 1. did a position happen before or after a token; 2. get all events that happened before or after a token; and 3. get all events between two tokens. (Note that we don't want to allow other operations as we want to change the tokens to be vector clocks rather than simple ints)	4 years ago
Patrick Cloke	aec294ee0d	Use slots in attrs classes where possible (#8296) ... slots use less memory (and attribute access is faster) while slightly limiting the flexibility of the class attributes. This focuses on objects which are instantiated "often" and for short periods of time.	4 years ago
Erik Johnston	fe8ed1b46f	Make `StreamToken.room_key` be a `RoomStreamToken` instance. (#8281)	4 years ago
Erik Johnston	5d3e306d9f	Clean up `Notifier.on_new_room_event` code path (#8288) ... The idea here is that we pass the `max_stream_id` to everything, and only use the stream ID of the particular event to figure out *when* the max stream position has caught up to the event and we can notify people about it. This is to maintain the distinction between the position of an item in the stream (i.e. event A has stream ID 513) and a token that can be used to partition the stream (i.e. give me all events after stream ID 352). This distinction becomes important when the tokens are more complicated than a single number, which they will be once we start tracking the position of multiple writers in the tokens. The valid operations here are: 1. Is a position before or after a token 2. Fetching all events between two tokens 3. Merging multiple tokens to get the "max", i.e. `C = max(A, B)` means that for all positions P where P is before A *or* before B, then P is before C. Future PR will change the token type to a dedicated type.	4 years ago
Erik Johnston	0f545e6b96	Clean up types for PaginationConfig (#8250) ... This removes `SourcePaginationConfig` and `get_pagination_rows`. The reasoning behind this is that these generic classes/functions erased the types of the IDs it used (i.e. instead of passing around `StreamToken` it'd pass in e.g. `token.room_key`, which don't have uniform types).	4 years ago
Patrick Cloke	c619253db8	Stop sub-classing object (#8249)	4 years ago
Erik Johnston	9d1e4942ab	Fix typing for notifier (#8064)	4 years ago
Erik Johnston	a1e9bb9eae	Add typing info to Notifier (#8058)	4 years ago
Patrick Cloke	e19de43eb5	Convert streams to async. (#8014)	4 years ago
Patrick Cloke	38e1fac886	Fix some spelling mistakes / typos. (#7811)	4 years ago
Patrick Cloke	edd3b0747c	Fix new flake8 errors (#7489) ... This is a cherry-pick of 1a1da60ad2 (#7470) to the release-v1.13.0 branch.	5 years ago
Erik Johnston	1a1da60ad2	Fix new flake8 errors (#7470)	5 years ago
Patrick Cloke	b0cbc57375	Convert the synapse.notifier module to async/await. (#7395)	5 years ago
Erik Johnston	3eab76ad43	Don't relay REMOTE_SERVER_UP cmds to same conn. (#7352) ... For direct TCP connections we need the master to relay REMOTE_SERVER_UP commands to the other connections so that all instances get notified about it. The old implementation just relayed to all connections, assuming that sending back to the original sender of the command was safe. This is not true for redis, where commands sent get echoed back to the sender, which was causing master to effectively infinite loop sending and then re-receiving REMOTE_SERVER_UP commands that it sent. The fix is to ensure that we only relay to *other* connections and not to the connection we received the notification from. Fixes #7334.	5 years ago
Erik Johnston	a8a50f5b57	Wake up transaction queue when remote server comes back online (#6706) ... This will be used to retry outbound transactions to a remote server if we think it might have come back up.	5 years ago
Erik Johnston	8437e2383e	Port SyncHandler to async/await	5 years ago
Erik Johnston	69f0054ce6	Port to use state storage	5 years ago
Andrew Morgan	4548d1f87e	Remove unnecessary parentheses around return statements (#5931) ... Python will return a tuple whether there are parentheses around the returned values or not. I'm just sick of my editor complaining about this all over the place :)	5 years ago
Amber Brown	4806651744	Replace returnValue with return (#5736)	5 years ago
Amber Brown	463b072b12	Move logging utilities out of the side drawer of util/ and into logging/ (#5606)	5 years ago
Amber Brown	32e7c9e7f2	Run Black. (#5482)	6 years ago
Richard van der Hoff	c7325776a7	Remove redundant PreserveLoggingContext ... Both (!) things that register as replication listeners do the right thing wrt logcontexts, so this is redundant.	6 years ago
Richard van der Hoff	daa10e3e66	Remove unused `wait_for_replication` method ... I guess this was used once? It's not now, anyway.	6 years ago
Amber Brown	b69216f768	Make the metrics less racy (#4061)	6 years ago
Richard van der Hoff	a87d419a85	Run notify_app_services as a bg process ... This ensures that its resource usage metrics get recorded somewhere rather than getting lost. (It also fixes an error when called from a nested logging context which completes before the bg process)	6 years ago
Erik Johnston	80d2d50f47	Fixup	6 years ago
Erik Johnston	9407bcf37a	Replace custom DeferredTimeoutError with defer.TimeoutError	6 years ago
Erik Johnston	a334e1cace	Update to use new timeout function everywhere. ... The existing deferred timeout helper function (and the one into twisted) suffer from a bug when a deferred's canceller throws an exception, #3842. The new helper function doesn't suffer from this problem.	6 years ago
Amber Brown	b37c472419	Rename async to async_helpers because `async` is a keyword on Python 3.7 (#3678)	6 years ago
Matthew Hodgson	5797f5542b	WIP to announce deleted devices over federation ... Previously we queued up the poke correctly when the device was deleted, but then the actual EDU wouldn't get sent, as the device was no longer known. Instead, we now send EDUs for deleted devices too if there's a poke for them.	6 years ago
Amber Brown	49af402019	run isort	6 years ago