77 Commits (c7446906bdd2e30e5e830a77c05ab9a15aece254)

Author	SHA1	Message	Date
Eric Eastwood	7b67e93d49	Provide more info why we don't have any thumbnails to serve (#13038) ... Fix https://github.com/matrix-org/synapse/issues/13016 ## New error code and status ### Before Previously, we returned a `404` for `/thumbnail` which isn't even in the spec. ```json { "errcode": "M_NOT_FOUND", "error": "Not found [b'hs1', b'tefQeZhmVxoiBfuFQUKRzJxc']" } ``` ### After What does the spec say? > 400: The request does not make sense to the server, or the server cannot thumbnail the content. For example, the client requested non-integer dimensions or asked for negatively-sized images. > > *-- https://spec.matrix.org/v1.1/client-server-api/#get_matrixmediav3thumbnailservernamemediaid* Now with this PR, we respond with a `400` when we don't have thumbnails to serve and we explain why we might not have any thumbnails. ```json { "errcode": "M_UNKNOWN", "error": "Cannot find any thumbnails for the requested media ([b'example.com', b'12345']). This might mean the media is not a supported_media_format=(image/jpeg, image/jpg, image/webp, image/gif, image/png) or that thumbnailing failed for some other reason. (Dynamic thumbnails are disabled on this server.)", } ``` > Cannot find any thumbnails for the requested media ([b'example.com', b'12345']). This might mean the media is not a supported_media_format=(image/jpeg, image/jpg, image/webp, image/gif, image/png) or that thumbnailing failed for some other reason. (Dynamic thumbnails are disabled on this server.) --- We still respond with a 404 in many other places. But we can iterate on those later and maybe keep some in some specific places after spec updates/clarification: https://github.com/matrix-org/matrix-spec/issues/1122 We can also iterate on the bugs where Synapse doesn't thumbnail when it should in other issues/PRs.	2 years ago
Jacek Kuśnierz	50f0e4028b	Allow dependency errors to pass through (#13113) ... Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2 years ago
Shay	493c2fc44a	Remove code generating comments in configuration file (#12941)	2 years ago
Andrew Morgan	2fc787c341	Add config options for media retention (#12732)	3 years ago
Patrick Cloke	4586119f0b	Add missing type hints to config classes. (#12402)	3 years ago
David Robertson	313581e4e9	Use importlib.metadata to read requirements (#12088) ... * Pull runtime dep checks into their own module * Reimplement `check_requirements` using `importlib` I've tried to make this clearer. We start by working out which of Synapse's requirements we need to be installed here and now. I was surprised that there wasn't an easier way to see which packages were installed by a given extra. I've pulled out the error messages into functions that deal with "is this for an extra or not". And I've rearranged the loop over two different sets of requirements into one loop with a "must be instaled" flag. I hope you agree that this is clearer. * Test cases	3 years ago
Patrick Cloke	cbd82d0b2d	Convert all namedtuples to attrs. (#11665) ... To improve type hints throughout the code.	3 years ago
Olivier Wilkinson (reivilibre)	4dd9ea8f4f	Revert "Revert accidental fast-forward merge from v1.49.0rc1" ... This reverts commit 158d73ebdd.	3 years ago
Sean Quah	158d73ebdd	Revert accidental fast-forward merge from v1.49.0rc1 ... Revert "Sort internal changes in changelog" Revert "Update CHANGES.md" Revert "1.49.0rc1" Revert "Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505) (#11527)" Revert "Refactors in `_generate_sync_entry_for_rooms` (#11515)" Revert "Correctly register shutdown handler for presence workers (#11518)" Revert "Fix `ModuleApi.looping_background_call` for non-async functions (#11524)" Revert "Fix 'delete room' admin api to work on incomplete rooms (#11523)" Revert "Correctly ignore invites from ignored users (#11511)" Revert "Fix the test breakage introduced by #11435 as a result of concurrent PRs (#11522)" Revert "Stabilise support for MSC2918 refresh tokens as they have now been merged into the Matrix specification. (#11435)" Revert "Save the OIDC session ID (sid) with the device on login (#11482)" Revert "Add admin API to get some information about federation status (#11407)" Revert "Include bundled aggregations in /sync and related fixes (#11478)" Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505)" Revert "Update backward extremity docs to make it clear that it does not indicate whether we have fetched an events' `prev_events` (#11469)" Revert "Support configuring the lifetime of non-refreshable access tokens separately to refreshable access tokens. (#11445)" Revert "Add type hints to `synapse/tests/rest/admin` (#11501)" Revert "Revert accidental commits to develop." Revert "Newsfile" Revert "Give `tests.server.setup_test_homeserver` (nominally!) the same behaviour" Revert "Move `tests.utils.setup_test_homeserver` to `tests.server`" Revert "Convert one of the `setup_test_homeserver`s to `make_test_homeserver_synchronous`" Revert "Disambiguate queries on `state_key` (#11497)" Revert "Comments on the /sync tentacles (#11494)" Revert "Clean up tests.storage.test_appservice (#11492)" Revert "Clean up `tests.storage.test_main` to remove use of legacy code. (#11493)" Revert "Clean up `tests.test_visibility` to remove legacy code. (#11495)" Revert "Minor cleanup on recently ported doc pages (#11466)" Revert "Add most of the missing type hints to `synapse.federation`. (#11483)" Revert "Avoid waiting for zombie processes in `synctl stop` (#11490)" Revert "Fix media repository failing when media store path contains symlinks (#11446)" Revert "Add type annotations to `tests.storage.test_appservice`. (#11488)" Revert "`scripts-dev/sign_json`: support for signing events (#11486)" Revert "Add MSC3030 experimental client and federation API endpoints to get the closest event to a given timestamp (#9445)" Revert "Port wiki pages to documentation website (#11402)" Revert "Add a license header and comment. (#11479)" Revert "Clean-up get_version_string (#11468)" Revert "Link background update controller docs to summary (#11475)" Revert "Additional type hints for config module. (#11465)" Revert "Register the login redirect endpoint for v3. (#11451)" Revert "Update openid.md" Revert "Remove mention of OIDC certification from Dex (#11470)" Revert "Add a note about huge pages to our Postgres doc (#11467)" Revert "Don't start Synapse master process if `worker_app` is set (#11416)" Revert "Expose worker & homeserver as entrypoints in `setup.py` (#11449)" Revert "Bundle relations of relations into the `/relations` result. (#11284)" Revert "Fix `LruCache` corruption bug with a `size_callback` that can return 0 (#11454)" Revert "Eliminate a few `Any`s in `LruCache` type hints (#11453)" Revert "Remove unnecessary `json.dumps` from `tests.rest.admin` (#11461)" Revert "Merge branch 'master' into develop" This reverts commit 26b5d2320f. This reverts commit bce4220f38. This reverts commit 966b5d0fa0. This reverts commit 088d748f2c. This reverts commit 14d593f72d. This reverts commit 2a3ec6facf. This reverts commit eccc49d755. This reverts commit b1ecd19c5d. This reverts commit 9c55dedc8c. This reverts commit 2d42e586a8. This reverts commit 2f053f3f82. This reverts commit a15a893df8. This reverts commit 8b4b153c9e. This reverts commit 494ebd7347. This reverts commit a77c369897. This reverts commit 4eb77965cd. This reverts commit 637df95de6. This reverts commit e5f426cd54. This reverts commit 8cd68b8102. This reverts commit 6cae125e20. This reverts commit 7be88fbf48. This reverts commit b3fd99b74a. This reverts commit f7ec6e7d9e. This reverts commit 5640992d17. This reverts commit d26808dd85. This reverts commit f91624a595. This reverts commit 16d39a5490. This reverts commit 8a4c296987. This reverts commit 49e1356ee3. This reverts commit d2279f471b. This reverts commit b50e39df57. This reverts commit 858d80bf0f. This reverts commit 435f044807. This reverts commit f61462e1be. This reverts commit a6f1a3abec. This reverts commit 84dc50e160. This reverts commit ed635d3285. This reverts commit 7b62791e00. This reverts commit 153194c771. This reverts commit f44d729d4c. This reverts commit a265fbd397. This reverts commit b9fef1a7cd. This reverts commit b0eb64ff7b. This reverts commit f1795463bf. This reverts commit 70cbb1a5e3. This reverts commit 42bf020463. This reverts commit 379f2650cf. This reverts commit 7ff22d6da4. This reverts commit 5a0b652d36. This reverts commit 432a174bc1. This reverts commit b14f8a1baf, reversing changes made to e713855dca.	3 years ago
Patrick Cloke	f44d729d4c	Additional type hints for config module. (#11465) ... This adds some misc. type hints to helper methods used in the `synapse.config` module.	3 years ago
Patrick Cloke	f4b1a9a527	Require direct references to configuration variables. (#10985) ... This removes the magic allowing accessing configurable variables directly from the config object. It is now required that a specific configuration class is used (e.g. `config.foo` must be replaced with `config.server.foo`).	3 years ago
Kento Okamoto	72935b7c50	Add warnings to ip_range_blacklist usage with proxies (#10129) ... Per issue #9812 using `url_preview_ip_range_blacklist` with a proxy via `HTTPS_PROXY` or `HTTP_PROXY` environment variables has some inconsistent bahavior than mentioned. This PR changes the following: - Changes the Sample Config file to include a note mentioning that `url_preview_ip_range_blacklist` and `ip_range_blacklist` is ignored when using a proxy - Changes some logic in synapse/config/repository.py to send a warning when both `*ip_range_blacklist` configs and a proxy environment variable are set and but no longer throws an error. Signed-off-by: Kento Okamoto <kentokamoto@protonmail.com>	3 years ago
Jonathan de Jong	bf72d10dbf	Use inline type hints in various other places (in `synapse/`) (#10380)	3 years ago
Dirk Klimpel	56fd5fa8e1	Update links to documentation in sample config (#10287) ... Signed-off-by: Dirk Klimpel dirk@klimpel.org	3 years ago
Aaron Raimist	e6245e6d48	Mention that you need to configure max upload size in reverse proxy as well (#10122) ... Signed-off-by: Aaron Raimist <aaron@raim.ist>	4 years ago
rkfg	c9a2b5d402	More robust handling of the Content-Type header for thumbnail generation (#9788) ... Signed-off-by: Sergey Shpikin <rkfg@rkfg.me>	4 years ago
Jonathan de Jong	4b965c862d	Remove redundant "coding: utf-8" lines (#9786) ... Part of #9744 Removes all redundant `# -*- coding: utf-8 -*-` lines from files, as python 3 automatically reads source code as utf-8 now. `Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>`	4 years ago
Jonathan de Jong	27d2820c33	Enable flake8-bugbear, but disable most checks. (#9499) ... * Adds B00 to ignored checks. * Fixes remaining issues.	4 years ago
Richard van der Hoff	1b2d6d55c5	Remove vestiges of uploads_path config (#9462) ... `uploads_path` was a thing that was never used; most of it was removed in #6628 but a few vestiges remained.	4 years ago
Eric Eastwood	0a00b7ff14	Update black, and run auto formatting over the codebase (#9381) ... - Update black version to the latest - Run black auto formatting over the codebase - Run autoformatting according to [`docs/code_style.md `](80d6dc9783/docs/code_style.md) - Update `code_style.md` docs around installing black to use the correct version	4 years ago
Patrick Cloke	4ca054a4ea	Convert blacklisted IPv4 addresses to compatible IPv6 addresses. (#9240) ... Also add a few more IP ranges to the default blacklist.	4 years ago
Patrick Cloke	344ab0b53a	Default to blacklisting reserved IP ranges and add a whitelist. (#8870) ... This defaults `ip_range_blacklist` to reserved IP ranges and also adds an `ip_range_whitelist` setting to override it.	4 years ago
Richard van der Hoff	ab7a24cc6b	Better formatting for config errors from modules (#8874) ... The idea is that the parse_config method of extension modules can raise either a ConfigError or a JsonValidationError, and it will be magically turned into a legible error message. There's a few components to it: * Separating the "path" and the "message" parts of a ConfigError, so that we can fiddle with the path bit to turn it into an absolute path. * Generally improving the way ConfigErrors get printed. * Passing in the config path to load_module so that it can wrap any exceptions that get caught appropriately.	4 years ago
Mateusz Przybyłowicz	ca2db5dd0c	Increase default max_upload_size from 10M to 50M (#8502) ... Signed-off-by: Mateusz Przybyłowicz <uamfhq@gmail.com>	4 years ago
Erik Johnston	b44bdd7f7b	Support running multiple media repos. (#7706) ... This requires a new config option to specify which media repo should be responsible for running background jobs to e.g. clear out expired URL preview caches.	5 years ago
WGH	e55ee7c32f	Add support for webp thumbnailing (#7586) ... Closes #4382 Signed-off-by: Maxim Plotnikov <wgh@torlan.ru>	5 years ago
Tristan Lins	c07fca9e2f	Clarify the comments for media_storage_providers options (#7272)	5 years ago
Andrew Morgan	a48138784e	Allow specifying the value of Accept-Language header for URL previews (#7265)	5 years ago
Richard van der Hoff	98247c4a0e	Remove unused, undocumented "content repo" resource (#6628) ... This looks like it got half-killed back in #888. Fixes #6567.	5 years ago
Amber Brown	f743108a94	Refactor HomeserverConfig so it can be typechecked (#6137)	5 years ago
Amber Brown	864f144543	Fix up some typechecking (#6150) ... * type checking fixes * changelog	5 years ago
Matthew Hodgson	7ef319aefe	fix broken copyrights	5 years ago
Jorik Schellekens	6604b64fae	Check dependencies on setup in the nicer way. (#5989)	5 years ago
Amber H. Brown	18bdac8ee4	fix config being a dict, actually	5 years ago
Amber Brown	0b6fbb28a8	Don't load the media repo when configured to use an external media repo (#5754)	5 years ago
Richard van der Hoff	16b52642e2	Don't load the generated config as the default. ... It's too confusing.	6 years ago
Richard van der Hoff	7c2f8881a9	Ensure that all config options have sensible defaults ... This will enable us to skip the unintuitive behaviour where the generated config and default config are the same thing.	6 years ago
Richard van der Hoff	c3c6b00d95	Pass config_dir_path and data_dir_path into Config.read_config. (#5522) ... * Pull config_dir_path and data_dir_path calculation out of read_config_files * Pass config_dir_path and data_dir_path into read_config	6 years ago
Amber Brown	32e7c9e7f2	Run Black. (#5482)	6 years ago
Richard van der Hoff	1565ebec2c	more config comment updates	6 years ago
Richard van der Hoff	1a7104fde3	Blacklist 0.0.0.0 and :: by default for URL previews	6 years ago
Richard van der Hoff	fd463b4f5d	Comment out most options in the generated config. (#4863) ... Make it so that most options in the config are optional, and commented out in the generated config. The reasons this is a good thing are as follows: * If we decide that we should change the default for an option, we can do so, and only those admins that have deliberately chosen to override that option will be stuck on the old setting. * It moves us towards a point where we can get rid of the super-surprising feature of synapse where the default settings for the config come from the generated yaml. * It makes setting up a test config for unit testing an order of magnitude easier (see forthcoming PR). * It makes the generated config more consistent, and hopefully easier for users to understand.	6 years ago
Richard van der Hoff	5f9bdf90fe	Attempt to make default config more consistent ... The general idea here is that config examples should just have a hash and no extraneous whitespace, both to make it easier for people who don't understand yaml, and to make the examples stand out from the comments.	6 years ago
Richard van der Hoff	9c2af7b2c5	Add a script to generate a clean config file (#4315)	6 years ago
Richard van der Hoff	ef771cc4c2	Fix a number of flake8 errors ... Broadly three things here: * disable W504 which seems a bit whacko * remove a bunch of `as e` expressions from exception handlers that don't use them * use `r""` for strings which include backslashes Also, we don't use pep8 any more, so we can get rid of the duplicate config there.	6 years ago
Amber Brown	49af402019	run isort	6 years ago
Felix Schäfer	4ef76f3ac4	Add private IPv6 addresses to preview blacklist #3312 ... The added addresses are expected to be local or loopback addresses and shouldn't be spidered for previews. Signed-off-by: Felix Schäfer <felix@thegcat.net>	7 years ago
Erik Johnston	d69768348f	Fix passing wrong config to provider constructor	7 years ago
Erik Johnston	8e85220373	Remove duplicate directory test	7 years ago
Erik Johnston	aae77da73f	Fixup comments	7 years ago