91 Commits (c7446906bdd2e30e5e830a77c05ab9a15aece254)

Author	SHA1	Message	Date
Shay	493c2fc44a	Remove code generating comments in configuration file (#12941)	2 years ago
Patrick Cloke	4586119f0b	Add missing type hints to config classes. (#12402)	3 years ago
reivilibre	84bfe47b01	Re-apply: Move glob_to_regex and re_word_boundary to matrix-python-common #11505 (#11687) ... Co-authored-by: Sean Quah <seanq@element.io>	3 years ago
Patrick Cloke	0cc3bf97b4	Additional type hints for the config module, part 2. (#11480)	3 years ago
Sean Quah	088d748f2c	Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505) (#11527) ... This reverts commit a77c369897.	3 years ago
Sean Quah	a77c369897	Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505)	3 years ago
Patrick Cloke	55669bd3de	Add missing type hints to config base classes (#11377)	3 years ago
Patrick Cloke	4d6d38ac2f	Remove dead code from acme support. (#11393)	3 years ago
Nicolai Søborg	e2dabec996	Docs: Quote wildcard `federation_certificate_verification_whitelist` (#11381) ... Otherwise I get this beautiful stacktrace: ``` python3 -m synapse.app.homeserver --config-path /etc/matrix/homeserver.yaml Traceback (most recent call last): File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main return _run_code(code, main_globals, None, File "/usr/lib/python3.8/runpy.py", line 87, in _run_code exec(code, run_globals) File "/root/synapse/synapse/app/homeserver.py", line 455, in <module> main() File "/root/synapse/synapse/app/homeserver.py", line 445, in main hs = setup(sys.argv[1:]) File "/root/synapse/synapse/app/homeserver.py", line 345, in setup config = HomeServerConfig.load_or_generate_config( File "/root/synapse/synapse/config/_base.py", line 671, in load_or_generate_config config_dict = read_config_files(config_files) File "/root/synapse/synapse/config/_base.py", line 717, in read_config_files yaml_config = yaml.safe_load(file_stream) File "/root/synapse/env/lib/python3.8/site-packages/yaml/__init__.py", line 125, in safe_load return load(stream, SafeLoader) File "/root/synapse/env/lib/python3.8/site-packages/yaml/__init__.py", line 81, in load return loader.get_single_data() File "/root/synapse/env/lib/python3.8/site-packages/yaml/constructor.py", line 49, in get_single_data node = self.get_single_node() File "/root/synapse/env/lib/python3.8/site-packages/yaml/composer.py", line 36, in get_single_node document = self.compose_document() File "/root/synapse/env/lib/python3.8/site-packages/yaml/composer.py", line 55, in compose_document node = self.compose_node(None, None) File "/root/synapse/env/lib/python3.8/site-packages/yaml/composer.py", line 84, in compose_node node = self.compose_mapping_node(anchor) File "/root/synapse/env/lib/python3.8/site-packages/yaml/composer.py", line 133, in compose_mapping_node item_value = self.compose_node(node, item_key) File "/root/synapse/env/lib/python3.8/site-packages/yaml/composer.py", line 82, in compose_node node = self.compose_sequence_node(anchor) File "/root/synapse/env/lib/python3.8/site-packages/yaml/composer.py", line 110, in compose_sequence_node while not self.check_event(SequenceEndEvent): File "/root/synapse/env/lib/python3.8/site-packages/yaml/parser.py", line 98, in check_event self.current_event = self.state() File "/root/synapse/env/lib/python3.8/site-packages/yaml/parser.py", line 379, in parse_block_sequence_first_entry return self.parse_block_sequence_entry() File "/root/synapse/env/lib/python3.8/site-packages/yaml/parser.py", line 384, in parse_block_sequence_entry if not self.check_token(BlockEntryToken, BlockEndToken): File "/root/synapse/env/lib/python3.8/site-packages/yaml/scanner.py", line 116, in check_token self.fetch_more_tokens() File "/root/synapse/env/lib/python3.8/site-packages/yaml/scanner.py", line 227, in fetch_more_tokens return self.fetch_alias() File "/root/synapse/env/lib/python3.8/site-packages/yaml/scanner.py", line 610, in fetch_alias self.tokens.append(self.scan_anchor(AliasToken)) File "/root/synapse/env/lib/python3.8/site-packages/yaml/scanner.py", line 922, in scan_anchor raise ScannerError("while scanning an %s" % name, start_mark, yaml.scanner.ScannerError: while scanning an alias in "/etc/matrix/homeserver.yaml", line 614, column 5 expected alphabetic or numeric character, but found '.' in "/etc/matrix/homeserver.yaml", line 614, column 6 ``` Signed-off-by: Nicolai Søborg <git@xn--sb-lka.org>	3 years ago
David Robertson	797ee7812d	Relax `ignore-missing-imports` for modules that have stubs now and update mypy (#11006) ... Updating mypy past version 0.9 means that third-party stubs are no-longer distributed with typeshed. See http://mypy-lang.blogspot.com/2021/06/mypy-0900-released.html for details. We therefore pull in stub packages in setup.py Additionally, some modules that we were previously ignoring import failures for now have stubs. So let's use them. The rest of this change consists of fixups to make the newer mypy + stubs pass CI. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	3 years ago
Jonathan de Jong	95e47b2e78	[pyupgrade] `synapse/` (#10348) ... This PR is tantamount to running ``` pyupgrade --py36-plus --keep-percent-format `find synapse/ -type f -name "*.py"` ``` Part of #9744	3 years ago
Jonathan de Jong	bf72d10dbf	Use inline type hints in various other places (in `synapse/`) (#10380)	3 years ago
Brendan Abolivier	08c8469322	Remove support for ACME v1 (#10194) ... Fixes #9778 ACME v1 has been fully decommissioned for existing installs on June 1st 2021(see https://community.letsencrypt.org/t/end-of-life-plan-for-acmev1/88430/27), so we can now safely remove it from Synapse.	3 years ago
Richard van der Hoff	fe5dad46b0	Remove redundant code to reload tls cert (#10054) ... we don't need to reload the tls cert if we don't have any tls listeners. Follow-up to #9280.	4 years ago
Jerin J Titus	057ce7b754	Remove tls_fingerprints option (#9280) ... Signed-off-by: Jerin J Titus <72017981+jerinjtitus@users.noreply.github.com>	4 years ago
Richard van der Hoff	03318a766c	Merge pull request from GHSA-x345-32rc-8h85 ... * tests for push rule pattern matching * tests for acl pattern matching * factor out common `re.escape` * Factor out common re.compile * Factor out common anchoring code * add word_boundary support to `glob_to_regex` * Use `glob_to_regex` in push rule evaluator NB that this drops support for character classes. I don't think anyone ever used them. * Improve efficiency of globs with multiple wildcards The idea here is that we compress multiple `*` globs into a single `.*`. We also need to consider `?`, since `*?*` is as hard to implement efficiently as `**`. * add assertion on regex pattern * Fix mypy * Simplify glob_to_regex * Inline the glob_to_regex helper function Signed-off-by: Dan Callahan <danc@element.io> * Moar comments Signed-off-by: Dan Callahan <danc@element.io> Co-authored-by: Dan Callahan <danc@element.io>	4 years ago
Jonathan de Jong	4b965c862d	Remove redundant "coding: utf-8" lines (#9786) ... Part of #9744 Removes all redundant `# -*- coding: utf-8 -*-` lines from files, as python 3 automatically reads source code as utf-8 now. `Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>`	4 years ago
Dan Callahan	1d5f0e3529	Bump black configuration to target py36 (#9781) ... Signed-off-by: Dan Callahan <danc@element.io>	4 years ago
Patrick Cloke	4ff0201e62	Enable mypy checking for unreachable code and fix instances. (#8432)	4 years ago
Richard van der Hoff	c1ef579b63	Add prometheus metrics to track federation delays (#8430) ... Add a pair of federation metrics to track the delays in sending PDUs to/from particular servers.	4 years ago
Dagfinn Ilmari Mannsåker	a3f11567d9	Replace all remaining six usage with native Python 3 equivalents (#7704)	5 years ago
Patrick Cloke	509e381afa	Clarify list/set/dict/tuple comprehensions and enforce via flake8 (#6957) ... Ensure good comprehension hygiene using flake8-comprehensions.	5 years ago
Brendan Abolivier	36af094017	Linters are hard but in they end they just want what's best for us	5 years ago
Brendan Abolivier	ef9c275d96	Add a separator for the config warning	5 years ago
Brendan Abolivier	5820ed905f	Add mention and warning about ACME v1 deprecation to the Synapse config	5 years ago
timfi	bce557175b	Allow empty federation_certificate_verification_whitelist (#6849)	5 years ago
Andrew Morgan	409c62b27b	Add config linting script that checks for bool casing (#6203) ... Add a linting script that enforces all boolean values in the default config be lowercase. This has annoyed me for a while so I decided to fix it.	5 years ago
Amber Brown	f743108a94	Refactor HomeserverConfig so it can be typechecked (#6137)	5 years ago
Amber Brown	850dcfd2d3	Fix well-known lookups with the federation certificate whitelist (#5997)	5 years ago
Jorik Schellekens	6d97843793	Config templating (#5900) ... Template config files * Imagine a system composed entirely of x, y, z etc and the basic operations.. Wait George, why XOR? Why not just neq? George: Eh, I didn't think of that.. Co-Authored-By: Erik Johnston <erik@matrix.org>	5 years ago
Amber Brown	be3b901ccd	Update the TLS cipher string and provide configurability for TLS on outgoing federation (#5550)	5 years ago
Richard van der Hoff	16b52642e2	Don't load the generated config as the default. ... It's too confusing.	6 years ago
Richard van der Hoff	edea4bb5be	Allow configuration of the path used for ACME account keys. ... Because sticking it in the same place as the config isn't necessarily the right thing to do.	6 years ago
Richard van der Hoff	c3c6b00d95	Pass config_dir_path and data_dir_path into Config.read_config. (#5522) ... * Pull config_dir_path and data_dir_path calculation out of read_config_files * Pass config_dir_path and data_dir_path into read_config	6 years ago
Amber Brown	32e7c9e7f2	Run Black. (#5482)	6 years ago
Richard van der Hoff	f8a45302c9	Fix `federation_custom_ca_list` configuration option. ... Previously, setting this option would cause an exception at startup.	6 years ago
Richard van der Hoff	e2dfb922e1	Validate federation server TLS certificates by default.	6 years ago
Andrew Morgan	6824ddd93d	Config option for verifying federation certificates (MSC 1711) (#4967)	6 years ago
Andrew Morgan	7998ca3a66	Document using a certificate with a full chain (#4849)	6 years ago
Richard van der Hoff	641c409e4e	Fix ACME config for python 2. (#4717) ... Fixes #4675.	6 years ago
Richard van der Hoff	5f9bdf90fe	Attempt to make default config more consistent ... The general idea here is that config examples should just have a hash and no extraneous whitespace, both to make it easier for people who don't understand yaml, and to make the examples stand out from the comments.	6 years ago
Brendan Abolivier	5a707a2f9a	Improve config documentation	6 years ago
Brendan Abolivier	45bb55c6de	Use a configuration parameter to give the domain to generate a certificate for	6 years ago
Richard van der Hoff	a4ce91396b	Disable TLS by default (#4614)	6 years ago
Richard van der Hoff	32b781bfe2	Fix error when loading cert if tls is disabled (#4618) ... If TLS is disabled, it should not be an error if no cert is given. Fixes #4554.	6 years ago
Richard van der Hoff	0ca2908653	fix tests	6 years ago
Richard van der Hoff	4fddf8fc77	Infer no_tls from presence of TLS listeners ... Rather than have to specify `no_tls` explicitly, infer whether we need to load the TLS keys etc from whether we have any TLS-enabled listeners.	6 years ago
Richard van der Hoff	086f6f27d4	Logging improvements around TLS certs ... Log which file we're reading keys and certs from, and refactor the code a bit in preparation for other work	6 years ago
Amber Brown	6e2a5aa050	ACME Reprovisioning (#4522)	6 years ago
Amber Brown	4ffd10f46d	Be tolerant of blank TLS fingerprints config (#4589)	6 years ago